Message ID | 1373870183-28063-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Sylwester Nawrocki |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1Uyce2-0006PZ-1o; Mon, 15 Jul 2013 08:52:26 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1Uyce0-0000RN-3a; Mon, 15 Jul 2013 08:52:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036Ab3GOGwW (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 15 Jul 2013 02:52:22 -0400 Received: from mail-pb0-f50.google.com ([209.85.160.50]:37632 "EHLO mail-pb0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753984Ab3GOGwV (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 15 Jul 2013 02:52:21 -0400 Received: by mail-pb0-f50.google.com with SMTP id wz7so10975461pbc.37 for <linux-media@vger.kernel.org>; Sun, 14 Jul 2013 23:52:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=sHcznIv4Do9WfEKlA0aW6rDoDw3oNAnWlM9vYYBoWpc=; b=Cl5A1MAW0NaDCgQxJFnkw/O2xzOdZDVwz/Q6iQoprVvWnpwD3R/I2/Ay1ftTX/rbmG F/1ROTH1OIdAkcab/VzFNSyLgT8ue+eldnL1UaJgDQvEj0xX0jOeMzaqN277DlzgmiEI N6qKxu5+gcQ1DinxkK91B7C2sOYv/rHYR+ktBj9vcnE35XzvWhAJffg0aFxr6WcoDgwj t2kcdBg33115/Nt++6yFIn7GJEwEhJMllPZJdTcTELh7A2tpgJWOpSclpn7yryoqccfn XK/1YR95l342gAv98cMJeI1Q4/ceOHXGs0xKB2sj/xNnlr/NVLPRy22CjiThVJ7+7Yum LBoQ== X-Received: by 10.66.188.2 with SMTP id fw2mr54655184pac.91.1373871140937; Sun, 14 Jul 2013 23:52:20 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id qb15sm62700301pab.13.2013.07.14.23.52.16 for <multiple recipients> (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 14 Jul 2013 23:52:20 -0700 (PDT) From: Sachin Kamat <sachin.kamat@linaro.org> To: linux-media@vger.kernel.org Cc: k.debski@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, Hans Verkuil <hans.verkuil@cisco.com> Subject: [PATCH 1/1] [media] s5p-g2d: Fix registration failure Date: Mon, 15 Jul 2013 12:06:23 +0530 Message-Id: <1373870183-28063-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQlyISSYytYxd8KHBUEpGG2CTrGT9E2ngVFY4cfGYGIvwg2txUGrkZHZIcfa6AvUOe2/myxW Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.15.63620 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Sachin Kamat
July 15, 2013, 6:36 a.m. UTC
Commit 1c1d86a1ea ("[media] v4l2: always require v4l2_dev,
rename parent to dev_parent") expects v4l2_dev to be always set.
It converted most of the drivers using the parent field of video_device
to v4l2_dev field. G2D driver did not set the parent field. Hence it got
left out. Without this patch we get the following boot warning and G2D
driver fails to register the video device.
WARNING: CPU: 0 PID: 1 at drivers/media/v4l2-core/v4l2-dev.c:775 __video_register_device+0xfc0/0x1028()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.11.0-rc1-00001-g1c3e372-dirty #9
[<c0014b7c>] (unwind_backtrace+0x0/0xf4) from [<c0011524>] (show_stack+0x10/0x14)
[<c0011524>] (show_stack+0x10/0x14) from [<c041d7a8>] (dump_stack+0x7c/0xb0)
[<c041d7a8>] (dump_stack+0x7c/0xb0) from [<c001dc94>] (warn_slowpath_common+0x6c/0x88)
[<c001dc94>] (warn_slowpath_common+0x6c/0x88) from [<c001dd4c>] (warn_slowpath_null+0x1c/0x24)
[<c001dd4c>] (warn_slowpath_null+0x1c/0x24) from [<c02cf8d4>] (__video_register_device+0xfc0/0x1028)
[<c02cf8d4>] (__video_register_device+0xfc0/0x1028) from [<c0311a94>] (g2d_probe+0x1f8/0x398)
[<c0311a94>] (g2d_probe+0x1f8/0x398) from [<c0247d54>] (platform_drv_probe+0x14/0x18)
[<c0247d54>] (platform_drv_probe+0x14/0x18) from [<c0246b10>] (driver_probe_device+0x108/0x220)
[<c0246b10>] (driver_probe_device+0x108/0x220) from [<c0246cf8>] (__driver_attach+0x8c/0x90)
[<c0246cf8>] (__driver_attach+0x8c/0x90) from [<c0245050>] (bus_for_each_dev+0x60/0x94)
[<c0245050>] (bus_for_each_dev+0x60/0x94) from [<c02462c8>] (bus_add_driver+0x1c0/0x24c)
[<c02462c8>] (bus_add_driver+0x1c0/0x24c) from [<c02472d0>] (driver_register+0x78/0x140)
[<c02472d0>] (driver_register+0x78/0x140) from [<c00087c8>] (do_one_initcall+0xf8/0x144)
[<c00087c8>] (do_one_initcall+0xf8/0x144) from [<c05b29e8>] (kernel_init_freeable+0x13c/0x1d8)
[<c05b29e8>] (kernel_init_freeable+0x13c/0x1d8) from [<c041a108>] (kernel_init+0xc/0x160)
[<c041a108>] (kernel_init+0xc/0x160) from [<c000e2f8>] (ret_from_fork+0x14/0x3c)
---[ end trace 4e0ec028b0028e02 ]---
s5p-g2d 12800000.g2d: Failed to register video device
s5p-g2d: probe of 12800000.g2d failed with error -22
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
---
drivers/media/platform/s5p-g2d/g2d.c | 1 +
1 file changed, 1 insertion(+)
Comments
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Monday, July 15, 2013 8:36 AM > > Commit 1c1d86a1ea ("[media] v4l2: always require v4l2_dev, rename > parent to dev_parent") expects v4l2_dev to be always set. > It converted most of the drivers using the parent field of video_device > to v4l2_dev field. G2D driver did not set the parent field. Hence it > got left out. Without this patch we get the following boot warning and > G2D driver fails to register the video device. > > WARNING: CPU: 0 PID: 1 at drivers/media/v4l2-core/v4l2-dev.c:775 > __video_register_device+0xfc0/0x1028() > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.11.0-rc1-00001-g1c3e372- > dirty #9 [<c0014b7c>] (unwind_backtrace+0x0/0xf4) from [<c0011524>] > (show_stack+0x10/0x14) [<c0011524>] (show_stack+0x10/0x14) from > [<c041d7a8>] (dump_stack+0x7c/0xb0) [<c041d7a8>] (dump_stack+0x7c/0xb0) > from [<c001dc94>] (warn_slowpath_common+0x6c/0x88) [<c001dc94>] > (warn_slowpath_common+0x6c/0x88) from [<c001dd4c>] > (warn_slowpath_null+0x1c/0x24) [<c001dd4c>] > (warn_slowpath_null+0x1c/0x24) from [<c02cf8d4>] > (__video_register_device+0xfc0/0x1028) > [<c02cf8d4>] (__video_register_device+0xfc0/0x1028) from [<c0311a94>] > (g2d_probe+0x1f8/0x398) [<c0311a94>] (g2d_probe+0x1f8/0x398) from > [<c0247d54>] (platform_drv_probe+0x14/0x18) [<c0247d54>] > (platform_drv_probe+0x14/0x18) from [<c0246b10>] > (driver_probe_device+0x108/0x220) [<c0246b10>] > (driver_probe_device+0x108/0x220) from [<c0246cf8>] > (__driver_attach+0x8c/0x90) [<c0246cf8>] (__driver_attach+0x8c/0x90) > from [<c0245050>] (bus_for_each_dev+0x60/0x94) [<c0245050>] > (bus_for_each_dev+0x60/0x94) from [<c02462c8>] > (bus_add_driver+0x1c0/0x24c) [<c02462c8>] (bus_add_driver+0x1c0/0x24c) > from [<c02472d0>] (driver_register+0x78/0x140) [<c02472d0>] > (driver_register+0x78/0x140) from [<c00087c8>] > (do_one_initcall+0xf8/0x144) [<c00087c8>] (do_one_initcall+0xf8/0x144) > from [<c05b29e8>] (kernel_init_freeable+0x13c/0x1d8) > [<c05b29e8>] (kernel_init_freeable+0x13c/0x1d8) from [<c041a108>] > (kernel_init+0xc/0x160) [<c041a108>] (kernel_init+0xc/0x160) from > [<c000e2f8>] (ret_from_fork+0x14/0x3c) ---[ end trace > 4e0ec028b0028e02 ]--- s5p-g2d 12800000.g2d: Failed to register video > device > s5p-g2d: probe of 12800000.g2d failed with error -22 > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Kamil Debski <k.debski@samsung.com> > --- > drivers/media/platform/s5p-g2d/g2d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/s5p-g2d/g2d.c > b/drivers/media/platform/s5p-g2d/g2d.c > index 553d87e..fd6289d 100644 > --- a/drivers/media/platform/s5p-g2d/g2d.c > +++ b/drivers/media/platform/s5p-g2d/g2d.c > @@ -784,6 +784,7 @@ static int g2d_probe(struct platform_device *pdev) > } > *vfd = g2d_videodev; > vfd->lock = &dev->mutex; > + vfd->v4l2_dev = &dev->v4l2_dev; > ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0); > if (ret) { > v4l2_err(&dev->v4l2_dev, "Failed to register video > device\n"); > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c index 553d87e..fd6289d 100644 --- a/drivers/media/platform/s5p-g2d/g2d.c +++ b/drivers/media/platform/s5p-g2d/g2d.c @@ -784,6 +784,7 @@ static int g2d_probe(struct platform_device *pdev) } *vfd = g2d_videodev; vfd->lock = &dev->mutex; + vfd->v4l2_dev = &dev->v4l2_dev; ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0); if (ret) { v4l2_err(&dev->v4l2_dev, "Failed to register video device\n");