diff mbox

[1/2,media] anysee: Initialize ret = 0 in anysee_frontend_attach()

Message ID 1366803406-17738-1-git-send-email-geert@linux-m68k.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Geert Uytterhoeven April 24, 2013, 11:36 a.m. UTC 
  drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function

And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/media/usb/dvb-usb-v2/anysee.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Antti Palosaari April 25, 2013, 3:57 p.m. UTC | #1 
On 04/24/2013 02:36 PM, Geert Uytterhoeven wrote:
> drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
> drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function
>
> And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>


> ---
>   drivers/media/usb/dvb-usb-v2/anysee.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
> index a20d691..3a1f976 100644
> --- a/drivers/media/usb/dvb-usb-v2/anysee.c
> +++ b/drivers/media/usb/dvb-usb-v2/anysee.c
> @@ -638,7 +638,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
>   {
>   	struct anysee_state *state = adap_to_priv(adap);
>   	struct dvb_usb_device *d = adap_to_d(adap);
> -	int ret;
> +	int ret = 0;
>   	u8 tmp;
>   	struct i2c_msg msg[2] = {
>   		{
>
diff mbox

Patch

diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
index a20d691..3a1f976 100644
--- a/drivers/media/usb/dvb-usb-v2/anysee.c
+++ b/drivers/media/usb/dvb-usb-v2/anysee.c
@@ -638,7 +638,7 @@  static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
 {
 	struct anysee_state *state = adap_to_priv(adap);
 	struct dvb_usb_device *d = adap_to_d(adap);
-	int ret;
+	int ret = 0;
 	u8 tmp;
 	struct i2c_msg msg[2] = {
 		{