Message ID | 1363171939-9672-1-git-send-email-vikas.sajjan@linaro.org (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1UFjIa-0001DJ-06; Wed, 13 Mar 2013 11:52:44 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp id 1UFjIY-00032Q-Im; Wed, 13 Mar 2013 11:52:43 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754180Ab3CMKwc (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 13 Mar 2013 06:52:32 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:52292 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754027Ab3CMKwc (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 13 Mar 2013 06:52:32 -0400 Received: by mail-pb0-f48.google.com with SMTP id wy12so889352pbc.21 for <linux-media@vger.kernel.org>; Wed, 13 Mar 2013 03:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=+BuQldjNfwY0H3StNR5zpathMNmjtbXwbcsBeiULjH8=; b=NxFgmuC4mHf0sXsCO+mGVRGdiLlzemgm8nG7fHGCZshjS4bP+Z4i98/8p+hXC8RdjZ jy37/QtAKsmGCYZ5aI0/kSPYsHTeWAwf35cNNPWt9G+FpP2SaPCa/l8A8yrtNlWwg3jq VOWT1xUPcXFYcwTjokkTNz4MrlyxoTHpXyyHl/bE9v6nTX95nos+hhofp7HmmnuQ5RvP suDJ03exrMo5rDuNnxbuR/Esm9xLVMwQeomnPXSuHUYc6+ywOzahwp1IuaEejKnfwhlW LZmY3YvjgH9cI72rBXdSjzs3VIu7/1OzlRDKr1HhtC0mtZ2X4m1Vi9MMF+np+d41UE2T jbSA== X-Received: by 10.68.135.38 with SMTP id pp6mr45188268pbb.111.1363171951249; Wed, 13 Mar 2013 03:52:31 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id y13sm25319396pbv.0.2013.03.13.03.52.26 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 13 Mar 2013 03:52:30 -0700 (PDT) From: Vikas Sajjan <vikas.sajjan@linaro.org> To: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org, kgene.kim@samsung.com, joshi@samsung.com, inki.dae@samsung.com, linaro-kernel@lists.linaro.org, jy0922.shim@samsung.com Subject: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD Date: Wed, 13 Mar 2013 16:22:19 +0530 Message-Id: <1363171939-9672-1-git-send-email-vikas.sajjan@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQnYqsEV2wOSoyZq6iY0//421eHoGbzecrQv1xYt+MoVDuso5o9h2ujUVtyN2SZuXupk+v0s Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.13.104216 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Vikas Sajjan
March 13, 2013, 10:52 a.m. UTC
Replaces the "platform_get_resource() for IORESOURCE_IRQ" with
platform_get_resource_byname().
Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order: "fifo",
"vsync", and "lcd_sys".
But The FIMD driver expects the "vsync" interrupt to be mentioned as the
1st parameter in the FIMD DT node. So to meet this expectation of the
driver, the FIMD DT node was forced to be made by keeping "vsync" as the
1st paramter.
For example in exynos4, the FIMD DT node has interrupt numbers
mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter.
This patch fixes the above mentioned "hack" of re-ordering of the
FIMD interrupt numbers by getting interrupt resource of FIMD by using
platform_get_resource_byname().
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Mr. Inki Dae, Can you please review this patch.? On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote: > Replaces the "platform_get_resource() for IORESOURCE_IRQ" with > platform_get_resource_byname(). > Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order: "fifo", > "vsync", and "lcd_sys". > But The FIMD driver expects the "vsync" interrupt to be mentioned as the > 1st parameter in the FIMD DT node. So to meet this expectation of the > driver, the FIMD DT node was forced to be made by keeping "vsync" as the > 1st paramter. > For example in exynos4, the FIMD DT node has interrupt numbers > mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter. > > This patch fixes the above mentioned "hack" of re-ordering of the > FIMD interrupt numbers by getting interrupt resource of FIMD by using > platform_get_resource_byname(). > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 1ea173a..cd79d38 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev) > return -ENXIO; > } > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); > if (!res) { > dev_err(dev, "irq request failed.\n"); > return -ENXIO; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 1ea173a..cd79d38 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev) return -ENXIO; } - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); if (!res) { dev_err(dev, "irq request failed.\n"); return -ENXIO;