Message ID | 1363807490-3906-10-git-send-email-fschaefer.oss@googlemail.com (mailing list archive) |
---|---|
State | RFC, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1UIOcd-0004mI-EP; Wed, 20 Mar 2013 20:24:27 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1UIOcc-0001BB-CL; Wed, 20 Mar 2013 20:24:27 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757911Ab3CTTYW (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 20 Mar 2013 15:24:22 -0400 Received: from mail-ee0-f42.google.com ([74.125.83.42]:63527 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932983Ab3CTTYU (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 20 Mar 2013 15:24:20 -0400 Received: by mail-ee0-f42.google.com with SMTP id b47so1307549eek.1 for <linux-media@vger.kernel.org>; Wed, 20 Mar 2013 12:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=h9YLkkZOg6DjZdbfIIYnZN+PDqQsRhf1Ec8VnpbOA48=; b=FI29WOiPDel4MLfsiInlBUtqoYH0FBapKY/LoIA7Sj2tJ3bD2PAZBTPg3ov2bU7Jke taMxPFRHYCVPINNUvhuSfv6dg4v3GlTX1h9hZJqIBwRUfPepNy05YbvQtUkLVaqLL0nY 0gyBd4Gczv6ltYGTC5t0lz7ZRhPbL5hZmxPyS8MUumRE5RXBNPHRr5pkbIBD1EigLHRW hWJs9qoaehFKP7Qhyvb+LtZMx0k5q7RDagM4c3KcUGSr3SkqS2GJ32emhVdUnivFhasL PKUCMEwOL/7spEbdPuoLD9hJlhE6F5/QdKwQu7nHH61hCB1/MLDfABzPHVDTJstOl3yV qa0Q== X-Received: by 10.14.202.71 with SMTP id c47mr74127591eeo.39.1363807459577; Wed, 20 Mar 2013 12:24:19 -0700 (PDT) Received: from Athlon64X2-5000.site (ip-109-91-213-156.unitymediagroup.de. [109.91.213.156]) by mx.google.com with ESMTPS id z45sm4408888eeu.10.2013.03.20.12.24.18 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Mar 2013 12:24:18 -0700 (PDT) From: =?UTF-8?q?Frank=20Sch=C3=A4fer?= <fschaefer.oss@googlemail.com> To: mchehab@redhat.com Cc: hverkuil@xs4all.nl, linux-media@vger.kernel.org, =?UTF-8?q?Frank=20Sch=C3=A4fer?= <fschaefer.oss@googlemail.com> Subject: [RFC PATCH 09/10] bttv: fix mute on last close of the video device node Date: Wed, 20 Mar 2013 20:24:49 +0100 Message-Id: <1363807490-3906-10-git-send-email-fschaefer.oss@googlemail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1363807490-3906-1-git-send-email-fschaefer.oss@googlemail.com> References: <1363807490-3906-1-git-send-email-fschaefer.oss@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.20.191215 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Frank Schaefer
March 20, 2013, 7:24 p.m. UTC
Instead of applying the current mute setting on last device node close, always
mute the device.
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
---
drivers/media/pci/bt8xx/bttv-driver.c | 2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
Comments
On Wed 20 March 2013 20:24:49 Frank Schäfer wrote: > Instead of applying the current mute setting on last device node close, always > mute the device. I am very pleased with the preceding 8 patches. That does exactly what I had in mind. For this patch and the next (I would have combined those two into one patch BTW) I want to do some testing first. Unfortunately due to travel I will not have access to bttv hardware for the next 10 days or so. One thing I am considering is adding some basic tuner-ownership functionality to the v4l2 core. Without that I don't think we can ever get this working as it should. It might be an idea to make a pull request for the first 8 patches some time next week. That's all good stuff and it makes the code much easier to understand. Regards, Hans > Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com> > --- > drivers/media/pci/bt8xx/bttv-driver.c | 2 +- > 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c > index 2fb2168..469ea06 100644 > --- a/drivers/media/pci/bt8xx/bttv-driver.c > +++ b/drivers/media/pci/bt8xx/bttv-driver.c > @@ -3126,7 +3126,7 @@ static int bttv_release(struct file *file) > bttv_field_count(btv); > > if (!btv->users) > - audio_mute(btv, btv->mute); > + audio_mute(btv, 1); > > v4l2_fh_del(&fh->fh); > v4l2_fh_exit(&fh->fh); > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 21.03.2013 11:56, schrieb Hans Verkuil: > On Wed 20 March 2013 20:24:49 Frank Schäfer wrote: >> Instead of applying the current mute setting on last device node close, always >> mute the device. > I am very pleased with the preceding 8 patches. That does exactly what I had > in mind. For this patch and the next (I would have combined those two into one > patch BTW) I want to do some testing first. Unfortunately due to travel I will > not have access to bttv hardware for the next 10 days or so. No problem, I don't think this is high priority stuff. ;) > One thing I am considering is adding some basic tuner-ownership functionality > to the v4l2 core. Without that I don't think we can ever get this working as > it should. Sounds good ! > It might be an idea to make a pull request for the first 8 patches some time > next week. That's all good stuff and it makes the code much easier to > understand. Ok, I will resend the first 8 patches witch you ACK added and RFC removed. Please drop me a message when you have tested the last two patches and want me to take further actions. Thanks for reviewing ! Regards, Frank > Regards, > > Hans > >> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com> >> --- >> drivers/media/pci/bt8xx/bttv-driver.c | 2 +- >> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) >> >> diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c >> index 2fb2168..469ea06 100644 >> --- a/drivers/media/pci/bt8xx/bttv-driver.c >> +++ b/drivers/media/pci/bt8xx/bttv-driver.c >> @@ -3126,7 +3126,7 @@ static int bttv_release(struct file *file) >> bttv_field_count(btv); >> >> if (!btv->users) >> - audio_mute(btv, btv->mute); >> + audio_mute(btv, 1); >> >> v4l2_fh_del(&fh->fh); >> v4l2_fh_exit(&fh->fh); >> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 2fb2168..469ea06 100644 --- a/drivers/media/pci/bt8xx/bttv-driver.c +++ b/drivers/media/pci/bt8xx/bttv-driver.c @@ -3126,7 +3126,7 @@ static int bttv_release(struct file *file) bttv_field_count(btv); if (!btv->users) - audio_mute(btv, btv->mute); + audio_mute(btv, 1); v4l2_fh_del(&fh->fh); v4l2_fh_exit(&fh->fh);