Message ID | 1363687193-30893-1-git-send-email-vikas.sajjan@linaro.org (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1UHtLE-00076f-Lr; Tue, 19 Mar 2013 11:00:24 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp id 1UHtLD-0001s4-Fi; Tue, 19 Mar 2013 11:00:24 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346Ab3CSKAV (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 19 Mar 2013 06:00:21 -0400 Received: from mail-da0-f50.google.com ([209.85.210.50]:35241 "EHLO mail-da0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758Ab3CSKAU (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 19 Mar 2013 06:00:20 -0400 Received: by mail-da0-f50.google.com with SMTP id t1so216963dae.9 for <linux-media@vger.kernel.org>; Tue, 19 Mar 2013 03:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=v4y0MtyEM+mHcNj5/tCVZF84h1HuJYrm5tjMB6r5k8I=; b=SNVOwJpxneXac7206bApcBotkuMTOXBFGnCFe5s6W23KMUT+A3eKD3F5fdKCLjxjgD H13Y+EMjXXgGAyPu4KsYPmyjUbFMP/TIEADj4UKJiJSAPpLoE+fTQLiAdDLLNyD7SSv4 3Rn6oSyrjvAYBaq6TKUp6a6WlrUb3Rkuyr7W9xuENym+jNOeypLPQsH8KUh6sQr9HFH9 NndgvJt1AI81/Znfp9GeiPyzDGKFt9b+zfSywPNrdrBSuMTmaJ5Z5YGFsbJh5wp2XxMh 3QQLb5GenBGdNRy/pBMi4e79P1hKKIevvwLsGCmKc3vBiHO8Y6vpkNPAfh4p8zI62gsF xknA== X-Received: by 10.68.239.194 with SMTP id vu2mr2030514pbc.147.1363687220210; Tue, 19 Mar 2013 03:00:20 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id i10sm23719663pbd.1.2013.03.19.03.00.15 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 19 Mar 2013 03:00:19 -0700 (PDT) From: Vikas Sajjan <vikas.sajjan@linaro.org> To: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org, kgene.kim@samsung.com, joshi@samsung.com, inki.dae@samsung.com, linaro-kernel@lists.linaro.org, jy0922.shim@samsung.com, linux-samsung-soc@vger.kernel.org, thomas.abraham@linaro.org Subject: [PATCH] drm/exynos: enable FIMD clocks Date: Tue, 19 Mar 2013 15:29:53 +0530 Message-Id: <1363687193-30893-1-git-send-email-vikas.sajjan@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQmk0YZeQ/M0ayk8B077uaSx6miVAUocU897UIAntwltLjkgxWnmsOe9uaQdQDlZGzTV7ZP7 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.19.95114 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Vikas Sajjan
March 19, 2013, 9:59 a.m. UTC
While migrating to common clock framework (CCF), found that the FIMD clocks
were pulled down by the CCF.
If CCF finds any clock(s) which has NOT been claimed by any of the
drivers, then such clock(s) are PULLed low by CCF.
By calling clk_prepare_enable() for FIMD clocks fixes the issue.
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On 19 March 2013 15:29, Vikas Sajjan <vikas.sajjan@linaro.org> wrote: > While migrating to common clock framework (CCF), found that the FIMD clocks > were pulled down by the CCF. > If CCF finds any clock(s) which has NOT been claimed by any of the > drivers, then such clock(s) are PULLed low by CCF. > > By calling clk_prepare_enable() for FIMD clocks fixes the issue. > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 9537761..d93dd8a 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -934,6 +934,9 @@ static int fimd_probe(struct platform_device *pdev) > return ret; > } > > + clk_prepare_enable(ctx->lcd_clk); > + clk_prepare_enable(ctx->bus_clk); > + Ideally you should check return values here. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19 March 2013 15:29, Vikas Sajjan <vikas.sajjan@linaro.org> wrote: > While migrating to common clock framework (CCF), found that the FIMD clocks > were pulled down by the CCF. > If CCF finds any clock(s) which has NOT been claimed by any of the > drivers, then such clock(s) are PULLed low by CCF. > > By calling clk_prepare_enable() for FIMD clocks fixes the issue. > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 9537761..d93dd8a 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -934,6 +934,9 @@ static int fimd_probe(struct platform_device *pdev) > return ret; > } > > + clk_prepare_enable(ctx->lcd_clk); > + clk_prepare_enable(ctx->bus_clk); > + You also need to do clk_disable_unprepare during exit. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 9537761..d93dd8a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -934,6 +934,9 @@ static int fimd_probe(struct platform_device *pdev) return ret; } + clk_prepare_enable(ctx->lcd_clk); + clk_prepare_enable(ctx->bus_clk); + ctx->vidcon0 = pdata->vidcon0; ctx->vidcon1 = pdata->vidcon1; ctx->default_win = pdata->default_win;