| Message ID | 1362484334-18804-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1UCqa9-00072u-UA; Tue, 05 Mar 2013 13:02:57 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1UCqa9-00064K-AJ; Tue, 05 Mar 2013 13:02:57 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754737Ab3CEMCr (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 5 Mar 2013 07:02:47 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:37467 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752351Ab3CEMCq (ORCPT <rfc822; linux-media@vger.kernel.org>); Tue, 5 Mar 2013 07:02:46 -0500 Received: by mail-pb0-f52.google.com with SMTP id ma3so4342963pbc.25 for <linux-media@vger.kernel.org>; Tue, 05 Mar 2013 04:02:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=TA/P8lqbhReVE06wAx2F01YpKQ5Tn80EYvvlHvmjCyc=; b=PxJNbis+2T677fRdr9B1gWnPiAEcGkaFo/j/XIPfZCSs++jJiIDedpqecs9BpaS/d4 lPjhE/CXjqI/YTvbayVZKMF/kNkmSDW4+E0Fpw9xIgsygJP3uY5Hk3sINfijOZFdibAi GEgsuvFGw8U/ScV1wvfWtWRGAtSRiQFAmRxuqRJSiB9B+RT4SZIUlgB1QkMLOb7w8Zr+ PbLJiADRSfUZNslRd7dfyNAXCtr9TgMFqaoiP+k5qpOR4H0KnYFaOsPO4GB5M1T91dD6 +D5ZENrFdBxqCvkEVkSAkhRSP8ZVEE5sMHW7S5A9v5yT925N/YJ+OoFzCbTvqaqxkG8c H5Aw== X-Received: by 10.68.245.229 with SMTP id xr5mr36638528pbc.163.1362484965562; Tue, 05 Mar 2013 04:02:45 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id qd8sm9203918pbc.29.2013.03.05.04.02.42 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 05 Mar 2013 04:02:44 -0800 (PST) From: Sachin Kamat <sachin.kamat@linaro.org> To: linux-media@vger.kernel.org Cc: mchehab@redhat.com, prabhakar.lad@ti.com, sachin.kamat@linaro.org, manjunath.hadli@ti.com Subject: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro Date: Tue, 5 Mar 2013 17:22:14 +0530 Message-Id: <1362484334-18804-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQkZdxxqZzYKujs3yFYykIwauWidHx/awWyaOmqWCxUHvsOCkR5uVtlejSQwxOMGWha/3tkn Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.5.115128 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Sachin Kamat
March 5, 2013, 11:52 a.m. UTC
module_platform_driver() eliminates the boilerplate and simplifies
the code.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
.../staging/media/davinci_vpfe/vpfe_mc_capture.c | 20 +-------------------
1 files changed, 1 insertions(+), 19 deletions(-)
Comments
Hi Sachin, Thanks for the patch! On Tue, Mar 5, 2013 at 5:22 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > module_platform_driver() eliminates the boilerplate and simplifies > the code. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Acked-by: Lad, Prabhakar <prabhakar.lad@ti.com> Regards, --Prabhakar Lad > --- > .../staging/media/davinci_vpfe/vpfe_mc_capture.c | 20 +------------------- > 1 files changed, 1 insertions(+), 19 deletions(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c > index 7b35171..c7ae7d7 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c > @@ -719,22 +719,4 @@ static struct platform_driver vpfe_driver = { > .remove = vpfe_remove, > }; > > -/** > - * vpfe_init : This function registers device driver > - */ > -static __init int vpfe_init(void) > -{ > - /* Register driver to the kernel */ > - return platform_driver_register(&vpfe_driver); > -} > - > -/** > - * vpfe_cleanup : This function un-registers device driver > - */ > -static void vpfe_cleanup(void) > -{ > - platform_driver_unregister(&vpfe_driver); > -} > - > -module_init(vpfe_init); > -module_exit(vpfe_cleanup); > +module_platform_driver(vpfe_driver); > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5 March 2013 17:46, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > Hi Sachin, > > Thanks for the patch! > > On Tue, Mar 5, 2013 at 5:22 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> module_platform_driver() eliminates the boilerplate and simplifies >> the code. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Acked-by: Lad, Prabhakar <prabhakar.lad@ti.com> Thanks Prabhakar. BTW, who is supposed to pick this patch?
Hi Sachin, On Thu, Mar 7, 2013 at 12:46 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 5 March 2013 17:46, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: >> Hi Sachin, >> >> Thanks for the patch! >> >> On Tue, Mar 5, 2013 at 5:22 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>> module_platform_driver() eliminates the boilerplate and simplifies >>> the code. >>> >>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> >> Acked-by: Lad, Prabhakar <prabhakar.lad@ti.com> > > Thanks Prabhakar. > BTW, who is supposed to pick this patch? > I'll queue it for 3.10 and a issue a pull request to Mauro soon. Or if you have a branch and want to issue a pull no problem(anyways I have Acked it). what do you suggest ? Regards, --Prabhakar Lad > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Prabhakar, >> BTW, who is supposed to pick this patch? >> > I'll queue it for 3.10 and a issue a pull request to Mauro soon. > Or if you have a branch and want to issue a pull no problem(anyways > I have Acked it). what do you suggest ? Please queue it in your tree and go ahead with the pull request. That sounds reasonable.
Hi Sachin, On Thu, Mar 7, 2013 at 1:36 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Hi Prabhakar, > >>> BTW, who is supposed to pick this patch? >>> >> I'll queue it for 3.10 and a issue a pull request to Mauro soon. >> Or if you have a branch and want to issue a pull no problem(anyways >> I have Acked it). what do you suggest ? > > Please queue it in your tree and go ahead with the pull request. That > sounds reasonable. > Queued to my branch http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 Regards, --Prabhakar > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>> > Queued to my branch > http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 Thanks Prabhakar. BTW, Manjunath's mail ID (manjunath.hadli@ti.com) bounces. Probably you need to update the correct ID in the MAINTAINERS file?
Hi Sachin, On Mon, Mar 11, 2013 at 11:01 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>> >> Queued to my branch >> http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 > > Thanks Prabhakar. > > BTW, Manjunath's mail ID (manjunath.hadli@ti.com) bounces. Probably > you need to update the correct ID in the MAINTAINERS file? > Yeah Manjunath and me have stopped working with TI, but although I'll be maintaining Davinci media with my personal Id. I will soon post the patch updating the MAINTAINERS file. Regards, --Prabhakar Lad > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11 March 2013 11:06, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > Hi Sachin, > > On Mon, Mar 11, 2013 at 11:01 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>>> >>> Queued to my branch >>> http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git/shortlog/refs/heads/for_v3.10 >> >> Thanks Prabhakar. >> >> BTW, Manjunath's mail ID (manjunath.hadli@ti.com) bounces. Probably >> you need to update the correct ID in the MAINTAINERS file? >> > Yeah Manjunath and me have stopped working with TI, but although > I'll be maintaining Davinci media with my personal Id. I will soon post the > patch updating the MAINTAINERS file. Oh OK.
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c index 7b35171..c7ae7d7 100644 --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c @@ -719,22 +719,4 @@ static struct platform_driver vpfe_driver = { .remove = vpfe_remove, }; -/** - * vpfe_init : This function registers device driver - */ -static __init int vpfe_init(void) -{ - /* Register driver to the kernel */ - return platform_driver_register(&vpfe_driver); -} - -/** - * vpfe_cleanup : This function un-registers device driver - */ -static void vpfe_cleanup(void) -{ - platform_driver_unregister(&vpfe_driver); -} - -module_init(vpfe_init); -module_exit(vpfe_cleanup); +module_platform_driver(vpfe_driver);