Message ID | 1352588276-16260-1-git-send-email-sylvester.nawrocki@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1TXK0O-0008V8-3B for patchwork@linuxtv.org; Sat, 10 Nov 2012 23:58:24 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1TXK0M-0005eA-JE; Sat, 10 Nov 2012 23:58:23 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356Ab2KJW6M (ORCPT <rfc822;patchwork@linuxtv.org>); Sat, 10 Nov 2012 17:58:12 -0500 Received: from mail-wi0-f178.google.com ([209.85.212.178]:53577 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258Ab2KJW6M (ORCPT <rfc822;linux-media@vger.kernel.org>); Sat, 10 Nov 2012 17:58:12 -0500 Received: by mail-wi0-f178.google.com with SMTP id hr7so1464532wib.1 for <linux-media@vger.kernel.org>; Sat, 10 Nov 2012 14:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=IwPkUVGLE8zFxxxUfY8WEwCVyTHQgAlU9a0/114siYc=; b=lO71T+h53EhhYWojB2Xlx7hn6+wb73OOkq7zxMvJNSg1iqjH6viggmBZDtWDSeVTHV pCccgCFx7U9pFxmciIrV/whl2i2W9I6BLvMKzpb6w/4u0IFGqkPgOQ6eIlZ++uHctobA 1dbZN+ArPoNFv9+2iAXq5SMI62VHVVF3tspR8Bwreged51nJ5xl1W6yxW2UfsgapQ42C AFrpK+ttWjVHrwGZlEyf90dn1T1tGhrCmYjND6P0mj/5iaRZSL50C8TZKlJ/4ZRrD03R k1yMT2ifwNp245znwLqs8qWCvNWY0VLvwT82g7s6dGMF+U+8ztGOZqSE7L+l4kwewvIk LNYQ== Received: by 10.181.11.163 with SMTP id ej3mr8780423wid.11.1352588290996; Sat, 10 Nov 2012 14:58:10 -0800 (PST) Received: from localhost.localdomain (142.130.21.95.dynamic.jazztel.es. [95.21.130.142]) by mx.google.com with ESMTPS id v9sm8257170wif.10.2012.11.10.14.58.09 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 10 Nov 2012 14:58:10 -0800 (PST) From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> To: linux-media@vger.kernel.org Cc: sw0312.kim@samsung.com, Sylwester Nawrocki <sylvester.nawrocki@gmail.com>, Shaik Ameer Basha <shaik.ameer@samsung.com> Subject: [PATCH] exynos-gsc: Add missing video device vfl_dir flag initialization Date: Sat, 10 Nov 2012 23:57:56 +0100 Message-Id: <1352588276-16260-1-git-send-email-sylvester.nawrocki@gmail.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.10.224918 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Sylwester Nawrocki
Nov. 10, 2012, 10:57 p.m. UTC
vfl_dir should be set to VFL_DIR_M2M so valid ioctls for this
mem-to-mem device can be properly determined in the v4l2 core.
Cc: Shaik Ameer Basha <shaik.ameer@samsung.com>
Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
---
I didn't run-time test this patch.
drivers/media/platform/exynos-gsc/gsc-m2m.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Hi Shaik, Could you let us know if the driver is working fine with this patch applied ? I have no exynos5 based board to test it. And this patch qualifies as an important fix that should be applied for v3.7, where the driver's first appeared. Thanks, Sylwester On 11/10/2012 11:57 PM, Sylwester Nawrocki wrote: > vfl_dir should be set to VFL_DIR_M2M so valid ioctls for this > mem-to-mem device can be properly determined in the v4l2 core. > > Cc: Shaik Ameer Basha<shaik.ameer@samsung.com> > Signed-off-by: Sylwester Nawrocki<sylvester.nawrocki@gmail.com> > --- > I didn't run-time test this patch. > > drivers/media/platform/exynos-gsc/gsc-m2m.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c > index 3c7f005..88642a8 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c > +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c > @@ -732,6 +732,7 @@ int gsc_register_m2m_device(struct gsc_dev *gsc) > gsc->vdev.ioctl_ops =&gsc_m2m_ioctl_ops; > gsc->vdev.release = video_device_release_empty; > gsc->vdev.lock =&gsc->lock; > + gsc->vdev.vfl_dir = VFL_DIR_M2M; > snprintf(gsc->vdev.name, sizeof(gsc->vdev.name), "%s.%d:m2m", > GSC_MODULE_NAME, gsc->id); > > -- > 1.7.4.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester, I applied this patch and tested exynos-gsc driver basic features on exynos5250. It's working fine for me. Thanks, Shaik Ameer Basha On Tue, Nov 20, 2012 at 1:36 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > Hi Shaik, > > Could you let us know if the driver is working fine with this patch > applied ? I have no exynos5 based board to test it. And this patch > qualifies as an important fix that should be applied for v3.7, where > the driver's first appeared. > > Thanks, > Sylwester > > > On 11/10/2012 11:57 PM, Sylwester Nawrocki wrote: >> >> vfl_dir should be set to VFL_DIR_M2M so valid ioctls for this >> mem-to-mem device can be properly determined in the v4l2 core. >> >> Cc: Shaik Ameer Basha<shaik.ameer@samsung.com> >> Signed-off-by: Sylwester Nawrocki<sylvester.nawrocki@gmail.com> >> --- >> I didn't run-time test this patch. >> >> drivers/media/platform/exynos-gsc/gsc-m2m.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c >> b/drivers/media/platform/exynos-gsc/gsc-m2m.c >> index 3c7f005..88642a8 100644 >> --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c >> +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c >> @@ -732,6 +732,7 @@ int gsc_register_m2m_device(struct gsc_dev *gsc) >> gsc->vdev.ioctl_ops =&gsc_m2m_ioctl_ops; >> gsc->vdev.release = video_device_release_empty; >> gsc->vdev.lock =&gsc->lock; >> >> + gsc->vdev.vfl_dir = VFL_DIR_M2M; >> snprintf(gsc->vdev.name, sizeof(gsc->vdev.name), "%s.%d:m2m", >> GSC_MODULE_NAME, gsc->id); >> >> -- >> 1.7.4.1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c index 3c7f005..88642a8 100644 --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c @@ -732,6 +732,7 @@ int gsc_register_m2m_device(struct gsc_dev *gsc) gsc->vdev.ioctl_ops = &gsc_m2m_ioctl_ops; gsc->vdev.release = video_device_release_empty; gsc->vdev.lock = &gsc->lock; + gsc->vdev.vfl_dir = VFL_DIR_M2M; snprintf(gsc->vdev.name, sizeof(gsc->vdev.name), "%s.%d:m2m", GSC_MODULE_NAME, gsc->id);