| Message ID | 1352128271.16194.8.camel@joe-AO722 (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1TVOM2-0002dL-Cv for patchwork@linuxtv.org; Mon, 05 Nov 2012 16:12:46 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for <patchwork@linuxtv.org> id 1TVOM1-0004DX-FT; Mon, 05 Nov 2012 16:12:46 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932805Ab2KEPLT (ORCPT <rfc822;patchwork@linuxtv.org>); Mon, 5 Nov 2012 10:11:19 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:39723 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754378Ab2KEPLR (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 5 Nov 2012 10:11:17 -0500 Received: from [180.180.35.194] (account joe@perches.com HELO [192.168.1.5]) by labridge.com (CommuniGate Pro SMTP 5.0.14) with ESMTPA id 19808046; Mon, 05 Nov 2012 07:11:16 -0800 Message-ID: <1352128271.16194.8.camel@joe-AO722> Subject: Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c From: Joe Perches <joe@perches.com> To: Greg Kroah-Hartman <greg@kroah.com> Cc: YAMANE Toshiaki <yamanetoshi@gmail.com>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 05 Nov 2012 07:11:11 -0800 In-Reply-To: <20121105131108.GC27238@kroah.com> References: <1352115282-8081-1-git-send-email-yamanetoshi@gmail.com> <20121105131108.GC27238@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.5.150016 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, INVALID_MSGID_NO_FQDN 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Joe Perches
Nov. 5, 2012, 3:11 p.m. UTC
On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: > > fixed below checkpatch warnings. > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> > > --- > > drivers/staging/media/go7007/s2250-loader.c | 35 ++++++++++++++------------- > > 1 file changed, 18 insertions(+), 17 deletions(-) > > Please note that I don't touch the drivers/staging/media/* files, so > copying me on these patches doesn't do anything :) Maybe: MAINTAINERS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote: > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: > > > fixed below checkpatch warnings. > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > > > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> > > > --- > > > drivers/staging/media/go7007/s2250-loader.c | 35 ++++++++++++++------------- > > > 1 file changed, 18 insertions(+), 17 deletions(-) > > > > Please note that I don't touch the drivers/staging/media/* files, so > > copying me on these patches doesn't do anything :) > > Maybe: > > MAINTAINERS | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b062349..542a541 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6906,6 +6906,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > L: devel@driverdev.osuosl.org > S: Supported > F: drivers/staging/ > +X: drivers/staging/media/ Sure, that would be good, care to resend it with a signed-off-by: so I can apply it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote: > > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: > > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: > > > > fixed below checkpatch warnings. > > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > > > > > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> > > > > --- > > > > drivers/staging/media/go7007/s2250-loader.c | 35 ++++++++++++++------------- > > > > 1 file changed, 18 insertions(+), 17 deletions(-) > > > > > > Please note that I don't touch the drivers/staging/media/* files, so > > > copying me on these patches doesn't do anything :) > > > > Maybe: > > > > MAINTAINERS | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index b062349..542a541 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -6906,6 +6906,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > L: devel@driverdev.osuosl.org > > S: Supported > > F: drivers/staging/ > > +X: drivers/staging/media/ > > Sure, that would be good, care to resend it with a signed-off-by: so I > can apply it? It was just a nudge. You're the nominal staging maintainer, if you choose not to work on a specific directory under staging, I think you can mark it in MAINTAINERS just as easily yourself. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 6, 2012 at 12:25 AM, Joe Perches <joe@perches.com> wrote: > On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote: >> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote: >> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: >> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: >> > > > fixed below checkpatch warnings. >> > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... >> > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... >> > > > >> > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> >> > > > --- >> > > > drivers/staging/media/go7007/s2250-loader.c | 35 ++++++++++++++------------- >> > > > 1 file changed, 18 insertions(+), 17 deletions(-) >> > > >> > > Please note that I don't touch the drivers/staging/media/* files, so >> > > copying me on these patches doesn't do anything :) >> > >> > Maybe: >> > >> > MAINTAINERS | 1 + >> > 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index b062349..542a541 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -6906,6 +6906,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> > L: devel@driverdev.osuosl.org >> > S: Supported >> > F: drivers/staging/ >> > +X: drivers/staging/media/ >> >> Sure, that would be good, care to resend it with a signed-off-by: so I >> can apply it? > > It was just a nudge. > > You're the nominal staging maintainer, if you choose not to > work on a specific directory under staging, I think you can > mark it in MAINTAINERS just as easily yourself. Thanks for all. I wait Mauro-san will pick the patches. And I will send the patches to the correct destination from the next time.
Em Tue, 6 Nov 2012 09:14:39 +0900 Toshiaki Yamane <yamanetoshi@gmail.com> escreveu: > On Tue, Nov 6, 2012 at 12:25 AM, Joe Perches <joe@perches.com> wrote: > > On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote: > >> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote: > >> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: > >> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: > >> > > > fixed below checkpatch warnings. > >> > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > >> > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > >> > > > > >> > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> > >> > > > --- > >> > > > drivers/staging/media/go7007/s2250-loader.c | 35 ++++++++++++++------------- > >> > > > 1 file changed, 18 insertions(+), 17 deletions(-) > >> > > > >> > > Please note that I don't touch the drivers/staging/media/* files, so > >> > > copying me on these patches doesn't do anything :) > >> > > >> > Maybe: > >> > > >> > MAINTAINERS | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/MAINTAINERS b/MAINTAINERS > >> > index b062349..542a541 100644 > >> > --- a/MAINTAINERS > >> > +++ b/MAINTAINERS > >> > @@ -6906,6 +6906,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > >> > L: devel@driverdev.osuosl.org > >> > S: Supported > >> > F: drivers/staging/ > >> > +X: drivers/staging/media/ > >> > >> Sure, that would be good, care to resend it with a signed-off-by: so I > >> can apply it? > > > > It was just a nudge. > > > > You're the nominal staging maintainer, if you choose not to > > work on a specific directory under staging, I think you can > > mark it in MAINTAINERS just as easily yourself. > > Thanks for all. > > I wait Mauro-san will pick the patches. > And I will send the patches to the correct destination from the next time. I'm handling them today. Sorry for being a little late on it. Too much stuff at the end of this year to handle. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/MAINTAINERS b/MAINTAINERS index b062349..542a541 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6906,6 +6906,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git L: devel@driverdev.osuosl.org S: Supported F: drivers/staging/ +X: drivers/staging/media/ STAGING - AGERE HERMES II and II.5 WIRELESS DRIVERS M: Henk de Groot <pe1dnn@amsat.org>