Message ID | 50896C07.3060200@flensrocker.de |
---|---|
State | New |
Headers |
Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <vdr-bounces@linuxtv.org>) id 1TRQdF-00043P-60; Thu, 25 Oct 2012 18:50:09 +0200 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <dvb@flensrocker.de>) id 1TRQck-00042y-4S for vdr@linuxtv.org; Thu, 25 Oct 2012 18:50:06 +0200 X-tubIT-Incoming-IP: 62.214.96.172 Received: from mxweb01do.versatel-west.de ([62.214.96.172]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with smtp for <vdr@linuxtv.org> id 1TRQcj-0001Ve-IS; Thu, 25 Oct 2012 18:49:37 +0200 Received: (qmail 1178 invoked from network); 25 Oct 2012 16:42:56 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on spamkill15do.versatel-west.de X-Spam-Status: No, score=0.0 Received: from mxwebdo.versatel.de (62.214.96.205) by mxweb01do.versatel-west.de with SMTP; 25 Oct 2012 16:42:51 -0000 Received: from ens28fl.versatel.de [82.140.32.10] (helo=ens28fl.versatel.de) by mxwebdo.versatel.de (62.214.96.205) with id q9PGgpuV024600; Thu, 25 Oct 2012 18:42:51 +0200 Received: from cinnamon-sage.de (i577A35A5.versanet.de [87.122.53.165]) (dvb@flensrocker.de authenticated bits=0) by ens28fl.versatel.de (8.12.11.20060308/8.12.11) with SMTP id q9PGgkiS023635 for <vdr@linuxtv.org>; Thu, 25 Oct 2012 18:42:46 +0200 Received: from 192.168.23.2:50380 by cinnamon-sage.de for <vdr@linuxtv.org> ; 25.10.2012 18:42:46 Message-ID: <50896C07.3060200@flensrocker.de> Date: Thu, 25 Oct 2012 18:42:47 +0200 From: Lars Hanisch <dvb@flensrocker.de> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: vdr@linuxtv.org References: <CADJunO7m9cBRJrhh8xbFmZdV8mDq1J9gutPO6=NCEXtimRP40Q@mail.gmail.com> In-Reply-To: <CADJunO7m9cBRJrhh8xbFmZdV8mDq1J9gutPO6=NCEXtimRP40Q@mail.gmail.com> X-Virus-Scanned: ClamAV version 0.92, clamav-milter version 0.92 on 82.140.32.176 X-Virus-Status: Clean X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.10.25.163917 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1700_1799 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, ECARD_WORD 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -1.1 (-) X-LSpam-Report: No, score=-1.1 required=5.0 tests=BAYES_00=-1.9, RDNS_NONE=0.793 autolearn=no Subject: Re: [vdr] [ANNOUNCE] vdr-rotorng-0.3 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org |
Commit Message
L. Hanisch
Oct. 25, 2012, 4:42 p.m. UTC
Hi, Am 25.10.2012 17:23, schrieb Morfsta: > The third version of my plugin rotorng has been released here: - > > http://projects.vdr-developer.org/projects/plg-rotor-ng/files > > This plugin allows you to steer a disecq 1.1 rotor, find satellites > with a signal meter and to store them at given positions. It also has > a rudimentary channel scanner which works with both DVB-S and S2. Much > of this code has been merged together from the existing actuator and > rotor plugins, so thanks to the developers of those for their work. > > Please see the README file, there are a number of functions within the > user interface that aren't fully implemented or working but the main > functions are there. > > Changes since previous version: - > > 2012-10-11: Version 0.2 > > - updated sat card store value in config, always resetting > - fixed issue with change implemented in 1.7.23 (thanks to Ihanisch) > > 2012-10-21: Version 0.3 > > - Added patch for vdr-1.7.27 onwards, old patch for VDR still exists also. > - Fixed problem with cStatusMonitor::ChannelSwitch call introduced in > VDR 1.7.26 so dish moves on channel change You've forgotten the wrap the definition of ChannelSwitch into #if's: Regards, Lars. > > Good luck! > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
Comments
On Thu, Oct 25, 2012 at 5:42 PM, Lars Hanisch <dvb@flensrocker.de> wrote: > You've forgotten the wrap the definition of ChannelSwitch into #if's: > > --- a/rotorng.c > +++ b/rotorng.c > @@ -333,7 +333,11 @@ > int last_position_shown; > bool transfer; > protected: > +#if VDRVERSNUM >= 10726 > virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber, bool LiveView); > +#else > + virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber); > +#endif > public: > cStatusMonitor(); > }; > Are you sure? Its definitely in my copy and seems to be in the one on the projects site. Thanks
Hi, Am 25.10.2012 19:44, schrieb Morfsta: > On Thu, Oct 25, 2012 at 5:42 PM, Lars Hanisch <dvb@flensrocker.de> wrote: >> You've forgotten the wrap the definition of ChannelSwitch into #if's: >> >> --- a/rotorng.c >> +++ b/rotorng.c >> @@ -333,7 +333,11 @@ >> int last_position_shown; >> bool transfer; >> protected: >> +#if VDRVERSNUM >= 10726 >> virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber, bool LiveView); >> +#else >> + virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber); >> +#endif >> public: >> cStatusMonitor(); >> }; >> > > Are you sure? Its definitely in my copy and seems to be in the one on > the projects site. There are two places: one in the class definition and one a few lines below that. Just search for "ChannelSwitch"... :) Line 336 and line 347. Regards, Lars. > > Thanks > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
On Fri, Oct 26, 2012 at 7:59 AM, Lars Hanisch <dvb@flensrocker.de> wrote: >> There are two places: one in the class definition and one a few lines below that. Just search for "ChannelSwitch"... :) > Line 336 and line 347. Oops. Thanks for the help, I'll update and release a fixed version. Thanks
Okay, updated version (0.3.1) has been uploaded to the VDR Projects site. I have also fixed all the compilation warnings (at last)! Thanks
Hi, Am 26.10.2012 14:12, schrieb Morfsta: > Okay, updated version (0.3.1) has been uploaded to the VDR Projects site. > > I have also fixed all the compilation warnings (at last)! rotorng.c, line 204: if (ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr])) { dsyslog("Failed to send diseqc command!\n"); return; } I think, it should be (missed a !) if (!ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr])) { dsyslog("Failed to send diseqc command!\n"); return; } Tomorrow I will do some more review, so be patient with a new release... :) This one isn't bad, just a failure debug message when there's no error. Lars. > > Thanks > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
Hey Morfsta, Vdr 2.0.0 is coming, it's time to update your plugin. BTW, take a look into this issue http://projects.vdr-developer.org/issues/740 . The same error I discovered when compiled against vdr-1.7.38. Regards, Yarema 2012/10/27 Lars Hanisch <dvb@flensrocker.de> > Hi, > > Am 26.10.2012 14:12, schrieb Morfsta: > > Okay, updated version (0.3.1) has been uploaded to the VDR Projects site. > > > > I have also fixed all the compilation warnings (at last)! > > rotorng.c, line 204: > if (ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr])) > { > dsyslog("Failed to send diseqc command!\n"); > return; > } > > I think, it should be (missed a !) > if (!ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr])) > { > dsyslog("Failed to send diseqc command!\n"); > return; > } > > Tomorrow I will do some more review, so be patient with a new release... > :) > This one isn't bad, just a failure debug message when there's no error. > > Lars. > > > > > Thanks > > > > _______________________________________________ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >
On Tue, Feb 19, 2013 at 5:03 PM, YUP <yupadmin@gmail.com> wrote: > Hey Morfsta, > Vdr 2.0.0 is coming, it's time to update your plugin. BTW, take a look into > this issue http://projects.vdr-developer.org/issues/740 . The same error I > discovered when compiled against vdr-1.7.38. > Regards, > Yarema That issue was fixed in version 0.3.1. Are there any further changes that are required for VDR 2.0.0? Regards, Morfsta
> That issue was fixed in version 0.3.1. Are there any further changes > that are required for VDR 2.0.0? rotorng-0.3.1 - still relies on the old Makefile this is easy to fix, copy the Makefile from dvbhddevice adapt the line PLUGIN and OBJS, thats all no backwards crap, no worrys :) depend the plugin to >=vdr-1.7.38 in README - remove the leftover DIR /locale (from earlyer local compile?)
--- a/rotorng.c +++ b/rotorng.c @@ -333,7 +333,11 @@ int last_position_shown; bool transfer; protected: +#if VDRVERSNUM >= 10726 virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber, bool LiveView); +#else + virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber); +#endif public: cStatusMonitor(); };