Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback
Message ID | 50707704.5030402@gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1TKZ1q-0008EU-4m for patchwork@linuxtv.org; Sat, 06 Oct 2012 20:23:10 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1TKZ1p-0001C5-Hj; Sat, 06 Oct 2012 20:23:10 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165Ab2JFSXG (ORCPT <rfc822;patchwork@linuxtv.org>); Sat, 6 Oct 2012 14:23:06 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:46867 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924Ab2JFSXF (ORCPT <rfc822; linux-media@vger.kernel.org>); Sat, 6 Oct 2012 14:23:05 -0400 Received: by mail-ee0-f46.google.com with SMTP id b15so2032750eek.19 for <linux-media@vger.kernel.org>; Sat, 06 Oct 2012 11:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=+Qgyd+mDxMOphccgMJ24mSdwFbn0t9F9Mcc0pxH6qqg=; b=AGZd/KdjNfNnAZZbbPS4JKBwmFkbpe9eCSntD3dnwysovbmDDdgemWOgT/F1KBRGum R66SrPXsI6n/Zc2CtddzMO+vxA0+IAHRzIfUrO2vBe/mLYxPHFTfdrfRe4HsIzXp/f96 8N/QBHW6hBmg+doEN4zy/1rQZQZUYl+3mrVcNUILY0YaAi56jwC4uKotSZQ6bNpmMc3X MtqX69CNYXE966QlOcJCqTlWtQLrGt4r7DHAWUE7Z6kNH7+zMDXAO697mKzI/w1IBeYa WCJj3l64rGJiyl9IwzFZZnNTXVzi3kse/rxv4NfFSeufuGzeezYb+Xll2QOPH9zeE0kP Fjxw== Received: by 10.14.225.73 with SMTP id y49mr1376687eep.25.1349547783607; Sat, 06 Oct 2012 11:23:03 -0700 (PDT) Received: from [192.168.1.110] (031011252076.warszawa.vectranet.pl. [31.11.252.76]) by mx.google.com with ESMTPS id i1sm23385164eeo.8.2012.10.06.11.23.01 (version=SSLv3 cipher=OTHER); Sat, 06 Oct 2012 11:23:02 -0700 (PDT) Message-ID: <50707704.5030402@gmail.com> Date: Sat, 06 Oct 2012 20:23:00 +0200 From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jan Hoogenraad <jan-conceptronic@hoogenraad.net> CC: Sylwester Nawrocki <s.nawrocki@samsung.com>, linux-media@vger.kernel.org, a.hajda@samsung.com, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, kyungmin.park@samsung.com, sw0312.kim@samsung.com Subject: Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback References: <1348674853-24596-1-git-send-email-s.nawrocki@samsung.com> <1348674853-24596-6-git-send-email-s.nawrocki@samsung.com> <50704D26.9020201@hoogenraad.net> In-Reply-To: <50704D26.9020201@hoogenraad.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.10.6.181222 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __FW_1LN_BOT_MSGID 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Commit Message
Sylwester Nawrocki
Oct. 6, 2012, 6:23 p.m. UTC
Hello Jan, On 10/06/2012 05:24 PM, Jan Hoogenraad wrote: > On my ubuntu 10.4 system > > Linux 2.6.32-43-generic-pae #97-Ubuntu SMP Wed Sep 5 16:59:17 UTC 2012 > i686 GNU/Linux > > this patch breaks compilation of media_build. > The constant SZ_1M is not defined in the includes on my system > > Do you know what can be done about this ? > > --- > > /home/jhh/dvb/media_build/v4l/m5mols_core.c: In function > 'm5mols_set_frame_desc': > /home/jhh/dvb/media_build/v4l/m5mols_core.c:636: error: 'SZ_1M' > undeclared (first use in this function) > /home/jhh/dvb/media_build/v4l/m5mols_core.c:636: error: (Each undeclared > identifier is reported only once > /home/jhh/dvb/media_build/v4l/m5mols_core.c:636: error: for each > function it appears in.) Thanks for reporting this issue. You most likely don't need the M-5MOLS camera sensor driver on you system so one option is to just disable it at kernel config. Make sure CONFIG_VIDEO_M5MOLS is not set, it can be unselected at menuconfig -> Device Drivers -> Multimedia -> Encoders, decoders, sensors and other helper chips < > Fujitsu M-5MOLS 8MP sensor support The below patch which is intended to fix this issue won't work for media drivers backport builds on kernels older than 3.6, so m5mols driver should not be built for kernel versions < 3.6. 8<------------------------------------------------------------------- From 3e138ea603c9e5102452554cb14e4b404ce306e0 Mon Sep 17 00:00:00 2001 From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> Date: Sat, 6 Oct 2012 20:04:40 +0200 Subject: [PATCH] m5mols: Add missing #include <linux/sizes.h> Include <linux/sizes.h> header that is missing after commit ab7ef22419927 "[media] m5mols: Implement .get_frame_desc subdev callback". It prevents possible build errors due to undefined SZ_1M. Reported-by: Jan Hoogenraad <jan-conceptronic@hoogenraad.net> Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> --- drivers/media/i2c/m5mols/m5mols.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Comments
Thanks. I see several drivers disabled for lower kernel versions in my Kconfig file. I am not sure how this is accomplished, but it would be helpful if the Fujitsu M-5MOLS 8MP sensor support is automatically disabled for kernel < 3.6 I fixed it in my version by replacing SZ_1M by (1024*1024). I did not need the driver, but at least it compiled ... Sylwester Nawrocki wrote: > Hello Jan, > > On 10/06/2012 05:24 PM, Jan Hoogenraad wrote: >> On my ubuntu 10.4 system >> >> Linux 2.6.32-43-generic-pae #97-Ubuntu SMP Wed Sep 5 16:59:17 UTC 2012 >> i686 GNU/Linux >> >> this patch breaks compilation of media_build. >> The constant SZ_1M is not defined in the includes on my system >> >> Do you know what can be done about this ? >> >> --- >> >> /home/jhh/dvb/media_build/v4l/m5mols_core.c: In function >> 'm5mols_set_frame_desc': >> /home/jhh/dvb/media_build/v4l/m5mols_core.c:636: error: 'SZ_1M' >> undeclared (first use in this function) >> /home/jhh/dvb/media_build/v4l/m5mols_core.c:636: error: (Each undeclared >> identifier is reported only once >> /home/jhh/dvb/media_build/v4l/m5mols_core.c:636: error: for each >> function it appears in.) > > Thanks for reporting this issue. You most likely don't need the M-5MOLS > camera sensor driver on you system so one option is to just disable it > at kernel config. Make sure CONFIG_VIDEO_M5MOLS is not set, it can be > unselected at menuconfig > > -> Device Drivers > -> Multimedia > -> Encoders, decoders, sensors and other helper chips > < > Fujitsu M-5MOLS 8MP sensor support > > The below patch which is intended to fix this issue won't work for > media drivers backport builds on kernels older than 3.6, so m5mols > driver should not be built for kernel versions < 3.6. > > 8<------------------------------------------------------------------- >>From 3e138ea603c9e5102452554cb14e4b404ce306e0 Mon Sep 17 00:00:00 2001 > From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> > Date: Sat, 6 Oct 2012 20:04:40 +0200 > Subject: [PATCH] m5mols: Add missing #include <linux/sizes.h> > > Include <linux/sizes.h> header that is missing after commit ab7ef22419927 > "[media] m5mols: Implement .get_frame_desc subdev callback". > It prevents possible build errors due to undefined SZ_1M. > > Reported-by: Jan Hoogenraad <jan-conceptronic@hoogenraad.net> > Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> > --- > drivers/media/i2c/m5mols/m5mols.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/i2c/m5mols/m5mols.h b/drivers/media/i2c/m5mols/m5mols.h > index 4ab8b37..90a6c52 100644 > --- a/drivers/media/i2c/m5mols/m5mols.h > +++ b/drivers/media/i2c/m5mols/m5mols.h > @@ -16,6 +16,7 @@ > #ifndef M5MOLS_H > #define M5MOLS_H > > +#include <linux/sizes.h> > #include <media/v4l2-subdev.h> > #include "m5mols_reg.h" > >
On 10/06/2012 08:43 PM, Jan Hoogenraad wrote: > Thanks. > > I see several drivers disabled for lower kernel versions in my Kconfig file. > I am not sure how this is accomplished, but it would be helpful if the > Fujitsu M-5MOLS 8MP sensor support > is automatically disabled for kernel< 3.6 > > I fixed it in my version by replacing SZ_1M by (1024*1024). > I did not need the driver, but at least it compiled ... A patch for v4l/versions.txt is needed [1]. I'll see if I can prepare that. http://git.linuxtv.org/media_build.git/history/5d00dba6aaf0f91a742d90fd1e12e0fb2d36253e:/v4l/versions.txt -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/m5mols/m5mols.h b/drivers/media/i2c/m5mols/m5mols.h index 4ab8b37..90a6c52 100644 --- a/drivers/media/i2c/m5mols/m5mols.h +++ b/drivers/media/i2c/m5mols/m5mols.h @@ -16,6 +16,7 @@ #ifndef M5MOLS_H #define M5MOLS_H +#include <linux/sizes.h> #include <media/v4l2-subdev.h> #include "m5mols_reg.h"