Message ID | 1347860103-4141-27-git-send-email-shawn.guo@linaro.org (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1TDU0v-0007st-Sc for patchwork@linuxtv.org; Mon, 17 Sep 2012 07:36:57 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1TDU0v-00048p-Gg; Mon, 17 Sep 2012 07:36:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275Ab2IQFgz (ORCPT <rfc822;patchwork@linuxtv.org>); Mon, 17 Sep 2012 01:36:55 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:64439 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752266Ab2IQFgy (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 17 Sep 2012 01:36:54 -0400 Received: by pbbrr13 with SMTP id rr13so8486026pbb.19 for <linux-media@vger.kernel.org>; Sun, 16 Sep 2012 22:36:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=UKCKwiBEO5LJMttn0OhBWOLZIpRL6Y6iTrw0JPWkemc=; b=i0x34xIvAJzd1bfaJfGzEiuZG5NXWvEgo1LGDyr/AguzpO8282RPZha1UTzTT+ij9w YDRr9kDJnfkT6b1mq3MHk1BHxZPHpAxHr5DVthWKvaJKx7z/W42jQ/gXZ3eoNU9iahMp ILkfQUPkFwwpc4ejKKjoLi61KCJ9pUY/TogT0G4VicKRsm5REVLTpSR9cS10+fj5y3E0 i0q9x0LYyr+L4U3ng97elKIBv2E1uqjo9JmBIc4jdzK6YpzJ8bJpLAMHgohYci91nzSD hq7qGxXSO/l4e/CKhOT8F/zNc/vl7KqS4yKVhaBZpykpUw0mtaaCabybwvFwCYMpA8a4 fHhg== Received: by 10.68.229.6 with SMTP id sm6mr20213472pbc.120.1347860214344; Sun, 16 Sep 2012 22:36:54 -0700 (PDT) Received: from S2101-09.ap.freescale.net ([221.225.141.190]) by mx.google.com with ESMTPS id it6sm6386097pbc.14.2012.09.16.22.36.49 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Sep 2012 22:36:53 -0700 (PDT) From: Shawn Guo <shawn.guo@linaro.org> To: linux-arm-kernel@lists.infradead.org Cc: Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <fabio.estevam@freescale.com>, Rob Herring <rob.herring@calxeda.com>, Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawn.guo@linaro.org>, Guennadi Liakhovetski <g.liakhovetski@gmx.de>, linux-media@vger.kernel.org Subject: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device Date: Mon, 17 Sep 2012 13:34:55 +0800 Message-Id: <1347860103-4141-27-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1347860103-4141-1-git-send-email-shawn.guo@linaro.org> References: <1347860103-4141-1-git-send-email-shawn.guo@linaro.org> X-Gm-Message-State: ALoCoQm41/D1qj2shanQNDaqSOFJKhufXYDoYOp+DGzRufSlSlmiOKGhUfTFd++zovOUSOeeTmes Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.9.17.52726 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __DATE_TZ_HK 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Shawn Guo
Sept. 17, 2012, 5:34 a.m. UTC
This is a piece of code becoming dead since commit 2c9ba37 ([media]
V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA
mandatory). It should have been removed together with the commit.
Remove it now.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-media@vger.kernel.org
---
drivers/media/video/mx2_camera.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Comments
Hi Shawn Thanks for the clean up. Would you like these patches to go via a single tree, presumably, arm-soc? In this case On Mon, 17 Sep 2012, Shawn Guo wrote: > This is a piece of code becoming dead since commit 2c9ba37 ([media] > V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA > mandatory). It should have been removed together with the commit. > Remove it now. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Cc: linux-media@vger.kernel.org Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Thanks Guennadi > --- > drivers/media/video/mx2_camera.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c > index 965427f..89c7e28 100644 > --- a/drivers/media/video/mx2_camera.c > +++ b/drivers/media/video/mx2_camera.c > @@ -441,11 +441,9 @@ static int mx2_camera_add_device(struct soc_camera_device *icd) > > csicr1 = CSICR1_MCLKEN; > > - if (cpu_is_mx27()) { > + if (cpu_is_mx27()) > csicr1 |= CSICR1_PRP_IF_EN | CSICR1_FCC | > CSICR1_RXFF_LEVEL(0); > - } else if (cpu_is_mx27()) > - csicr1 |= CSICR1_SOF_INTEN | CSICR1_RXFF_LEVEL(2); > > pcdev->csicr1 = csicr1; > writel(pcdev->csicr1, pcdev->base_csi + CSICR1); > -- > 1.7.9.5 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 17 September 2012 10:18, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > Hi Shawn > > Thanks for the clean up. Would you like these patches to go via a single > tree, presumably, arm-soc? In this case > > On Mon, 17 Sep 2012, Shawn Guo wrote: > >> This is a piece of code becoming dead since commit 2c9ba37 ([media] >> V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA >> mandatory). It should have been removed together with the commit. >> Remove it now. >> >> Signed-off-by: Shawn Guo <shawn.guo@linaro.org> >> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> >> Cc: linux-media@vger.kernel.org > Acked-by: Javier Martin <javier.martin@vista-silicon.com> > Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > Thanks > Guennadi > >> --- >> drivers/media/video/mx2_camera.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c >> index 965427f..89c7e28 100644 >> --- a/drivers/media/video/mx2_camera.c >> +++ b/drivers/media/video/mx2_camera.c >> @@ -441,11 +441,9 @@ static int mx2_camera_add_device(struct soc_camera_device *icd) >> >> csicr1 = CSICR1_MCLKEN; >> >> - if (cpu_is_mx27()) { >> + if (cpu_is_mx27()) >> csicr1 |= CSICR1_PRP_IF_EN | CSICR1_FCC | >> CSICR1_RXFF_LEVEL(0); >> - } else if (cpu_is_mx27()) >> - csicr1 |= CSICR1_SOF_INTEN | CSICR1_RXFF_LEVEL(2); >> >> pcdev->csicr1 = csicr1; >> writel(pcdev->csicr1, pcdev->base_csi + CSICR1); >> -- >> 1.7.9.5 >> > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Sep 17, 2012 at 10:18:42AM +0200, Guennadi Liakhovetski wrote: > Hi Shawn > > Thanks for the clean up. Would you like these patches to go via a single > tree, presumably, arm-soc? In this case > Yes, to save the cross-tree dependency, I would like to have the series go via arm-soc tree as a whole. > On Mon, 17 Sep 2012, Shawn Guo wrote: > > > This is a piece of code becoming dead since commit 2c9ba37 ([media] > > V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA > > mandatory). It should have been removed together with the commit. > > Remove it now. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > Cc: linux-media@vger.kernel.org > > Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Thanks, Guennadi.
diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 965427f..89c7e28 100644 --- a/drivers/media/video/mx2_camera.c +++ b/drivers/media/video/mx2_camera.c @@ -441,11 +441,9 @@ static int mx2_camera_add_device(struct soc_camera_device *icd) csicr1 = CSICR1_MCLKEN; - if (cpu_is_mx27()) { + if (cpu_is_mx27()) csicr1 |= CSICR1_PRP_IF_EN | CSICR1_FCC | CSICR1_RXFF_LEVEL(0); - } else if (cpu_is_mx27()) - csicr1 |= CSICR1_SOF_INTEN | CSICR1_RXFF_LEVEL(2); pcdev->csicr1 = csicr1; writel(pcdev->csicr1, pcdev->base_csi + CSICR1);