Message ID | 4FE27936.8090401@xenotime.net (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1ShWEb-0001kO-TV for patchwork@linuxtv.org; Thu, 21 Jun 2012 03:30:57 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for <patchwork@linuxtv.org> id 1ShWEb-00028k-EV; Thu, 21 Jun 2012 03:30:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756643Ab2FUBaz (ORCPT <rfc822;patchwork@linuxtv.org>); Wed, 20 Jun 2012 21:30:55 -0400 Received: from oproxy7-pub.bluehost.com ([67.222.55.9]:38469 "HELO oproxy7-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756527Ab2FUBay (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 20 Jun 2012 21:30:54 -0400 Received: (qmail 23615 invoked by uid 0); 21 Jun 2012 01:30:54 -0000 Received: from unknown (HELO box742.bluehost.com) (66.147.244.242) by oproxy7.bluehost.com with SMTP; 21 Jun 2012 01:30:54 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenotime.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=IosnPfd6N1FQAMOEJ3Q3N7sQL2Khb79O7ScQ63BIPHQ=; b=aRBg+Ec3YOUy4l0wYF8g6XSlDImvo5ZkHRu0TtuM1Gb122+2TVEGQkwK76VHJz0+q2+kls13Cm4wJ+DpZXJNL2wih+gY72ZA84rgscCjlgTmvzD/3l0XpJXL4HpCxqNv; Received: from [50.53.38.135] (port=35063 helo=[192.168.1.2]) by box742.bluehost.com with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76) (envelope-from <rdunlap@xenotime.net>) id 1ShWEX-0006Mq-TO; Wed, 20 Jun 2012 19:30:53 -0600 Message-ID: <4FE27936.8090401@xenotime.net> Date: Wed, 20 Jun 2012 18:30:30 -0700 From: Randy Dunlap <rdunlap@xenotime.net> User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: akpm@linux-foundation.org, linux-media <linux-media@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Mauro Carvalho Chehab <mchehab@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org> Subject: [PATCH] media: pms.c needs linux/slab.h References: <20120619212521.D53D6A01BD@akpm.mtv.corp.google.com> In-Reply-To: <20120619212521.D53D6A01BD@akpm.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.6.21.12127 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, RATWARE_LC_DIGITS_HELO 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Commit Message
Randy Dunlap
June 21, 2012, 1:30 a.m. UTC
From: Randy Dunlap <rdunlap@xenotime.net> drivers/media/video/pms.c uses kzalloc() and kfree() so it should include <linux/slab.h> to fix build errors and a warning. drivers/media/video/pms.c:1047:2: error: implicit declaration of function 'kzalloc' drivers/media/video/pms.c:1047:6: warning: assignment makes pointer from integer without a cast drivers/media/video/pms.c:1116:2: error: implicit declaration of function 'kfree' Found in mmotm but applies to mainline. Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Cc: Hans Verkuil <hverkuil@xs4all.nl> --- drivers/media/video/pms.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On 21/06/12 03:30, Randy Dunlap wrote: > From: Randy Dunlap<rdunlap@xenotime.net> > > drivers/media/video/pms.c uses kzalloc() and kfree() so it should > include<linux/slab.h> to fix build errors and a warning. > > drivers/media/video/pms.c:1047:2: error: implicit declaration of function 'kzalloc' > drivers/media/video/pms.c:1047:6: warning: assignment makes pointer from integer without a cast > drivers/media/video/pms.c:1116:2: error: implicit declaration of function 'kfree' > > Found in mmotm but applies to mainline. > > Signed-off-by: Randy Dunlap<rdunlap@xenotime.net> > Cc: Hans Verkuil<hverkuil@xs4all.nl> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > drivers/media/video/pms.c | 1 + > 1 file changed, 1 insertion(+) > > --- mmotm-0619.orig/drivers/media/video/pms.c > +++ mmotm-0619/drivers/media/video/pms.c > @@ -29,6 +29,7 @@ > #include<linux/ioport.h> > #include<linux/init.h> > #include<linux/mutex.h> > +#include<linux/slab.h> > #include<linux/uaccess.h> > #include<linux/isa.h> > #include<asm/io.h> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- mmotm-0619.orig/drivers/media/video/pms.c +++ mmotm-0619/drivers/media/video/pms.c @@ -29,6 +29,7 @@ #include <linux/ioport.h> #include <linux/init.h> #include <linux/mutex.h> +#include <linux/slab.h> #include <linux/uaccess.h> #include <linux/isa.h> #include <asm/io.h>