Message ID | 200906101944.n5AJiIKQ031735@imap1.linux-foundation.org (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Wed, 10 Jun 2009 19:44:41 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for <mchehab@localhost> (single-drop); Wed, 10 Jun 2009 16:46:35 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1METiy-0007eR-Ec; Wed, 10 Jun 2009 19:44:41 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755988AbZFJToe (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Wed, 10 Jun 2009 15:44:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757830AbZFJToe (ORCPT <rfc822;linux-media-outgoing>); Wed, 10 Jun 2009 15:44:34 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51755 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755988AbZFJTod (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 10 Jun 2009 15:44:33 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n5AJiJiq029933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 10 Jun 2009 12:44:20 -0700 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n5AJiIKQ031735; Wed, 10 Jun 2009 12:44:18 -0700 Message-Id: <200906101944.n5AJiIKQ031735@imap1.linux-foundation.org> Subject: [patch 1/6] radio-mr800.c: missing mutex include To: mchehab@infradead.org Cc: linux-media@vger.kernel.org, akpm@linux-foundation.org, abogani@texware.it From: akpm@linux-foundation.org Date: Wed, 10 Jun 2009 12:44:18 -0700 X-Spam-Status: No, hits=-3.502 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Andrew Morton
June 10, 2009, 7:44 p.m. UTC
From: Alessio Igor Bogani <abogani@texware.it> radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be pulled in indirectly by one of the headers it already includes, the right thing is to include it directly. Signed-off-by: Alessio Igor Bogani <abogani@texware.it> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/media/radio/radio-mr800.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Wed, Jun 10, 2009 at 11:44 PM, <akpm@linux-foundation.org> wrote: > From: Alessio Igor Bogani <abogani@texware.it> > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be > pulled in indirectly by one of the headers it already includes, the right > thing is to include it directly. It was already applied to v4l-dvb tree (and probably to v4l git tree). Thanks,
On Thu, 11 Jun 2009 03:21:36 +0400 Alexey Klimov <klimov.linux@gmail.com> wrote: > On Wed, Jun 10, 2009 at 11:44 PM, <akpm@linux-foundation.org> wrote: > > From: Alessio Igor Bogani <abogani@texware.it> > > > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be > > pulled in indirectly by one of the headers it already includes, the right > > thing is to include it directly. > > It was already applied to v4l-dvb tree (and probably to v4l git tree). It isn't in today's linux-next. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Wed, 10 Jun 2009 16:23:44 -0700 Andrew Morton <akpm@linux-foundation.org> escreveu: > On Thu, 11 Jun 2009 03:21:36 +0400 Alexey Klimov <klimov.linux@gmail.com> wrote: > > > On Wed, Jun 10, 2009 at 11:44 PM, <akpm@linux-foundation.org> wrote: > > > From: Alessio Igor Bogani <abogani@texware.it> > > > > > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be > > > pulled in indirectly by one of the headers it already includes, the right > > > thing is to include it directly. > > > > It was already applied to v4l-dvb tree (and probably to v4l git tree). > > It isn't in today's linux-next. Hi Andrew, Thanks for remind us about those 6 patches. I'll double check if those are already on my staging tree. If they aren't I'll apply or comment. Since I'm currently in the proccess updating my trees, I should be adding several pending patches on my -git tree, probably in time for tomorrow's linux-next tree. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -puN drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include drivers/media/radio/radio-mr800.c --- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include +++ a/drivers/media/radio/radio-mr800.c @@ -64,6 +64,7 @@ #include <media/v4l2-ioctl.h> #include <linux/usb.h> #include <linux/version.h> /* for KERNEL_VERSION MACRO */ +#include <linux/mutex.h> /* driver and module definitions */ #define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>"