[1/4,media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file
Commit Message
Fixes the following sparse warning:
drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
'flite_hw_set_out_order' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/media/video/s5p-fimc/fimc-lite-reg.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
Hi Sachin,
On 05/25/2012 07:38 PM, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
> 'flite_hw_set_out_order' was not declared. Should it be static?
Thanks for the patches. However I'm inclined to squash this whole
series into one patch, since it addresses same issue in one driver,
just in different. I don't see a good reason to split those changes
like this. Could you make it just one patch instead ?
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester,
On 26 May 2012 14:09, Sylwester Nawrocki <snjw23@gmail.com> wrote:
> Hi Sachin,
>
>
> On 05/25/2012 07:38 PM, Sachin Kamat wrote:
>>
>> Fixes the following sparse warning:
>> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
>> 'flite_hw_set_out_order' was not declared. Should it be static?
>
>
> Thanks for the patches. However I'm inclined to squash this whole
> series into one patch, since it addresses same issue in one driver,
> just in different. I don't see a good reason to split those changes
> like this. Could you make it just one patch instead ?
Sure. I will send it on Monday.
In fact I too wanted to send it as a single patch but wasn't quite
sure if it was OK to do so.
>
>
> Regards,
> Sylwester
@@ -215,7 +215,7 @@ void flite_hw_set_camera_bus(struct fimc_lite *dev,
flite_hw_set_camera_port(dev, s_info->mux_id);
}
-void flite_hw_set_out_order(struct fimc_lite *dev, struct flite_frame *f)
+static void flite_hw_set_out_order(struct fimc_lite *dev, struct flite_frame *f)
{
static const u32 pixcode[4][2] = {
{ V4L2_MBUS_FMT_YUYV8_2X8, FLITE_REG_CIODMAFMT_YCBYCR },