| Message ID | 4FB62695.3030909@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1SVKZi-0006UF-3C for patchwork@linuxtv.org; Fri, 18 May 2012 12:38:22 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1SVKZh-0000iO-Ge; Fri, 18 May 2012 12:38:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762675Ab2ERKiS (ORCPT <rfc822;patchwork@linuxtv.org>); Fri, 18 May 2012 06:38:18 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:47476 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760392Ab2ERKiS (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 18 May 2012 06:38:18 -0400 Received: by bkcji2 with SMTP id ji2so2231115bkc.19 for <linux-media@vger.kernel.org>; Fri, 18 May 2012 03:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=nhz1LZ/7udao1CeAZUYIP8w1GXCIolQ5G6hLskogxus=; b=w3xCmvGNeVraLj8Zos8GcV9E0G9TDYfLiAHxcre4gEd5QXxlTjYPgTtkLuhChTEKxJ kVcRpuAfnbGH9wBlB9KXzwg+Q9Kb8ffOOgBSzkYyTDUYn8vFuIV8E6uRE50owDvi5lMM 17h8UgpIexy5iyYlM7JbAw+N6K/V80QYCk0NVHCGPVbL7610YhbGVBP9A5DnzdbafhL3 pnzGvxf87MEjnQVvGCLF9kk73QVY2A5IMXugarPZ+tEEsCXS7kQe92sMefgMnpDB1ZYP ZX/klCrnVVBPZec7zJU8BK/obbt4LdH49qkWgzybA4kjbEfrxU1RD0eKem9YAMghfXGk 7TpA== Received: by 10.204.128.201 with SMTP id l9mr3833740bks.68.1337337496849; Fri, 18 May 2012 03:38:16 -0700 (PDT) Received: from nuna.dma (iskon5912.duo.carnet.hr. [31.147.119.24]) by mx.google.com with ESMTPS id x23sm16560379bkw.12.2012.05.18.03.38.14 (version=SSLv3 cipher=OTHER); Fri, 18 May 2012 03:38:15 -0700 (PDT) Message-ID: <4FB62695.3030909@gmail.com> Date: Fri, 18 May 2012 12:38:13 +0200 From: poma <pomidorabelisima@gmail.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Antti Palosaari <crope@iki.fi> CC: Thomas Mair <thomas.mair86@googlemail.com>, linux-media@vger.kernel.org Subject: Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics References: <1337206420-23810-1-git-send-email-thomas.mair86@googlemail.com> <1337206420-23810-2-git-send-email-thomas.mair86@googlemail.com> <4FB50909.7030101@iki.fi> <4FB59E03.7080800@gmail.com> <CAKZ=SG_mvvFae9ZE2H3ci_3HosLmQ1kihyGx6QCdyQGgQro52Q@mail.gmail.com> <4FB61328.3090707@gmail.com> In-Reply-To: <4FB61328.3090707@gmail.com> Content-Type: multipart/mixed; boundary="------------090000020008020906040801" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.18.102721 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, FROM_NAME_ONE_WORD 0.05, HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1700_1799 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BAT_BOUNDARY 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Commit Message
poma
May 18, 2012, 10:38 a.m. UTC
[…] printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) pr_err(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) pr_info(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) pr_warn(LOG_PREFIX": " f "\n" , ## arg) Besides what 'checkpatch' suggest/output - Antti, is it a correct conversions? cheers, poma
Comments
On 18.05.2012 13:38, poma wrote: > […] > > printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) > pr_err(LOG_PREFIX": " f "\n" , ## arg) > > printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) > pr_info(LOG_PREFIX": " f "\n" , ## arg) > > printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) > pr_warn(LOG_PREFIX": " f "\n" , ## arg) > > Besides what 'checkpatch' suggest/output - Antti, is it a correct > conversions? I haven't looked those pr_err/pr_info/pr_warn, but what I did for af9035/af9033 was I used pr_debug as a debug writings since it seems to be choice of today. I still suspect those pr_* functions should be used instead own macros. Currently documentation mentions only pr_debug and pr_info. regards Antit
On 05/18/2012 02:38 PM, Antti Palosaari wrote: > On 18.05.2012 13:38, poma wrote: >> […] >> >> printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) >> pr_err(LOG_PREFIX": " f "\n" , ## arg) >> >> printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) >> pr_info(LOG_PREFIX": " f "\n" , ## arg) >> >> printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) >> pr_warn(LOG_PREFIX": " f "\n" , ## arg) >> >> Besides what 'checkpatch' suggest/output - Antti, is it a correct >> conversions? > > > I haven't looked those pr_err/pr_info/pr_warn, but what I did for > af9035/af9033 was I used pr_debug as a debug writings since it seems to > be choice of today. > > I still suspect those pr_* functions should be used instead own macros. > Currently documentation mentions only pr_debug and pr_info. > > regards > Antit OK, thanks Antti! Thomas, dropping 'rtl2832_priv.h.diff' & 'rtl2832_priv.h-v2.diff' Please leave 'rtl2832_priv.h' as it is. And there you go… cheers, poma -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18.05.2012 15:26, poma wrote: > On 05/18/2012 02:38 PM, Antti Palosaari wrote: >> On 18.05.2012 13:38, poma wrote: >>> […] >>> >>> printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) >>> pr_err(LOG_PREFIX": " f "\n" , ## arg) >>> >>> printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) >>> pr_info(LOG_PREFIX": " f "\n" , ## arg) >>> >>> printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) >>> pr_warn(LOG_PREFIX": " f "\n" , ## arg) >>> >>> Besides what 'checkpatch' suggest/output - Antti, is it a correct >>> conversions? >> >> >> I haven't looked those pr_err/pr_info/pr_warn, but what I did for >> af9035/af9033 was I used pr_debug as a debug writings since it seems to >> be choice of today. >> >> I still suspect those pr_* functions should be used instead own macros. >> Currently documentation mentions only pr_debug and pr_info. >> >> regards >> Antit > > OK, thanks Antti! > Thomas, dropping 'rtl2832_priv.h.diff' & 'rtl2832_priv.h-v2.diff' > Please leave 'rtl2832_priv.h' as it is. > And there you go… > > cheers, > poma Alright. One last question though. I seem incapable of removing the checkpatch error with the parentheses. How should that be done properly? Should do something like do { ... } while(0) or is there a more elegant solution? Regrads Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18.05.2012 20:46, Thomas Mair wrote: > On 18.05.2012 15:26, poma wrote: >> On 05/18/2012 02:38 PM, Antti Palosaari wrote: >>> On 18.05.2012 13:38, poma wrote: >>>> […] >>>> >>>> printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) >>>> pr_err(LOG_PREFIX": " f "\n" , ## arg) >>>> >>>> printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) >>>> pr_info(LOG_PREFIX": " f "\n" , ## arg) >>>> >>>> printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) >>>> pr_warn(LOG_PREFIX": " f "\n" , ## arg) >>>> >>>> Besides what 'checkpatch' suggest/output - Antti, is it a correct >>>> conversions? >>> >>> >>> I haven't looked those pr_err/pr_info/pr_warn, but what I did for >>> af9035/af9033 was I used pr_debug as a debug writings since it seems to >>> be choice of today. >>> >>> I still suspect those pr_* functions should be used instead own macros. >>> Currently documentation mentions only pr_debug and pr_info. >>> >>> regards >>> Antit >> >> OK, thanks Antti! >> Thomas, dropping 'rtl2832_priv.h.diff'& 'rtl2832_priv.h-v2.diff' >> Please leave 'rtl2832_priv.h' as it is. >> And there you go… >> >> cheers, >> poma > > Alright. One last question though. > > I seem incapable of removing the checkpatch error with the parentheses. > How should that be done properly? Should do something like do { ... } while(0) > or is there a more elegant solution? I have seen that do { ... } while(0) many times in Kernel sources so it is likely the proper solution. regards Antti
--- rtl2832_priv.h.orig 2012-05-18 02:02:48.561114101 +0200 +++ rtl2832_priv.h 2012-05-18 12:20:45.000000000 +0200 @@ -29,13 +29,13 @@ #undef dbg #define dbg(f, arg...) \ if (rtl2832_debug) \ - printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) + pr_info(LOG_PREFIX": " f "\n" , ## arg) #undef err -#define err(f, arg...) printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) +#define err(f, arg...) pr_err(LOG_PREFIX": " f "\n" , ## arg) #undef info -#define info(f, arg...) printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) +#define info(f, arg...) pr_info(LOG_PREFIX": " f "\n" , ## arg) #undef warn -#define warn(f, arg...) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) +#define warn(f, arg...) pr_warn(LOG_PREFIX": " f "\n" , ## arg) struct rtl2832_priv { struct i2c_adapter *i2c;