Message ID | 1336083747-3142-3-git-send-email-mathieu.poirier@linaro.org (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1SQ4QM-0005ue-Kv for patchwork@linuxtv.org; Fri, 04 May 2012 00:22:58 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1SQ4QL-00060A-JH; Fri, 04 May 2012 00:22:58 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758930Ab2ECWWj (ORCPT <rfc822;patchwork@linuxtv.org>); Thu, 3 May 2012 18:22:39 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:51180 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758907Ab2ECWWf (ORCPT <rfc822; linux-media@vger.kernel.org>); Thu, 3 May 2012 18:22:35 -0400 Received: by pbbrp8 with SMTP id rp8so3032860pbb.19 for <linux-media@vger.kernel.org>; Thu, 03 May 2012 15:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=H9fO4I4d+odkoFU/CxYZVywMFJWIZRWSpUc70g4f/oE=; b=W9KkGcNiNb6Jumlj/J+qY4y0ZJK8lCq0P4UodpZFRbL0OpNBsgoMhbwsgk7eiFQOAq ObeuE5U7Eg5vqEee+uS7wg8of6Wy34091nI1PNfFzs3I/VsTwg7wZuDja9IPK4l+NUYV fJKpp2KO5/Mh/cC3Fq814XlmsbFY/uVZjYLBsS4CyANfHY4rE9z44fNQ5y8CQz6t+Aig TKuF1l/7EXw8FrtP4K8ATX8Dk6neJTRfDWxuSsUugxXhVgxodmEsKzAIuHO18e1do/ZH D7V+OWiLfvKKjgqWEx44FlzPQOfS3VqnmDgLbkkf+wRP0Mgzfs4Y6/H/cSeeGorIwANM 8LHw== Received: by 10.68.130.9 with SMTP id oa9mr8596753pbb.95.1336083754673; Thu, 03 May 2012 15:22:34 -0700 (PDT) Received: from localhost.localdomain (S0106002369de4dac.cg.shawcable.net. [70.73.24.112]) by mx.google.com with ESMTPS id kl2sm2639359pbc.19.2012.05.03.15.22.33 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 May 2012 15:22:34 -0700 (PDT) From: mathieu.poirier@linaro.org To: mchehab@infradead.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, mathieu.poirier@linaro.org Subject: [PATCH 2/6] v4l/dvb: fix Kconfig dependencies on VIDEO_CAPTURE_DRIVERS Date: Thu, 3 May 2012 16:22:23 -0600 Message-Id: <1336083747-3142-3-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1336083747-3142-1-git-send-email-mathieu.poirier@linaro.org> References: <1336083747-3142-1-git-send-email-mathieu.poirier@linaro.org> X-Gm-Message-State: ALoCoQkJ/J2QHXka7lcXMaU/m3P+As0M8r3/Mk4bliSxZgFW2ke446PUd4u0SVicT/7daKizQrRO Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.3.221217 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, NO_REAL_NAME 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Mathieu Poirier
May 3, 2012, 10:22 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> Kconfig warns about unsatisfied dependencies of symbols that are directly selected. Many capture drivers depend on DVB capture drivers, which are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting. The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally when both DVB and VIDEO_CAPTURE_DRIVERS are enabled. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/media/dvb/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Comments
Em 03-05-2012 19:22, mathieu.poirier@linaro.org escreveu: > From: Arnd Bergmann <arnd@arndb.de> > > Kconfig warns about unsatisfied dependencies of symbols that > are directly selected. > > Many capture drivers depend on DVB capture drivers, which > are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting. > > The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally > when both DVB and VIDEO_CAPTURE_DRIVERS are enabled. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > --- > drivers/media/dvb/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig > index f6e40b3..c617996 100644 > --- a/drivers/media/dvb/Kconfig > +++ b/drivers/media/dvb/Kconfig > @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS > If you are unsure about this, say N here. > > menuconfig DVB_CAPTURE_DRIVERS > - bool "DVB/ATSC adapters" > + bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS > depends on DVB_CORE > default y > ---help--- No, this is not right. Users can select either DVB or V4L2 (or hybrid) devices independently. If now a warning is happening, is because something changed Kconfig behavior on some non-expected way. Nack. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 15-05-2012 07:44, Mauro Carvalho Chehab escreveu: > Em 03-05-2012 19:22, mathieu.poirier@linaro.org escreveu: >> From: Arnd Bergmann <arnd@arndb.de> >> >> Kconfig warns about unsatisfied dependencies of symbols that >> are directly selected. >> >> Many capture drivers depend on DVB capture drivers, which >> are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting. >> >> The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally >> when both DVB and VIDEO_CAPTURE_DRIVERS are enabled. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> >> --- >> drivers/media/dvb/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig >> index f6e40b3..c617996 100644 >> --- a/drivers/media/dvb/Kconfig >> +++ b/drivers/media/dvb/Kconfig >> @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS >> If you are unsure about this, say N here. >> >> menuconfig DVB_CAPTURE_DRIVERS >> - bool "DVB/ATSC adapters" >> + bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS >> depends on DVB_CORE >> default y >> ---help--- > > No, this is not right. Users can select either DVB or V4L2 (or hybrid) > devices independently. > > If now a warning is happening, is because something changed Kconfig > behavior on some non-expected way. I remember a similar bug in the past that it was solved by using a new Kconfig dialect "visible if". Not sure it this applies here. > > Nack. > > Regards, > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig index f6e40b3..c617996 100644 --- a/drivers/media/dvb/Kconfig +++ b/drivers/media/dvb/Kconfig @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS If you are unsure about this, say N here. menuconfig DVB_CAPTURE_DRIVERS - bool "DVB/ATSC adapters" + bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS depends on DVB_CORE default y ---help---