dib0700: add new USB PID for the Elgato EyeTV DTT stick

Message ID 1334409247-32467-1-git-send-email-gennarone@gmail.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Gianluca Gennari April 14, 2012, 1:14 p.m. UTC
  Reported working here:
http://ubuntuforums.org/archive/index.php/t-1510188.html
http://ubuntuforums.org/archive/index.php/t-1756828.html
https://sites.google.com/site/slackwarestuff/home/elgato-eyetv

Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
 drivers/media/dvb/dvb-usb/dib0700_devices.c |    7 ++++++-
 drivers/media/dvb/dvb-usb/dvb-usb-ids.h     |    1 +
 2 files changed, 7 insertions(+), 1 deletions(-)
  

Comments

Daniel April 16, 2012, 6:51 a.m. UTC | #1
Hi,

This patch works fine, but the IR sensor doesn't seem to be enabled. 
It's not a problem, because the stick isn't sold with a remote control.

Sincerely,

Daniel


On 14/04/2012 15:14, Gianluca Gennari wrote:
> Reported working here:
> http://ubuntuforums.org/archive/index.php/t-1510188.html
> http://ubuntuforums.org/archive/index.php/t-1756828.html
> https://sites.google.com/site/slackwarestuff/home/elgato-eyetv
>
> Signed-off-by: Gianluca Gennari<gennarone@gmail.com>
> ---
>   drivers/media/dvb/dvb-usb/dib0700_devices.c |    7 ++++++-
>   drivers/media/dvb/dvb-usb/dvb-usb-ids.h     |    1 +
>   2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
> index f9e966a..510001d 100644
> --- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
> +++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
> @@ -3569,6 +3569,7 @@ struct usb_device_id dib0700_usb_id_table[] = {
>   	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE7090E) },
>   	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE7790E) },
>   /* 80 */{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE8096P) },
> +	{ USB_DEVICE(USB_VID_ELGATO,	USB_PID_ELGATO_EYETV_DTT_2) },
>   	{ 0 }		/* Terminating entry */
>   };
>   MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
> @@ -3832,7 +3833,7 @@ struct dvb_usb_device_properties dib0700_devices[] = {
>   			},
>   		},
>
> -		.num_device_descs = 11,
> +		.num_device_descs = 12,
>   		.devices = {
>   			{   "DiBcom STK7070P reference design",
>   				{&dib0700_usb_id_table[15], NULL },
> @@ -3878,6 +3879,10 @@ struct dvb_usb_device_properties dib0700_devices[] = {
>   				{&dib0700_usb_id_table[50], NULL },
>   				{ NULL },
>   			},
> +			{   "Elgato EyeTV DTT rev. 2",
> +				{&dib0700_usb_id_table[81], NULL },
> +				{ NULL },
> +			},
>   		},
>
>   		.rc.core = {
> diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> index 94d3f8a..2418e41 100644
> --- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> @@ -335,6 +335,7 @@
>   #define USB_PID_MYGICA_D689				0xd811
>   #define USB_PID_ELGATO_EYETV_DIVERSITY			0x0011
>   #define USB_PID_ELGATO_EYETV_DTT			0x0021
> +#define USB_PID_ELGATO_EYETV_DTT_2			0x003f
>   #define USB_PID_ELGATO_EYETV_DTT_Dlx			0x0020
>   #define USB_PID_ELGATO_EYETV_SAT			0x002a
>   #define USB_PID_DVB_T_USB_STICK_HIGH_SPEED_COLD		0x5000
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Gianluca Gennari April 16, 2012, 3:45 p.m. UTC | #2
Il 16/04/2012 08:51, Daniel ha scritto:
> Hi,
> 
> This patch works fine, but the IR sensor doesn't seem to be enabled.
> It's not a problem, because the stick isn't sold with a remote control.
> 
> Sincerely,
> 
> Daniel
> 

Hi Daniel,
thanks for testing the patch.
Regarding the remote, the driver apparently supports RC5, RC6 and NEC
protocols, but defaults to RC5 for almost all devices (including the
Elgato ones). Maybe you are trying to use a remote with a different
protocol?
I think you can switch protocols using something like:
ir-keytable --protocol=nec --sysdev=rc0
but I've never used it.

Regards,
Gianluca

> 
> On 14/04/2012 15:14, Gianluca Gennari wrote:
>> Reported working here:
>> http://ubuntuforums.org/archive/index.php/t-1510188.html
>> http://ubuntuforums.org/archive/index.php/t-1756828.html
>> https://sites.google.com/site/slackwarestuff/home/elgato-eyetv
>>
>> Signed-off-by: Gianluca Gennari<gennarone@gmail.com>
>> ---
>>   drivers/media/dvb/dvb-usb/dib0700_devices.c |    7 ++++++-
>>   drivers/media/dvb/dvb-usb/dvb-usb-ids.h     |    1 +
>>   2 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c
>> b/drivers/media/dvb/dvb-usb/dib0700_devices.c
>> index f9e966a..510001d 100644
>> --- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
>> +++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
>> @@ -3569,6 +3569,7 @@ struct usb_device_id dib0700_usb_id_table[] = {
>>       { USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE7090E) },
>>       { USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE7790E) },
>>   /* 80 */{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE8096P) },
>> +    { USB_DEVICE(USB_VID_ELGATO,    USB_PID_ELGATO_EYETV_DTT_2) },
>>       { 0 }        /* Terminating entry */
>>   };
>>   MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
>> @@ -3832,7 +3833,7 @@ struct dvb_usb_device_properties
>> dib0700_devices[] = {
>>               },
>>           },
>>
>> -        .num_device_descs = 11,
>> +        .num_device_descs = 12,
>>           .devices = {
>>               {   "DiBcom STK7070P reference design",
>>                   {&dib0700_usb_id_table[15], NULL },
>> @@ -3878,6 +3879,10 @@ struct dvb_usb_device_properties
>> dib0700_devices[] = {
>>                   {&dib0700_usb_id_table[50], NULL },
>>                   { NULL },
>>               },
>> +            {   "Elgato EyeTV DTT rev. 2",
>> +                {&dib0700_usb_id_table[81], NULL },
>> +                { NULL },
>> +            },
>>           },
>>
>>           .rc.core = {
>> diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
>> b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
>> index 94d3f8a..2418e41 100644
>> --- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
>> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
>> @@ -335,6 +335,7 @@
>>   #define USB_PID_MYGICA_D689                0xd811
>>   #define USB_PID_ELGATO_EYETV_DIVERSITY            0x0011
>>   #define USB_PID_ELGATO_EYETV_DTT            0x0021
>> +#define USB_PID_ELGATO_EYETV_DTT_2            0x003f
>>   #define USB_PID_ELGATO_EYETV_DTT_Dlx            0x0020
>>   #define USB_PID_ELGATO_EYETV_SAT            0x002a
>>   #define USB_PID_DVB_T_USB_STICK_HIGH_SPEED_COLD        0x5000
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
index f9e966a..510001d 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -3569,6 +3569,7 @@  struct usb_device_id dib0700_usb_id_table[] = {
 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE7090E) },
 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE7790E) },
 /* 80 */{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_TFE8096P) },
+	{ USB_DEVICE(USB_VID_ELGATO,	USB_PID_ELGATO_EYETV_DTT_2) },
 	{ 0 }		/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
@@ -3832,7 +3833,7 @@  struct dvb_usb_device_properties dib0700_devices[] = {
 			},
 		},
 
-		.num_device_descs = 11,
+		.num_device_descs = 12,
 		.devices = {
 			{   "DiBcom STK7070P reference design",
 				{ &dib0700_usb_id_table[15], NULL },
@@ -3878,6 +3879,10 @@  struct dvb_usb_device_properties dib0700_devices[] = {
 				{ &dib0700_usb_id_table[50], NULL },
 				{ NULL },
 			},
+			{   "Elgato EyeTV DTT rev. 2",
+				{ &dib0700_usb_id_table[81], NULL },
+				{ NULL },
+			},
 		},
 
 		.rc.core = {
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index 94d3f8a..2418e41 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -335,6 +335,7 @@ 
 #define USB_PID_MYGICA_D689				0xd811
 #define USB_PID_ELGATO_EYETV_DIVERSITY			0x0011
 #define USB_PID_ELGATO_EYETV_DTT			0x0021
+#define USB_PID_ELGATO_EYETV_DTT_2			0x003f
 #define USB_PID_ELGATO_EYETV_DTT_Dlx			0x0020
 #define USB_PID_ELGATO_EYETV_SAT			0x002a
 #define USB_PID_DVB_T_USB_STICK_HIGH_SPEED_COLD		0x5000