diff mbox

[4/5] af9035: fix warning

Message ID 1333401917-27203-5-git-send-email-gennarone@gmail.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Gianluca Gennari April 2, 2012, 9:25 p.m. UTC 
  af9035.c: In function 'af9035_download_firmware':
af9035.c:446:3: warning: format '%lu' expects argument of type 'long unsigned
int', but argument 3 has type 'unsigned int' [-Wformat]

Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
 drivers/media/dvb/dvb-usb/af9035.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Antti Palosaari April 2, 2012, 10:41 p.m. UTC | #1 
On 03.04.2012 00:25, Gianluca Gennari wrote:
> af9035.c: In function 'af9035_download_firmware':
> af9035.c:446:3: warning: format '%lu' expects argument of type 'long unsigned
> int', but argument 3 has type 'unsigned int' [-Wformat]
>
> Signed-off-by: Gianluca Gennari<gennarone@gmail.com>
> ---
>   drivers/media/dvb/dvb-usb/af9035.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/af9035.c b/drivers/media/dvb/dvb-usb/af9035.c
> index f943c57..8bf6367 100644
> --- a/drivers/media/dvb/dvb-usb/af9035.c
> +++ b/drivers/media/dvb/dvb-usb/af9035.c
> @@ -443,7 +443,7 @@ static int af9035_download_firmware(struct usb_device *udev,
>
>   		i -= hdr_data_len + HDR_SIZE;
>
> -		pr_debug("%s: data uploaded=%lu\n", __func__, fw->size - i);
> +		pr_debug("%s: data uploaded=%u\n", __func__, fw->size - i);
>   	}
>
>   	/* firmware loaded, request boot */

That gives similar error on 64bit. Maybe %zu works both 64 and 32 bit 
without warnings? Could you try and sent new patch if it works for you?

drivers/media/dvb/dvb-usb/af9035.c: In function ‘af9035_download_firmware’:
drivers/media/dvb/dvb-usb/af9035.c:446:3: warning: format ‘%u’ expects 
argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned 
int’ [-Wformat]

see here:
http://www.velocityreviews.com/forums/t593117-printf-specification-for-size_t.html

regards
Antti
diff mbox

Patch

diff --git a/drivers/media/dvb/dvb-usb/af9035.c b/drivers/media/dvb/dvb-usb/af9035.c
index f943c57..8bf6367 100644
--- a/drivers/media/dvb/dvb-usb/af9035.c
+++ b/drivers/media/dvb/dvb-usb/af9035.c
@@ -443,7 +443,7 @@  static int af9035_download_firmware(struct usb_device *udev,
 
 		i -= hdr_data_len + HDR_SIZE;
 
-		pr_debug("%s: data uploaded=%lu\n", __func__, fw->size - i);
+		pr_debug("%s: data uploaded=%u\n", __func__, fw->size - i);
 	}
 
 	/* firmware loaded, request boot */