diff mbox

ivtv: Fix build warning

Message ID 4f53b393.cBPkBHEECVOO9Jzx%Larry.Finger@lwfinger.net (mailing list archive)
State Accepted, archived
Headers

Commit Message

Larry Finger March 4, 2012, 6:25 p.m. UTC 
  In driver ivtv, there is a mismatch between the type of the radio module parameter
and the storage variable, which leads to the following warning:

  CC [M]  drivers/media/video/ivtv/ivtv-driver.o
drivers/media/video/ivtv/ivtv-driver.c: In function ‘__check_radio’:
drivers/media/video/ivtv/ivtv-driver.c:142: warning: return from incompatible pointer type
drivers/media/video/ivtv/ivtv-driver.c: At top level:
drivers/media/video/ivtv/ivtv-driver.c:142: warning: initialization from incompatible pointer type

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Danny Kukawka March 6, 2012, 1:29 p.m. UTC | #1 
Am 04.03.2012 19:25, schrieb Larry Finger:
> In driver ivtv, there is a mismatch between the type of the radio module parameter
> and the storage variable, which leads to the following warning:
> 
>   CC [M]  drivers/media/video/ivtv/ivtv-driver.o
> drivers/media/video/ivtv/ivtv-driver.c: In function ‘__check_radio’:
> drivers/media/video/ivtv/ivtv-driver.c:142: warning: return from incompatible pointer type
> drivers/media/video/ivtv/ivtv-driver.c: At top level:
> drivers/media/video/ivtv/ivtv-driver.c:142: warning: initialization from incompatible pointer type
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

See my already twice send patches:
http://thread.gmane.org/gmane.linux.kernel/1246476

Danny
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Larry Finger March 6, 2012, 4:10 p.m. UTC | #2 
On 03/06/2012 07:29 AM, Danny Kukawka wrote:
> Am 04.03.2012 19:25, schrieb Larry Finger:
>> In driver ivtv, there is a mismatch between the type of the radio module parameter
>> and the storage variable, which leads to the following warning:
>>
>>    CC [M]  drivers/media/video/ivtv/ivtv-driver.o
>> drivers/media/video/ivtv/ivtv-driver.c: In function ‘__check_radio’:
>> drivers/media/video/ivtv/ivtv-driver.c:142: warning: return from incompatible pointer type
>> drivers/media/video/ivtv/ivtv-driver.c: At top level:
>> drivers/media/video/ivtv/ivtv-driver.c:142: warning: initialization from incompatible pointer type
>>
>> Signed-off-by: Larry Finger<Larry.Finger@lwfinger.net>
>
> See my already twice send patches:
> http://thread.gmane.org/gmane.linux.kernel/1246476

Thanks for the link, and the information that the warning is being fixed.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: linux-2.6/drivers/media/video/ivtv/ivtv-driver.c
===================================================================
--- linux-2.6.orig/drivers/media/video/ivtv/ivtv-driver.c
+++ linux-2.6/drivers/media/video/ivtv/ivtv-driver.c
@@ -99,7 +99,7 @@  static int i2c_clock_period[IVTV_MAX_CAR
 
 static unsigned int cardtype_c = 1;
 static unsigned int tuner_c = 1;
-static bool radio_c = 1;
+static int radio_c = 1;
 static unsigned int i2c_clock_period_c = 1;
 static char pal[] = "---";
 static char secam[] = "--";
@@ -139,7 +139,7 @@  static int tunertype = -1;
 static int newi2c = -1;
 
 module_param_array(tuner, int, &tuner_c, 0644);
-module_param_array(radio, bool, &radio_c, 0644);
+module_param_array(radio, int, &radio_c, 0644);
 module_param_array(cardtype, int, &cardtype_c, 0644);
 module_param_string(pal, pal, sizeof(pal), 0644);
 module_param_string(secam, secam, sizeof(secam), 0644);