| Message ID | 4A0853FE.6060709@oracle.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Mon, 11 May 2009 16:34:50 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for <mchehab@localhost> (single-drop); Mon, 11 May 2009 13:36:08 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1M3YSo-00011p-HV; Mon, 11 May 2009 16:34:50 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556AbZEKQer (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 11 May 2009 12:34:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753279AbZEKQeq (ORCPT <rfc822;linux-media-outgoing>); Mon, 11 May 2009 12:34:46 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:53226 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbZEKQep (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 11 May 2009 12:34:45 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4BGY8T4024939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 May 2009 16:34:10 GMT Received: from abhmt005.oracle.com (abhmt005.oracle.com [141.146.116.14]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4BGYIsR000321; Mon, 11 May 2009 16:34:18 GMT Received: from [192.168.1.4] (/71.182.83.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 11 May 2009 09:34:15 -0700 Message-ID: <4A0853FE.6060709@oracle.com> Date: Mon, 11 May 2009 09:36:14 -0700 From: Randy Dunlap <randy.dunlap@oracle.com> Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Stephen Rothwell <sfr@canb.auug.org.au> CC: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, g.liakhovetski@gmx.de, linux-media@vger.kernel.org, Mauro Carvalho Chehab <mchehab@infradead.org> Subject: [PATCH -next] soc_camera: depends on I2C References: <20090511161442.3e9d9cb9.sfr@canb.auug.org.au> In-Reply-To: <20090511161442.3e9d9cb9.sfr@canb.auug.org.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: abhmt005.oracle.com [141.146.116.14] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A085388.00D8:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Randy Dunlap
May 11, 2009, 4:36 p.m. UTC
From: Randy Dunlap <randy.dunlap@oracle.com> soc_camera uses i2c_*() functions and has build errors when CONFIG_I2C=n: ERROR: "i2c_new_device" [drivers/media/video/soc_camera.ko] undefined! ERROR: "i2c_get_adapter" [drivers/media/video/soc_camera.ko] undefined! ERROR: "i2c_put_adapter" [drivers/media/video/soc_camera.ko] undefined! ERROR: "i2c_unregister_device" [drivers/media/video/soc_camera.ko] undefined! Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/media/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, 11 May 2009, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > soc_camera uses i2c_*() functions and has build errors when CONFIG_I2C=n: > > ERROR: "i2c_new_device" [drivers/media/video/soc_camera.ko] undefined! > ERROR: "i2c_get_adapter" [drivers/media/video/soc_camera.ko] undefined! > ERROR: "i2c_put_adapter" [drivers/media/video/soc_camera.ko] undefined! > ERROR: "i2c_unregister_device" [drivers/media/video/soc_camera.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Thanks, applied. Guennadi > --- > drivers/media/video/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20090511.orig/drivers/media/video/Kconfig > +++ linux-next-20090511/drivers/media/video/Kconfig > @@ -694,7 +694,7 @@ config VIDEO_CAFE_CCIC > > config SOC_CAMERA > tristate "SoC camera support" > - depends on VIDEO_V4L2 && HAS_DMA > + depends on VIDEO_V4L2 && HAS_DMA && I2C > select VIDEOBUF_GEN > help > SoC Camera is a common API to several cameras, not connecting > > > -- > ~Randy > LPC 2009, Sept. 23-25, Portland, Oregon > http://linuxplumbersconf.org/2009/ > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-next-20090511.orig/drivers/media/video/Kconfig +++ linux-next-20090511/drivers/media/video/Kconfig @@ -694,7 +694,7 @@ config VIDEO_CAFE_CCIC config SOC_CAMERA tristate "SoC camera support" - depends on VIDEO_V4L2 && HAS_DMA + depends on VIDEO_V4L2 && HAS_DMA && I2C select VIDEOBUF_GEN help SoC Camera is a common API to several cameras, not connecting