| Message ID | 1322698500-29924-2-git-send-email-saaguirre@ti.com (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1RVuJA-0006xA-8j; Thu, 01 Dec 2011 01:15:24 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp id 1RVuJ9-0001j2-GV; Thu, 01 Dec 2011 01:15:23 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270Ab1LAAPT (ORCPT <rfc822;hunold@linuxtv.org> + 4 others); Wed, 30 Nov 2011 19:15:19 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:45611 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910Ab1LAAPP (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 30 Nov 2011 19:15:15 -0500 Received: from dlep34.itg.ti.com ([157.170.170.115]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id pB10F3he031941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Nov 2011 18:15:03 -0600 Received: from dlep26.itg.ti.com (smtp-le.itg.ti.com [157.170.170.27]) by dlep34.itg.ti.com (8.13.7/8.13.8) with ESMTP id pB10F32O002634; Wed, 30 Nov 2011 18:15:03 -0600 (CST) Received: from DFLE70.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id pB10F3t5029503; Wed, 30 Nov 2011 18:15:03 -0600 (CST) Received: from dlelxv24.itg.ti.com (172.17.1.199) by dfle70.ent.ti.com (128.247.5.40) with Microsoft SMTP Server id 14.1.323.3; Wed, 30 Nov 2011 18:15:03 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id pB10F3pC027181; Wed, 30 Nov 2011 18:15:03 -0600 Received: from localhost (dtx0091359-ubuntu-2.am.dhcp.ti.com [10.247.19.253]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id pB10F2028908; Wed, 30 Nov 2011 18:15:02 -0600 (CST) From: Sergio Aguirre <saaguirre@ti.com> To: <linux-media@vger.kernel.org> CC: <linux-omap@vger.kernel.org>, <laurent.pinchart@ideasonboard.com>, <sakari.ailus@iki.fi>, Sergio Aguirre <saaguirre@ti.com> Subject: [PATCH v2 01/11] TWL6030: Add mapping for auxiliary regs Date: Wed, 30 Nov 2011 18:14:50 -0600 Message-ID: <1322698500-29924-2-git-send-email-saaguirre@ti.com> X-Mailer: git-send-email 1.7.7.4 In-Reply-To: <1322698500-29924-1-git-send-email-saaguirre@ti.com> References: <1322698500-29924-1-git-send-email-saaguirre@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.12.1.319 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_800_899 0, DATE_TZ_NA 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' X-LSpam-Score: -6.9 (------) X-LSpam-Report: No, score=-6.9 required=5.0 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5 autolearn=ham |
Commit Message
Aguirre Rodriguez, Sergio Alberto
Dec. 1, 2011, 12:14 a.m. UTC
Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
drivers/mfd/twl-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
On Thu, Dec 1, 2011 at 5:44 AM, Sergio Aguirre <saaguirre@ti.com> wrote: > Signed-off-by: Sergio Aguirre <saaguirre@ti.com> > --- > drivers/mfd/twl-core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index bfbd660..e26b564 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -323,7 +323,7 @@ static struct twl_mapping twl6030_map[] = { > { SUB_CHIP_ID0, TWL6030_BASEADD_ZERO }, > { SUB_CHIP_ID1, TWL6030_BASEADD_ZERO }, > > - { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, > + { SUB_CHIP_ID1, TWL6030_BASEADD_AUX }, Instead you can use TWL6030_MODULE_ID1, with base address as zero for all registers in auxiliaries register map. > { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, > { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, > { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, > -- > 1.7.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Balaji, Thanks for the review. On Thu, Dec 1, 2011 at 9:58 AM, T Krishnamoorthy, Balaji <balajitk@ti.com> wrote: > On Thu, Dec 1, 2011 at 5:44 AM, Sergio Aguirre <saaguirre@ti.com> wrote: >> Signed-off-by: Sergio Aguirre <saaguirre@ti.com> >> --- >> drivers/mfd/twl-core.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c >> index bfbd660..e26b564 100644 >> --- a/drivers/mfd/twl-core.c >> +++ b/drivers/mfd/twl-core.c >> @@ -323,7 +323,7 @@ static struct twl_mapping twl6030_map[] = { >> { SUB_CHIP_ID0, TWL6030_BASEADD_ZERO }, >> { SUB_CHIP_ID1, TWL6030_BASEADD_ZERO }, >> >> - { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, >> + { SUB_CHIP_ID1, TWL6030_BASEADD_AUX }, > > Instead you can use TWL6030_MODULE_ID1, with base address as > zero for all registers in auxiliaries register map. Ok. I'm actually thinking about this, and in the process on reviewing the need to access those registers. I should probably be using the regulator framework to control VAUX3 instead... Thanks for your inputs. Regards, Sergio > >> { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, >> { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, >> { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, >> -- >> 1.7.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index bfbd660..e26b564 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -323,7 +323,7 @@ static struct twl_mapping twl6030_map[] = { { SUB_CHIP_ID0, TWL6030_BASEADD_ZERO }, { SUB_CHIP_ID1, TWL6030_BASEADD_ZERO }, - { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, + { SUB_CHIP_ID1, TWL6030_BASEADD_AUX }, { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, { SUB_CHIP_ID2, TWL6030_BASEADD_RSV },