Message ID | uock8ky42.wl%morimoto.kuninori@renesas.com (mailing list archive) |
---|---|
State | Obsoleted, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Tue, 02 Feb 2010 05:25:43 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for <mchehab@localhost> (single-drop); Tue, 02 Feb 2010 09:10:35 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NcBGh-0005dU-6I; Tue, 02 Feb 2010 05:25:43 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750945Ab0BBFZm (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Tue, 2 Feb 2010 00:25:42 -0500 Received: from mail.renesas.com ([202.234.163.13]:40462 "EHLO mail01.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751222Ab0BBFZk (ORCPT <rfc822; linux-media@vger.kernel.org>); Tue, 2 Feb 2010 00:25:40 -0500 X-AuditID: ac140384-00000008000004f6-d2-4b67b74f5c33 Received: from guardian02.idc.renesas.com ([172.20.8.201]) by mail01.idc.renesas.com (sendmail) with ESMTP id o125PZOP002748; Tue, 2 Feb 2010 14:25:35 +0900 (JST) Received: (from root@localhost) by guardian02.idc.renesas.com with id o125PZuM029760; Tue, 2 Feb 2010 14:25:35 +0900 (JST) Received: from mta01.idc.renesas.com (localhost [127.0.0.1]) by mta01.idc.renesas.com with ESMTP id o125PYZm012137; Tue, 2 Feb 2010 14:25:34 +0900 (JST) Received: from PG10870.renesas.com ([172.30.8.159]) by ims05.idc.renesas.com (Sendmail) with ESMTPA id <0KX700EH98ELS9@ims05.idc.renesas.com>; Tue, 02 Feb 2010 14:25:34 +0900 (JST) Date: Tue, 02 Feb 2010 13:54:38 +0900 From: Kuninori Morimoto <morimoto.kuninori@renesas.com> Subject: [PATCH 2/3] soc-camera: mt9t112: modify delay time after initialize To: Guennadi <g.liakhovetski@gmx.de> Cc: Linux-V4L2 <linux-media@vger.kernel.org>, Takashi.Namiki@renesas.com, Phil.Edworthy@renesas.com Message-id: <uock8ky42.wl%morimoto.kuninori@renesas.com> MIME-version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-type: text/plain; charset=US-ASCII User-Agent: SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.3 (i386-msvc-nt5.1.2600) MULE/5.0 (SAKAKI) Meadow/3.02-dev (RINDOU) (2009-06-17 Rev.4261) X-Brightmail-Tracker: AAAAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Kuninori Morimoto
Feb. 2, 2010, 4:54 a.m. UTC
mt9t112 camera needs 100 milliseconds for initializing
Special thanks to Phil
Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Reported-by: Phil Edworthy <Phil.Edworthy@renesas.com>
---
drivers/media/video/mt9t112.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
Em 02-02-2010 02:54, Kuninori Morimoto escreveu: > mt9t112 camera needs 100 milliseconds for initializing > Special thanks to Phil > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > Reported-by: Phil Edworthy <Phil.Edworthy@renesas.com> > --- > drivers/media/video/mt9t112.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c > index 7438f8d..e581d8a 100644 > --- a/drivers/media/video/mt9t112.c > +++ b/drivers/media/video/mt9t112.c > @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable) > /* Invert PCLK (Data sampled on falling edge of pixclk) */ > mt9t112_reg_write(ret, client, 0x3C20, param); > > - mdelay(5); > + mdelay(100); > > priv->flags |= INIT_DONE; > } Hi Guennadi, What's the status of this patch? It applies ok for me, and I couldn't find any reference at the ML why it was not applied yet. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 18 Sep 2011, Mauro Carvalho Chehab wrote: > Em 02-02-2010 02:54, Kuninori Morimoto escreveu: > > mt9t112 camera needs 100 milliseconds for initializing > > Special thanks to Phil > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > Reported-by: Phil Edworthy <Phil.Edworthy@renesas.com> > > --- > > drivers/media/video/mt9t112.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c > > index 7438f8d..e581d8a 100644 > > --- a/drivers/media/video/mt9t112.c > > +++ b/drivers/media/video/mt9t112.c > > @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable) > > /* Invert PCLK (Data sampled on falling edge of pixclk) */ > > mt9t112_reg_write(ret, client, 0x3C20, param); > > > > - mdelay(5); > > + mdelay(100); > > > > priv->flags |= INIT_DONE; > > } > > Hi Guennadi, > > What's the status of this patch? > > It applies ok for me, and I couldn't find any reference at the > ML why it was not applied yet. Hm, yeah... Looks like also this patch: > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed > > mt9t112 should always be initialized when camera start. > Because current driver doesn't run this operation, > it will be un-stable if user side player run open/close several times. > Special thanks to Namiki-san > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > Reported-by: Takashi Namiki <Takashi.Namiki@renesas.com> has not been applied nor discussed on the list... For patches that old I would tend to say: if the author / submitter didn't re-submit, then, probably, patches aren't relevant anymore... Although it is quite possible, that I failed to process them back then. Morimoto-san, do you have any information on these patches? Have these problems been solved somehow, so that the patches have become obsolete, or are the problems, that they address, still there? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi, all > > > mt9t112 camera needs 100 milliseconds for initializing > > > Special thanks to Phil > > > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > > Reported-by: Phil Edworthy <Phil.Edworthy@renesas.com> > > > --- > > > drivers/media/video/mt9t112.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c > > > index 7438f8d..e581d8a 100644 > > > --- a/drivers/media/video/mt9t112.c > > > +++ b/drivers/media/video/mt9t112.c > > > @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable) > > > /* Invert PCLK (Data sampled on falling edge of pixclk) */ > > > mt9t112_reg_write(ret, client, 0x3C20, param); > > > > > > - mdelay(5); > > > + mdelay(100); > > > > > > priv->flags |= INIT_DONE; > > > } > > > > Hi Guennadi, > > > > What's the status of this patch? > > > > It applies ok for me, and I couldn't find any reference at the > > ML why it was not applied yet. > > Hm, yeah... Looks like also this patch: > > > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed > > > > mt9t112 should always be initialized when camera start. > > Because current driver doesn't run this operation, > > it will be un-stable if user side player run open/close several times. > > Special thanks to Namiki-san > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > Reported-by: Takashi Namiki <Takashi.Namiki@renesas.com> > > has not been applied nor discussed on the list... For patches that old I > would tend to say: if the author / submitter didn't re-submit, then, > probably, patches aren't relevant anymore... Although it is quite > possible, that I failed to process them back then. Morimoto-san, do you > have any information on these patches? Have these problems been solved > somehow, so that the patches have become obsolete, or are the problems, > that they address, still there? This patch is needed for mt9t112 camera initialize. I thought that it was already applied. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Morimoto-san Thanks for your reply. On Mon, 19 Sep 2011, Kuninori Morimoto wrote: > Hi Guennadi, all > > > > > mt9t112 camera needs 100 milliseconds for initializing > > > > Special thanks to Phil > > > > > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > > > Reported-by: Phil Edworthy <Phil.Edworthy@renesas.com> > > > > --- > > > > drivers/media/video/mt9t112.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c > > > > index 7438f8d..e581d8a 100644 > > > > --- a/drivers/media/video/mt9t112.c > > > > +++ b/drivers/media/video/mt9t112.c > > > > @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable) > > > > /* Invert PCLK (Data sampled on falling edge of pixclk) */ > > > > mt9t112_reg_write(ret, client, 0x3C20, param); > > > > > > > > - mdelay(5); > > > > + mdelay(100); > > > > > > > > priv->flags |= INIT_DONE; > > > > } > > > > > > Hi Guennadi, > > > > > > What's the status of this patch? > > > > > > It applies ok for me, and I couldn't find any reference at the > > > ML why it was not applied yet. > > > > Hm, yeah... Looks like also this patch: > > > > > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed > > > > > > mt9t112 should always be initialized when camera start. > > > Because current driver doesn't run this operation, > > > it will be un-stable if user side player run open/close several times. > > > Special thanks to Namiki-san > > > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > > Reported-by: Takashi Namiki <Takashi.Namiki@renesas.com> > > > > has not been applied nor discussed on the list... For patches that old I > > would tend to say: if the author / submitter didn't re-submit, then, > > probably, patches aren't relevant anymore... Although it is quite > > possible, that I failed to process them back then. Morimoto-san, do you > > have any information on these patches? Have these problems been solved > > somehow, so that the patches have become obsolete, or are the problems, > > that they address, still there? > > This patch is needed for mt9t112 camera initialize. > I thought that it was already applied. Which patch do you mean? Patch 2/3, or 3/3, or both are needed? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Morimoto-san There was a question at the bottom of this email, which you might have overseen:-) Could you give me an idea, which patche(es) exactly you meant? Thanks Guennadi On Tue, 20 Sep 2011, Guennadi Liakhovetski wrote: > Morimoto-san > > Thanks for your reply. > > On Mon, 19 Sep 2011, Kuninori Morimoto wrote: > > > Hi Guennadi, all > > > > > > > mt9t112 camera needs 100 milliseconds for initializing > > > > > Special thanks to Phil > > > > > > > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > > > > Reported-by: Phil Edworthy <Phil.Edworthy@renesas.com> > > > > > --- > > > > > drivers/media/video/mt9t112.c | 2 +- > > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > > > diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c > > > > > index 7438f8d..e581d8a 100644 > > > > > --- a/drivers/media/video/mt9t112.c > > > > > +++ b/drivers/media/video/mt9t112.c > > > > > @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable) > > > > > /* Invert PCLK (Data sampled on falling edge of pixclk) */ > > > > > mt9t112_reg_write(ret, client, 0x3C20, param); > > > > > > > > > > - mdelay(5); > > > > > + mdelay(100); > > > > > > > > > > priv->flags |= INIT_DONE; > > > > > } > > > > > > > > Hi Guennadi, > > > > > > > > What's the status of this patch? > > > > > > > > It applies ok for me, and I couldn't find any reference at the > > > > ML why it was not applied yet. > > > > > > Hm, yeah... Looks like also this patch: > > > > > > > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed > > > > > > > > mt9t112 should always be initialized when camera start. > > > > Because current driver doesn't run this operation, > > > > it will be un-stable if user side player run open/close several times. > > > > Special thanks to Namiki-san > > > > > > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > > > Reported-by: Takashi Namiki <Takashi.Namiki@renesas.com> > > > > > > has not been applied nor discussed on the list... For patches that old I > > > would tend to say: if the author / submitter didn't re-submit, then, > > > probably, patches aren't relevant anymore... Although it is quite > > > possible, that I failed to process them back then. Morimoto-san, do you > > > have any information on these patches? Have these problems been solved > > > somehow, so that the patches have become obsolete, or are the problems, > > > that they address, still there? > > > > This patch is needed for mt9t112 camera initialize. > > I thought that it was already applied. > > Which patch do you mean? Patch 2/3, or 3/3, or both are needed? > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi > There was a question at the bottom of this email, which you might have > overseen:-) Could you give me an idea, which patche(es) exactly you meant? sorry for my super late response. I losted this email. > > > > > Subject: [PATCH 2/3] soc-camera: mt9t112: modify delay time after initialize (snip) > > > > > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed > > > This patch is needed for mt9t112 camera initialize. > > > I thought that it was already applied. > > > > Which patch do you mean? Patch 2/3, or 3/3, or both are needed? Both are needed. These are bug fix patches Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi all On Wed, 12 Oct 2011, Kuninori Morimoto wrote: > Hi Guennadi > > > There was a question at the bottom of this email, which you might have > > overseen:-) Could you give me an idea, which patche(es) exactly you meant? > > sorry for my super late response. > I losted this email. > > > > > > > > Subject: [PATCH 2/3] soc-camera: mt9t112: modify delay time after initialize > (snip) > > > > > > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed > > > > > This patch is needed for mt9t112 camera initialize. > > > > I thought that it was already applied. > > > > > > Which patch do you mean? Patch 2/3, or 3/3, or both are needed? > > Both are needed. > These are bug fix patches I tried to capture several frames beginning with the very first one (as much as performance allowed), and I do see several black or wrongly coloured framed in the beginning, but none of those patches, including the proposed 300ms at the end of .s_stream() fixes the problem reliably. So, either this problems, that these patches fix, are specific to the Solution Engine board (is it the one, where the problems have been observed?), or one needs a different testing method. If they are SE-specific - I don't think, getting those fixes in the driver is very important, because mt9t112 data for SE is not in the mainline. If I was testing wrongly, please, tell me how exactly to reproduce those problems and see, how one or another patch fixes them. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi, and Phil Thank you for your check/test > > Both are needed. > > These are bug fix patches > > I tried to capture several frames beginning with the very first one (as > much as performance allowed), and I do see several black or wrongly > coloured framed in the beginning, but none of those patches, including the > proposed 300ms at the end of .s_stream() fixes the problem reliably. So, > either this problems, that these patches fix, are specific to the Solution > Engine board (is it the one, where the problems have been observed?), or > one needs a different testing method. If they are SE-specific - I don't > think, getting those fixes in the driver is very important, because > mt9t112 data for SE is not in the mainline. If I was testing wrongly, > please, tell me how exactly to reproduce those problems and see, how one > or another patch fixes them. I guess mt9t112 camera is used in SE (with local circuit ?) and Ecovec. But I forgot detail of this issue (I have no mt9t112 for now). I think Phil is the person who wanted this patch. But if this issue happen only SE, I can agree to Guennadi Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi, Morimoto-san, > > > Both are needed. > > > These are bug fix patches > > > > I tried to capture several frames beginning with the very first one (as > > much as performance allowed), and I do see several black or wrongly > > coloured framed in the beginning, but none of those patches, including the > > proposed 300ms at the end of .s_stream() fixes the problem reliably. So, > > either this problems, that these patches fix, are specific to the Solution > > Engine board (is it the one, where the problems have been observed?), or > > one needs a different testing method. If they are SE-specific - I don't > > think, getting those fixes in the driver is very important, because > > mt9t112 data for SE is not in the mainline. If I was testing wrongly, > > please, tell me how exactly to reproduce those problems and see, how one > > or another patch fixes them. > > I guess mt9t112 camera is used in SE (with local circuit ?) > and Ecovec. > But I forgot detail of this issue (I have no mt9t112 for now). > > I think Phil is the person who wanted this patch. There are capture issues on the Ecovec board with this camera. iirc, these patches made the situation better but still didn't completely fix all issues. Morimoto-san has made comments previously that the mt9t112 is a little difficult to setup and we don't have the relevant information from the manufacturer. Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c index 7438f8d..e581d8a 100644 --- a/drivers/media/video/mt9t112.c +++ b/drivers/media/video/mt9t112.c @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable) /* Invert PCLK (Data sampled on falling edge of pixclk) */ mt9t112_reg_write(ret, client, 0x3C20, param); - mdelay(5); + mdelay(100); priv->flags |= INIT_DONE; }