diff mbox series

[02/10] media: dt-bindings: media: qcs6490-rb3gen2-vision-mezzanine: Add dt bindings

Message ID 20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-2-b18ddcd7d9df@quicinc.com (mailing list archive)
State Changes Requested
Delegated to: Hans Verkuil
Headers
Series (no cover subject) |

Checks

Context Check Description
media-ci/HTML_report success Link
media-ci/report success Link
media-ci/bisect success Link
media-ci/doc success Link
media-ci/build success Link
media-ci/static-upstream success Link
media-ci/abi success Link
media-ci/media-patchstyle fail Link
media-ci/checkpatch success Link

Commit Message

Vikram Sharma Sept. 4, 2024, 11:10 a.m. UTC 
Add bindings for qcs6490-rb3gen2-vision-mezzanine.

Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 4, 2024, 11:29 a.m. UTC | #1 
On 04/09/2024 13:10, Vikram Sharma wrote:
> Add bindings for qcs6490-rb3gen2-vision-mezzanine.

This we see from the diff. Explain what is this. What are the differences.

Subject: drop duplicated, second media.


A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5cb54d69af0b..b2261dcdfc2c 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -390,6 +390,7 @@  properties:
               - fairphone,fp5
               - qcom,qcm6490-idp
               - qcom,qcs6490-rb3gen2
+              - qcom,qcs6490-rb3gen2-vision-mezzanine
               - shift,otter
           - const: qcom,qcm6490