added a new device in uvc_video.c
Commit Message
it is a webcam on new 'acer aspire 7' laptop
Comments
Hello Amil,
Thank you for the patch.
HTML e-mails are filtered by kernel mailing lists. Could you please
resent this as plain-text e-mail ? I recommend using git-send-email to
do so. If you have trouble setting it up for your e-mail provider,
https://git-send-email.io/ can help.
On Thu, Aug 29, 2024 at 05:47:53PM +0530, Amil Sanan wrote:
> it is a webcam on new 'acer aspire 7' laptop
> From d18ad3bf9bbc93da3eeb0ca4ea6598955ac05a99 Mon Sep 17 00:00:00 2001
> From: amilsanan <amilsananak@gmail.com>
> Date: Thu, 29 Aug 2024 17:38:25 +0530
> Subject: [PATCH] add a device in uvc_driver
>
> Signed-off-by: amilsanan <amilsananak@gmail.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index f0febdc08..1a3229ab6 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2441,6 +2441,15 @@ static const struct usb_device_id uvc_ids[] = {
> .driver_info = (kernel_ulong_t)&(const struct uvc_device_info){
> .uvc_version = 0x010a,
> } },
Please add a comment with the device name here, to match the other
entroes.
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
Wrong indentation.
> + .idVendor = 0x0408,
> + .idProduct = 0x4033,
Entries need to be sorted by VID:PID.
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = UVC_PC_PROTOCOL_15,
There's a stray tab after '=', it should be a space.
> + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info )
> + {.uvc_version = 0x010a, } },
Did you try to use the driver without adding this entry ? Did if fail ?
If so, how ? All that should be explained in the commit message.
Please also provide the output of 'lsusb -v -d 0408:4033' (if possible
running as root).
> /* LogiLink Wireless Webcam */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> | USB_DEVICE_ID_MATCH_INT_INFO,
From d18ad3bf9bbc93da3eeb0ca4ea6598955ac05a99 Mon Sep 17 00:00:00 2001
From: amilsanan <amilsananak@gmail.com>
Date: Thu, 29 Aug 2024 17:38:25 +0530
Subject: [PATCH] add a device in uvc_driver
Signed-off-by: amilsanan <amilsananak@gmail.com>
---
drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
1 file changed, 9 insertions(+)
@@ -2441,6 +2441,15 @@ static const struct usb_device_id uvc_ids[] = {
.driver_info = (kernel_ulong_t)&(const struct uvc_device_info){
.uvc_version = 0x010a,
} },
+ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
+ | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x0408,
+ .idProduct = 0x4033,
+ .bInterfaceClass = USB_CLASS_VIDEO,
+ .bInterfaceSubClass = 1,
+ .bInterfaceProtocol = UVC_PC_PROTOCOL_15,
+ .driver_info = (kernel_ulong_t) &(const struct uvc_device_info )
+ {.uvc_version = 0x010a, } },
/* LogiLink Wireless Webcam */
{ .match_flags = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
--
2.43.0