Message ID | 20240731164935.308994-1-biju.das.jz@bp.renesas.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Sakari Ailus |
Headers |
Received: from am.mirrors.kernel.org ([147.75.80.249]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-15654-patchwork=linuxtv.org@vger.kernel.org>) id 1sZCWw-0007u0-0F for patchwork@linuxtv.org; Wed, 31 Jul 2024 16:50:27 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E73E01F22288 for <patchwork@linuxtv.org>; Wed, 31 Jul 2024 16:50:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 421651BD03B; Wed, 31 Jul 2024 16:49:46 +0000 (UTC) X-Original-To: linux-media@vger.kernel.org Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52B4E1B29A9; Wed, 31 Jul 2024 16:49:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.160.252.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722444586; cv=none; b=oXZspyRmTorPsfl+fyCEzJdotKEidnTuPupRnZ2+9HkivyubAYojc/7nfQKut02IReXy1sQ8EUfKjDp3Hwb99qYk+18rgW6OVYaP9ToJcI29S1EXbamHc2C2KK5cWZPcIb4R4AQQ9DFBcvgiJGsJtPaATTtx5ih2OrLc+bYaCws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722444586; c=relaxed/simple; bh=GpMp6tg/YgVY/vTU7Drds7N/cSGXzNQUQkiNMM51k/o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sqVzWWOEMXOer9kiloMISbnl19kb7M1hZdCyzsfFeCuSAhcyrufU0zK2FujWFsqxG78+T6FYzLwc4etBCQLY++dT9GaXVD66c9Gt/sZ24iI18Y91XPD90QpLRhg/6asoGi4aju2udGq9R6nxCEXjMCg+ivjRyMnM1vPffKE5li4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; arc=none smtp.client-ip=210.160.252.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com X-IronPort-AV: E=Sophos;i="6.09,251,1716217200"; d="scan'208";a="214252124" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 01 Aug 2024 01:49:39 +0900 Received: from localhost.localdomain (unknown [10.226.93.39]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 1CCA64010088; Thu, 1 Aug 2024 01:49:36 +0900 (JST) From: Biju Das <biju.das.jz@bp.renesas.com> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Biju Das <biju.das.jz@bp.renesas.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, linux-media@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, Biju Das <biju.das.au@gmail.com>, linux-renesas-soc@vger.kernel.org Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE Date: Wed, 31 Jul 2024 17:49:32 +0100 Message-ID: <20240731164935.308994-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-LSpam-Score: -1.6 (-) X-LSpam-Report: No, score=-1.6 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DMARC_NONE=0.898,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=no autolearn_force=no |
Series |
media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE
|
|
Commit Message
Biju Das
July 31, 2024, 4:49 p.m. UTC
The rzg2l-csi2 driver can be compiled as a module, but lacks
MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
Fix this.
Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Biju, Thank you for the patch. On Wed, Jul 31, 2024 at 05:49:32PM +0100, Biju Das wrote: > The rzg2l-csi2 driver can be compiled as a module, but lacks > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > Fix this. > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > index e68fcdaea207..c7fdee347ac8 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > { .compatible = "renesas,rzg2l-csi2", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > static struct platform_driver rzg2l_csi2_pdrv = { > .remove_new = rzg2l_csi2_remove,
Hi Media folks, Gentle ping. Is this simple fix OK to everyone? Cheers, Biju > -----Original Message----- > From: Biju Das <biju.das.jz@bp.renesas.com> > Sent: Wednesday, July 31, 2024 5:50 PM > Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE > > The rzg2l-csi2 driver can be compiled as a module, but lacks > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > Fix this. > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > index e68fcdaea207..c7fdee347ac8 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > { .compatible = "renesas,rzg2l-csi2", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > static struct platform_driver rzg2l_csi2_pdrv = { > .remove_new = rzg2l_csi2_remove, > -- > 2.43.0
On Fri, Aug 23, 2024 at 08:58:09AM +0000, Biju Das wrote: > Hi Media folks, > > Gentle ping. Is this simple fix OK to everyone? I've added the patch to my tree and will include it in my next pull request. > > -----Original Message----- > > From: Biju Das <biju.das.jz@bp.renesas.com> > > Sent: Wednesday, July 31, 2024 5:50 PM > > Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE > > > > The rzg2l-csi2 driver can be compiled as a module, but lacks > > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > > Fix this. > > > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > index e68fcdaea207..c7fdee347ac8 100644 > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > > { .compatible = "renesas,rzg2l-csi2", }, > > { /* sentinel */ } > > }; > > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > > > static struct platform_driver rzg2l_csi2_pdrv = { > > .remove_new = rzg2l_csi2_remove,
> -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: Friday, August 23, 2024 1:20 PM > Subject: Re: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE > > On Fri, Aug 23, 2024 at 08:58:09AM +0000, Biju Das wrote: > > Hi Media folks, > > > > Gentle ping. Is this simple fix OK to everyone? > > I've added the patch to my tree and will include it in my next pull request. Thank you. Cheers, Biju > > > > -----Original Message----- > > > From: Biju Das <biju.das.jz@bp.renesas.com> > > > Sent: Wednesday, July 31, 2024 5:50 PM > > > Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing > > > MODULE_DEVICE_TABLE > > > > > > The rzg2l-csi2 driver can be compiled as a module, but lacks > > > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > > > Fix this. > > > > > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 > > > receiver driver") > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > index e68fcdaea207..c7fdee347ac8 100644 > > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > > > { .compatible = "renesas,rzg2l-csi2", }, > > > { /* sentinel */ } > > > }; > > > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > > > > > static struct platform_driver rzg2l_csi2_pdrv = { > > > .remove_new = rzg2l_csi2_remove, > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index e68fcdaea207..c7fdee347ac8 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { { .compatible = "renesas,rzg2l-csi2", }, { /* sentinel */ } }; +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); static struct platform_driver rzg2l_csi2_pdrv = { .remove_new = rzg2l_csi2_remove,