diff mbox series

media: staging: media: starfive: camss: Drop obsolete return value documentation

Message ID 20240424140249.542283-2-u.kleine-koenig@pengutronix.de (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series media: staging: media: starfive: camss: Drop obsolete return value documentation |

Commit Message

Uwe Kleine-König April 24, 2024, 2:02 p.m. UTC 
  Recently the function stfcamss_remove() was changed to not return a
value. Drop the documentation of the return value in the kernel doc.

Fixes: b1f3677aebe5 ("media: staging: media: starfive: camss: Convert to platform remove callback returning void")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

during review of the patch that became b1f3677aebe5 Changhuang pointed
out this patch opportunity. But before I came around to send a v2,
b1f3677aebe5 was already applied. So here comes a separate patch.

If you prefer, feel free to squash this into b1f3677aebe5.

Best regards
Uwe

 drivers/staging/media/starfive/camss/stf-camss.c | 2 --
 1 file changed, 2 deletions(-)


base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8

Comments

Uwe Kleine-König May 22, 2024, 6:35 a.m. UTC | #1 
Hello,

On Wed, Apr 24, 2024 at 04:02:48PM +0200, Uwe Kleine-König wrote:
> Recently the function stfcamss_remove() was changed to not return a
> value. Drop the documentation of the return value in the kernel doc.
> 
> Fixes: b1f3677aebe5 ("media: staging: media: starfive: camss: Convert to platform remove callback returning void")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> during review of the patch that became b1f3677aebe5 Changhuang pointed
> out this patch opportunity. But before I came around to send a v2,
> b1f3677aebe5 was already applied. So here comes a separate patch.
> 
> If you prefer, feel free to squash this into b1f3677aebe5.

Who feels responsible to pick up this patch (or alternatively give
feedback)? Did I forget to address the relevant persons?

Best regards
Uwe
Hans Verkuil Aug. 9, 2024, 8:47 a.m. UTC | #2 
Hi Uwe,

On 22/05/2024 08:35, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Apr 24, 2024 at 04:02:48PM +0200, Uwe Kleine-König wrote:
>> Recently the function stfcamss_remove() was changed to not return a
>> value. Drop the documentation of the return value in the kernel doc.
>>
>> Fixes: b1f3677aebe5 ("media: staging: media: starfive: camss: Convert to platform remove callback returning void")
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> ---
>> Hello,
>>
>> during review of the patch that became b1f3677aebe5 Changhuang pointed
>> out this patch opportunity. But before I came around to send a v2,
>> b1f3677aebe5 was already applied. So here comes a separate patch.
>>
>> If you prefer, feel free to squash this into b1f3677aebe5.
> 
> Who feels responsible to pick up this patch (or alternatively give
> feedback)? Did I forget to address the relevant persons?

Nope, just too many patches and too few reviewers :-)

I'll pick it up.

Regards,

	Hans

> 
> Best regards
> Uwe
>
diff mbox series

Patch

diff --git a/drivers/staging/media/starfive/camss/stf-camss.c b/drivers/staging/media/starfive/camss/stf-camss.c
index fecd3e67c7a1..b6d34145bc19 100644
--- a/drivers/staging/media/starfive/camss/stf-camss.c
+++ b/drivers/staging/media/starfive/camss/stf-camss.c
@@ -358,8 +358,6 @@  static int stfcamss_probe(struct platform_device *pdev)
 /*
  * stfcamss_remove - Remove STFCAMSS platform device
  * @pdev: Pointer to STFCAMSS platform device
- *
- * Always returns 0.
  */
 static void stfcamss_remove(struct platform_device *pdev)
 {