[v2,1/2] staging: media: sdis: move open brace to a new line

Message ID 20240730080628.991297-1-santiagorr@riseup.net (mailing list archive)
State Superseded
Headers
Series [v2,1/2] staging: media: sdis: move open brace to a new line |

Commit Message

Santiago Ruano Rincón July 30, 2024, 8:06 a.m. UTC
  Fix checkpatch error "ERROR: open brace '{' following function
definitions go on the next line" in sdis_1.0/ia_css_sdis.host.c:239.

Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>

---
This is one of my first patches. Could you please tell me if is there
anything wrong with it? Thank you.
---
---
 .../atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Dan Carpenter July 30, 2024, 3:41 p.m. UTC | #1
On Tue, Jul 30, 2024 at 05:06:27PM +0900, Santiago Ruano Rincón wrote:
> Fix checkpatch error "ERROR: open brace '{' following function
> definitions go on the next line" in sdis_1.0/ia_css_sdis.host.c:239.
> 
> Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>
> 
> ---
> This is one of my first patches. Could you please tell me if is there
> anything wrong with it? Thank you.

v2 patches need to say what changed since v1.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter
  

Patch

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c
index bf0a768f8..cabacfc84 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c
@@ -239,7 +239,8 @@  void ia_css_sdis_clear_coefficients(
 int
 ia_css_get_dvs_statistics(
     struct ia_css_dvs_statistics	       *host_stats,
-    const struct ia_css_isp_dvs_statistics *isp_stats) {
+    const struct ia_css_isp_dvs_statistics *isp_stats)
+{
 	struct ia_css_isp_dvs_statistics_map *map;
 	int ret = 0;