Message ID | 20240729110437.199428-2-umang.jain@ideasonboard.com (mailing list archive) |
---|---|
State | New |
Headers |
Received: from sy.mirrors.kernel.org ([147.75.48.161]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-15443-patchwork=linuxtv.org@vger.kernel.org>) id 1sYOCA-00024I-1D for patchwork@linuxtv.org; Mon, 29 Jul 2024 11:05:39 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A13B1B21AFC for <patchwork@linuxtv.org>; Mon, 29 Jul 2024 11:05:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E55B9145FE3; Mon, 29 Jul 2024 11:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="c1iqrUCF" X-Original-To: linux-media@vger.kernel.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03013145A01; Mon, 29 Jul 2024 11:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722251097; cv=none; b=chFApXR1+AzU0EJtkzngQy8aTThlTrksOTvMpPtOddKje3THxyvmjOPx98GT/e8ZKVO99/AYTDMOMlmiegBCfPAEnrGH+yT8yKFsENFLeSXvKaawVOiJ1SRKyf+mtmAXB38zMRyCWHGrGt+39t1EosVXNMOppqZ37kIRCbVPPBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722251097; c=relaxed/simple; bh=mdLnBpRdG1GaeLq99YJ4+5GBhadS0Kk0jpPIEyLssgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AyjzSkvVqanrzt4VW6Aaq6wXAGeCFb0RUNQhTcbw0F/BzT8sf7/qFiwjBIzE0c+gccUKFQCtBKGkTYhmqDltOTZzJKZ2AQJhQCM7WwdyC33Do5i/JVftVdSKuXJkvJ+GJMMe9MTKd/TDje3O/w8N8FVPwDAvTz5P1g/q8vRunic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=c1iqrUCF; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from localhost.localdomain (unknown [IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C6BB596; Mon, 29 Jul 2024 13:04:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1722251048; bh=mdLnBpRdG1GaeLq99YJ4+5GBhadS0Kk0jpPIEyLssgY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c1iqrUCF9LyTYH1oXCh9OKjrWulyRctctq30xI0cMNob4E9Iv1LDxHA8JkanddmFI BmbCa1jOzySWuLxCV5BSfEgAkQxBoXxPjuL0tsEEyckBavgTUVkvP0gQs7+7bJcdCR hpko1HZFFGG59hUoCVuR3PWDQd/dlaTb3JqoOF5U= From: Umang Jain <umang.jain@ideasonboard.com> To: linux-media@vger.kernel.org Cc: stable@vger.kernel.org, Kieran Bingham <kieran.bingham@ideasonboard.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Tommaso Merciai <tomm.merciai@gmail.com>, Jacopo Mondi <jacopo.mondi@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Umang Jain <umang.jain@ideasonboard.com> Subject: [PATCH v2 1/2] dt-bindings: imx335: Mention reset-gpio polarity Date: Mon, 29 Jul 2024 16:34:36 +0530 Message-ID: <20240729110437.199428-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240729110437.199428-1-umang.jain@ideasonboard.com> References: <20240729110437.199428-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-LSpam-Score: -2.6 (--) X-LSpam-Report: No, score=-2.6 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_MISSING=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no |
Series |
media: imx335: Fix reset-gpio handling
|
|
Commit Message
Umang Jain
July 29, 2024, 11:04 a.m. UTC
Mention the reset-gpio polarity in the device tree bindings.
It is GPIO_ACTIVE_LOW according to the datasheet.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Umang, Thank you for the patch. On Mon, Jul 29, 2024 at 04:34:36PM +0530, Umang Jain wrote: > Mention the reset-gpio polarity in the device tree bindings. > It is GPIO_ACTIVE_LOW according to the datasheet. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > index 106c36ee966d..fb4c9d42ed1c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > @@ -92,6 +92,8 @@ examples: > ovdd-supply = <&camera_vddo_1v8>; > dvdd-supply = <&camera_vddd_1v2>; > > + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>; > + I think it's good to include this in the example, but it doesn't match the commit message. I was expecting to see a change to the binding rules, not to the example. > port { > imx335: endpoint { > remote-endpoint = <&cam>;
Hi Laurent, On 29/07/24 4:40 pm, Laurent Pinchart wrote: > Hi Umang, > > Thank you for the patch. > > On Mon, Jul 29, 2024 at 04:34:36PM +0530, Umang Jain wrote: >> Mention the reset-gpio polarity in the device tree bindings. >> It is GPIO_ACTIVE_LOW according to the datasheet. >> >> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> >> --- >> Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml >> index 106c36ee966d..fb4c9d42ed1c 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml >> @@ -92,6 +92,8 @@ examples: >> ovdd-supply = <&camera_vddo_1v8>; >> dvdd-supply = <&camera_vddd_1v2>; >> >> + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>; >> + > I think it's good to include this in the example, but it doesn't match > the commit message. I was expecting to see a change to the binding > rules, not to the example. Currently the binding already states reset-gpio as ``` reset-gpios: description: Reference to the GPIO connected to the XCLR pin, if any. maxItems: 1 ``` Pardon my limited knowledge here, do you mean something like : ``` reset-gpios: description: Reference to the GPIO connected to the XCLR pin (active LOW), if any. maxItems: 1 ``` or something else? > >> port { >> imx335: endpoint { >> remote-endpoint = <&cam>;
On 29/07/2024 13:04, Umang Jain wrote: > Mention the reset-gpio polarity in the device tree bindings. > It is GPIO_ACTIVE_LOW according to the datasheet. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- IdeasOnBoard folks are seasoned developers, although I noticed from time to time you do not cc all necessary addresses. I wonder why? Something is missing in internal guideline? That's not the first case, but pasting same form letter is a bit annoying, especially considering that *tools tell you to do correct stuff* and you do not need *person to tell you that*. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
On Mon, Jul 29, 2024 at 04:08:18PM +0200, Krzysztof Kozlowski wrote: > On 29/07/2024 13:04, Umang Jain wrote: > > Mention the reset-gpio polarity in the device tree bindings. > > It is GPIO_ACTIVE_LOW according to the datasheet. > > > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > > --- > > IdeasOnBoard folks are seasoned developers, although I noticed from time > to time you do not cc all necessary addresses. I wonder why? Something > is missing in internal guideline? We have no guidelines that prevent CC'ing anyone, so it's down to case-by-case mistakes I suppose. get_maintainer.pl should have turned up the DT list and the DT maintainers on this patch. Umang (and everybody else), please make sure to not strip that in the future. > That's not the first case, but pasting same form letter is a bit > annoying, especially considering that *tools tell you to do correct > stuff* and you do not need *person to tell you that*. > > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. > </form letter>
Hi Umang, On Mon, Jul 29, 2024 at 05:36:11PM +0530, Umang Jain wrote: > On 29/07/24 4:40 pm, Laurent Pinchart wrote: > > On Mon, Jul 29, 2024 at 04:34:36PM +0530, Umang Jain wrote: > >> Mention the reset-gpio polarity in the device tree bindings. > >> It is GPIO_ACTIVE_LOW according to the datasheet. > >> > >> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > >> --- > >> Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > >> index 106c36ee966d..fb4c9d42ed1c 100644 > >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > >> @@ -92,6 +92,8 @@ examples: > >> ovdd-supply = <&camera_vddo_1v8>; > >> dvdd-supply = <&camera_vddd_1v2>; > >> > >> + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>; > >> + > > I think it's good to include this in the example, but it doesn't match > > the commit message. I was expecting to see a change to the binding > > rules, not to the example. > > Currently the binding already states reset-gpio as > > ``` > reset-gpios: > description: Reference to the GPIO connected to the XCLR pin, if any. > maxItems: 1 > ``` > > Pardon my limited knowledge here, do you mean something like : > > ``` > reset-gpios: > description: Reference to the GPIO connected to the XCLR pin > (active LOW), if any. > maxItems: 1 > ``` > > or something else? No, I meant updating the commit message to something like: dt-bindings: media: imx335: Add reset-gpios to the DT example It's easy to get the polarity of GPIOs in the device tree wrong, as shown by a recently fixed bug in the imx335 driver. To lower the chance of future mistakes, especially in new bindings that would take the imx335 binding as a starting point, add the reset-gpios property to the DT example. This showcases the correct polarity of the XCLR signal for Sony sensors in the most common case of the signal not being inverted on the board. > >> port { > >> imx335: endpoint { > >> remote-endpoint = <&cam>;
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml index 106c36ee966d..fb4c9d42ed1c 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml @@ -92,6 +92,8 @@ examples: ovdd-supply = <&camera_vddo_1v8>; dvdd-supply = <&camera_vddd_1v2>; + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>; + port { imx335: endpoint { remote-endpoint = <&cam>;