[v2] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

Message ID 20240412-sc7280-venus-bindings-v2-1-48ca8c2ec532@fairphone.com (mailing list archive)
State Accepted
Headers
Series [v2] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry |

Commit Message

Luca Weiss April 12, 2024, 2:19 p.m. UTC
  Some SC7280-based boards crash when providing the "secure_non_pixel"
context bank, so allow only one iommu in the bindings also.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Reference:
https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
---
Changes in v2:
- Pick up tags
- Otherwise just a resend, v1 was sent in January
- Link to v1: https://lore.kernel.org/r/20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com
---
 Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39
change-id: 20240129-sc7280-venus-bindings-6e62a99620de

Best regards,
  

Comments

Luca Weiss June 3, 2024, 6:39 a.m. UTC | #1
On Fri Apr 12, 2024 at 4:19 PM CEST, Luca Weiss wrote:
> Some SC7280-based boards crash when providing the "secure_non_pixel"
> context bank, so allow only one iommu in the bindings also.

Hi all,

This patch is still pending and not having it causes dt validation
warnings for some qcom-sc7280 boards.

Regards
Luca

>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Reference:
> https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
> ---
> Changes in v2:
> - Pick up tags
> - Otherwise just a resend, v1 was sent in January
> - Link to v1: https://lore.kernel.org/r/20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com
> ---
>  Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> index 8f9b6433aeb8..10c334e6b3dc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> @@ -43,6 +43,7 @@ properties:
>        - const: vcodec_bus
>  
>    iommus:
> +    minItems: 1
>      maxItems: 2
>  
>    interconnects:
>
> ---
> base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39
> change-id: 20240129-sc7280-venus-bindings-6e62a99620de
>
> Best regards,
  
Luca Weiss June 17, 2024, 7:28 a.m. UTC | #2
On Mon Jun 3, 2024 at 8:39 AM CEST, Luca Weiss wrote:
> On Fri Apr 12, 2024 at 4:19 PM CEST, Luca Weiss wrote:
> > Some SC7280-based boards crash when providing the "secure_non_pixel"
> > context bank, so allow only one iommu in the bindings also.
>
> Hi all,
>
> This patch is still pending and not having it causes dt validation
> warnings for some qcom-sc7280 boards.

Hi Rob,

Could you please pick up this patch? Mauro seems to ignore this patch
either on purpose or by accident and I'd like for this dtbs_check
failure to finally be fixed.

Regards
Luca

>
> Regards
> Luca
>
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> > Reference:
> > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
> > ---
> > Changes in v2:
> > - Pick up tags
> > - Otherwise just a resend, v1 was sent in January
> > - Link to v1: https://lore.kernel.org/r/20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com
> > ---
> >  Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > index 8f9b6433aeb8..10c334e6b3dc 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > @@ -43,6 +43,7 @@ properties:
> >        - const: vcodec_bus
> >  
> >    iommus:
> > +    minItems: 1
> >      maxItems: 2
> >  
> >    interconnects:
> >
> > ---
> > base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39
> > change-id: 20240129-sc7280-venus-bindings-6e62a99620de
> >
> > Best regards,
  
Luca Weiss Aug. 9, 2024, 8:22 a.m. UTC | #3
On Mon Jun 17, 2024 at 9:28 AM CEST, Luca Weiss wrote:
> On Mon Jun 3, 2024 at 8:39 AM CEST, Luca Weiss wrote:
> > On Fri Apr 12, 2024 at 4:19 PM CEST, Luca Weiss wrote:
> > > Some SC7280-based boards crash when providing the "secure_non_pixel"
> > > context bank, so allow only one iommu in the bindings also.
> >
> > Hi all,
> >
> > This patch is still pending and not having it causes dt validation
> > warnings for some qcom-sc7280 boards.
>
> Hi Rob,
>
> Could you please pick up this patch? Mauro seems to ignore this patch
> either on purpose or by accident and I'd like for this dtbs_check
> failure to finally be fixed.

Hi all,

Another month, another ping.

Can *anybody* please pick up this patch?

Regards
Luca

>
> Regards
> Luca
>
> >
> > Regards
> > Luca
> >
> > >
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > > ---
> > > Reference:
> > > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
> > > ---
> > > Changes in v2:
> > > - Pick up tags
> > > - Otherwise just a resend, v1 was sent in January
> > > - Link to v1: https://lore.kernel.org/r/20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com
> > > ---
> > >  Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > > index 8f9b6433aeb8..10c334e6b3dc 100644
> > > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > > @@ -43,6 +43,7 @@ properties:
> > >        - const: vcodec_bus
> > >  
> > >    iommus:
> > > +    minItems: 1
> > >      maxItems: 2
> > >  
> > >    interconnects:
> > >
> > > ---
> > > base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39
> > > change-id: 20240129-sc7280-venus-bindings-6e62a99620de
> > >
> > > Best regards,
  
Krzysztof Kozlowski Aug. 9, 2024, 9:17 a.m. UTC | #4
On 09/08/2024 10:22, Luca Weiss wrote:
> On Mon Jun 17, 2024 at 9:28 AM CEST, Luca Weiss wrote:
>> On Mon Jun 3, 2024 at 8:39 AM CEST, Luca Weiss wrote:
>>> On Fri Apr 12, 2024 at 4:19 PM CEST, Luca Weiss wrote:
>>>> Some SC7280-based boards crash when providing the "secure_non_pixel"
>>>> context bank, so allow only one iommu in the bindings also.
>>>
>>> Hi all,
>>>
>>> This patch is still pending and not having it causes dt validation
>>> warnings for some qcom-sc7280 boards.
>>
>> Hi Rob,
>>
>> Could you please pick up this patch? Mauro seems to ignore this patch
>> either on purpose or by accident and I'd like for this dtbs_check
>> failure to finally be fixed.
> 
> Hi all,
> 
> Another month, another ping.
> 
> Can *anybody* please pick up this patch?

Still in state "New" on media patchwork:
https://patchwork.linuxtv.org/project/linux-media/patch/20240412-sc7280-venus-bindings-v2-1-48ca8c2ec532@fairphone.com/

so it won't move. Please ping Rob on #devicetree channel once he comes
online.

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
index 8f9b6433aeb8..10c334e6b3dc 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
@@ -43,6 +43,7 @@  properties:
       - const: vcodec_bus
 
   iommus:
+    minItems: 1
     maxItems: 2
 
   interconnects: