diff mbox series

media: rcar-vin: Add support for R-Car V4M

Message ID 20240527132429.1683547-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State Superseded
Headers
Series media: rcar-vin: Add support for R-Car V4M |

Commit Message

Niklas Söderlund May 27, 2024, 1:24 p.m. UTC 
  Add support for R-Car V4M. The V4M uses the ISP Channel Selector as its
only possible video input source. Even tho V4M is not a Gen3 board the
VIN interface is very close to the one found on the V3U, for this reason
mark it as a Gen3 model internally.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/media/platform/renesas/rcar-vin/rcar-core.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Geert Uytterhoeven May 28, 2024, 6:53 a.m. UTC | #1 
Hi Niklas,

On Mon, May 27, 2024 at 3:24 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Add support for R-Car V4M. The V4M uses the ISP Channel Selector as its
> only possible video input source. Even tho V4M is not a Gen3 board the
> VIN interface is very close to the one found on the V3U, for this reason
> mark it as a Gen3 model internally.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -1292,6 +1292,15 @@ static const struct rvin_info rcar_info_r8a779g0 = {
>         .max_height = 4096,
>  };
>
> +static const struct rvin_info rcar_info_r8a779h0 = {
> +       .model = RCAR_GEN3,
> +       .use_mc = true,
> +       .use_isp = true,
> +       .nv12 = true,
> +       .max_width = 4096,
> +       .max_height = 4096,
> +};

Unless I misread, this structure is identical to the existing rcar_info_r8a779a0
and rcar_info_r8a779g0 structures? Perhaps deduplicate and rename
to rcar_info_gen4?

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
index 809c3a38cc4a..a7a36cfaae81 100644
--- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
@@ -1292,6 +1292,15 @@  static const struct rvin_info rcar_info_r8a779g0 = {
 	.max_height = 4096,
 };
 
+static const struct rvin_info rcar_info_r8a779h0 = {
+	.model = RCAR_GEN3,
+	.use_mc = true,
+	.use_isp = true,
+	.nv12 = true,
+	.max_width = 4096,
+	.max_height = 4096,
+};
+
 static const struct of_device_id rvin_of_id_table[] = {
 	{
 		.compatible = "renesas,vin-r8a774a1",
@@ -1361,6 +1370,10 @@  static const struct of_device_id rvin_of_id_table[] = {
 		.compatible = "renesas,vin-r8a779g0",
 		.data = &rcar_info_r8a779g0,
 	},
+	{
+		.compatible = "renesas,vin-r8a779h0",
+		.data = &rcar_info_r8a779h0,
+	},
 	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, rvin_of_id_table);