Message ID | 20240403150355.189229-19-git@luigi311.com (mailing list archive) |
---|---|
State | Superseded |
Headers |
Received: from sv.mirrors.kernel.org ([139.178.88.99]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-8541-patchwork=linuxtv.org@vger.kernel.org>) id 1rs2HS-00046w-1Q for patchwork@linuxtv.org; Wed, 03 Apr 2024 15:12:03 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EE919287EA5 for <patchwork@linuxtv.org>; Wed, 3 Apr 2024 15:12:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0401B14F9E8; Wed, 3 Apr 2024 15:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="sLN+JxGH" X-Original-To: linux-media@vger.kernel.org Received: from mail-108-mta19.mxroute.com (mail-108-mta19.mxroute.com [136.175.108.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0975E14F131 for <linux-media@vger.kernel.org>; Wed, 3 Apr 2024 15:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712156946; cv=none; b=SLK/0JIdx6poo6quX0cZx05vZklZe3l4Wd4SKDxjDwV6XfDbGG6FsDDNp/77ymM1+dkJFShXksxcCtxlJvExD605Z2shNHmdBTMJlDKqmc7XpjQHnSqZhO21+EtyTrghAuTVywKaxHhZtzd9vVd7fhECZf+NMWFsgfhsdv26GSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712156946; c=relaxed/simple; bh=l7ZJgU2OQZ8hIYhOK6BqKGPyRov+21qL9H0o+ttP/0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=slvTEnt5WxB6qrzjB7CaLURD5yR5SmvFCDOIpnQsycmqJvn24LvuISaOHEemgA52xZtgo6HConDUuRsgfipAGT3Cw9Zz7REKRMYwI5pbZBN7CvwV48hYLxbZNvbhinY6Nz4x4qSSaPjHTI8W32bXjdrgveapL8hkb/qTTo4j8wo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=sLN+JxGH; arc=none smtp.client-ip=136.175.108.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta19.mxroute.com (ZoneMTA) with ESMTPSA id 18ea4809a4f0003bea.011 for <linux-media@vger.kernel.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 03 Apr 2024 15:07:55 +0000 X-Zone-Loop: e6a079b0e1e92dce8f15418e584d501ba35d9ac4e58b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tkOp5AZhPgUJMKkKNZfkvyskppT+Gp5qCGVEQtkqhtE=; b=sLN+JxGHH4IkDSuiuiqOtDzN7N TN50mgHlg+tyxehFX8J0iU3hBf5dxSsxkKcDN29daJvKZXf7I12Saq/c+pZ+9o0Fahy8fzFD+xEU3 s+0H99mnZH1xhcSk+P9PFExtqaMA0XoNlAhhg0zSE7Nyq8sYZJeWFBugj19R4Xses59V5Z6bG2nfT Ct0DFY2CMkt/DT0Qb72ijCUK57wR+TIUAYgnRHP6QzKI0suB1xMMyEBGo0RXgjySE9PEOo79cToR6 0d8msq8GRKEpWZLrBSp3UvvAMTo8CBYdB7DApHyXm2Et0a+C+QrdCnoEsHZhX5ZchCDgTG75Fi3dN I9xS/EHg==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Luis Garcia <git@luigi311.com> Subject: [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings Date: Wed, 3 Apr 2024 09:03:47 -0600 Message-ID: <20240403150355.189229-19-git@luigi311.com> In-Reply-To: <20240403150355.189229-1-git@luigi311.com> References: <20240403150355.189229-1-git@luigi311.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: personal@luigi311.com X-LSpam-Score: -4.6 (----) X-LSpam-Report: No, score=-4.6 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_INVALID=0.1,DKIM_SIGNED=0.1,DMARC_MISSING=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no |
Series |
imx258 improvement series
|
|
Commit Message
Luis Garcia
April 3, 2024, 3:03 p.m. UTC
From: Dave Stevenson <dave.stevenson@raspberrypi.com> There are a number of variants of the imx258 modules that can not be differentiated at runtime, so add compatible strings for the PDAF variant. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Luis Garcia <git@luigi311.com> --- .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Comments
On Wed, Apr 03, 2024 at 09:03:47AM -0600, git@luigi311.com wrote: > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for the > PDAF variant. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Luis Garcia <git@luigi311.com> > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index bee61a443b23..c978abc0cdb3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -13,11 +13,16 @@ description: |- > IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > type stacked image sensor with a square pixel array of size 4208 x 3120. It > is programmable through I2C interface. Image data is sent through MIPI > - CSI-2. > + CSI-2. The sensor exists in two different models, a standard variant > + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). > + The camera module does not expose the model through registers, so the > + exact model needs to be specified. > > properties: > compatible: > - const: sony,imx258 > + enum: > + - sony,imx258 > + - sony,imx258-pdaf Does the pdaf variant support all of the features/is it register compatible with the regular variant? If it is, the regular variant should be a fallback compatible. Cheers, Conor.
Hi Conor On Wed, 3 Apr 2024 at 17:14, Conor Dooley <conor@kernel.org> wrote: > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, git@luigi311.com wrote: > > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > > There are a number of variants of the imx258 modules that can not > > be differentiated at runtime, so add compatible strings for the > > PDAF variant. > > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Signed-off-by: Luis Garcia <git@luigi311.com> > > --- > > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > index bee61a443b23..c978abc0cdb3 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > @@ -13,11 +13,16 @@ description: |- > > IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > > type stacked image sensor with a square pixel array of size 4208 x 3120. It > > is programmable through I2C interface. Image data is sent through MIPI > > - CSI-2. > > + CSI-2. The sensor exists in two different models, a standard variant > > + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). > > + The camera module does not expose the model through registers, so the > > + exact model needs to be specified. > > > > properties: > > compatible: > > - const: sony,imx258 > > + enum: > > + - sony,imx258 > > + - sony,imx258-pdaf > > Does the pdaf variant support all of the features/is it register > compatible with the regular variant? If it is, the regular variant > should be a fallback compatible. It has the same register set, but certain registers have to be programmed differently so that the image is corrected for the partially shielded pixels used for phase detect auto focus (PDAF). Either compatible will "work" on either variant of the module, but you'll get weird image artifacts when using the wrong one. Dave > Cheers, > Conor.
On Fri, Apr 05, 2024 at 11:25:50AM +0100, Dave Stevenson wrote: > Hi Conor > > On Wed, 3 Apr 2024 at 17:14, Conor Dooley <conor@kernel.org> wrote: > > > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, git@luigi311.com wrote: > > > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > > > > There are a number of variants of the imx258 modules that can not > > > be differentiated at runtime, so add compatible strings for the > > > PDAF variant. > > > > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > Signed-off-by: Luis Garcia <git@luigi311.com> > > > --- > > > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > index bee61a443b23..c978abc0cdb3 100644 > > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > @@ -13,11 +13,16 @@ description: |- > > > IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > > > type stacked image sensor with a square pixel array of size 4208 x 3120. It > > > is programmable through I2C interface. Image data is sent through MIPI > > > - CSI-2. > > > + CSI-2. The sensor exists in two different models, a standard variant > > > + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). > > > + The camera module does not expose the model through registers, so the > > > + exact model needs to be specified. > > > > > > properties: > > > compatible: > > > - const: sony,imx258 > > > + enum: > > > + - sony,imx258 > > > + - sony,imx258-pdaf > > > > Does the pdaf variant support all of the features/is it register > > compatible with the regular variant? If it is, the regular variant > > should be a fallback compatible. > > It has the same register set, but certain registers have to be > programmed differently so that the image is corrected for the > partially shielded pixels used for phase detect auto focus (PDAF). > Either compatible will "work" on either variant of the module, but > you'll get weird image artifacts when using the wrong one. To paraphase, a fallback compatible is not suitable. Thanks Dave, Conor.
On Fri, Apr 05, 2024 at 05:24:11PM +0100, Conor Dooley wrote: > On Fri, Apr 05, 2024 at 11:25:50AM +0100, Dave Stevenson wrote: > > Hi Conor > > > > On Wed, 3 Apr 2024 at 17:14, Conor Dooley <conor@kernel.org> wrote: > > > > > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, git@luigi311.com wrote: > > > > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > > > > > > There are a number of variants of the imx258 modules that can not > > > > be differentiated at runtime, so add compatible strings for the > > > > PDAF variant. > > > > > > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > > Signed-off-by: Luis Garcia <git@luigi311.com> > > > > --- > > > > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- > > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > > index bee61a443b23..c978abc0cdb3 100644 > > > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > > @@ -13,11 +13,16 @@ description: |- > > > > IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > > > > type stacked image sensor with a square pixel array of size 4208 x 3120. It > > > > is programmable through I2C interface. Image data is sent through MIPI > > > > - CSI-2. > > > > + CSI-2. The sensor exists in two different models, a standard variant > > > > + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). > > > > + The camera module does not expose the model through registers, so the > > > > + exact model needs to be specified. > > > > > > > > properties: > > > > compatible: > > > > - const: sony,imx258 > > > > + enum: > > > > + - sony,imx258 > > > > + - sony,imx258-pdaf > > > > > > Does the pdaf variant support all of the features/is it register > > > compatible with the regular variant? If it is, the regular variant > > > should be a fallback compatible. > > > > It has the same register set, but certain registers have to be > > programmed differently so that the image is corrected for the > > partially shielded pixels used for phase detect auto focus (PDAF). > > Either compatible will "work" on either variant of the module, but > > you'll get weird image artifacts when using the wrong one. > > To paraphase, a fallback compatible is not suitable. Whoops, I forgot this: Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On Wed, 03 Apr 2024 09:03:47 -0600, git@luigi311.com wrote: > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for the > PDAF variant. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Luis Garcia <git@luigi311.com> > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml index bee61a443b23..c978abc0cdb3 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml @@ -13,11 +13,16 @@ description: |- IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel type stacked image sensor with a square pixel array of size 4208 x 3120. It is programmable through I2C interface. Image data is sent through MIPI - CSI-2. + CSI-2. The sensor exists in two different models, a standard variant + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). + The camera module does not expose the model through registers, so the + exact model needs to be specified. properties: compatible: - const: sony,imx258 + enum: + - sony,imx258 + - sony,imx258-pdaf assigned-clocks: true assigned-clock-parents: true