Message ID | 201107040043.00393@orion.escape-edv.de (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Sun, 03 Jul 2011 19:45:26 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1QdVPp-0005E7-Md for mchehab@pedra; Sun, 03 Jul 2011 19:45:26 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Sun, 03 Jul 2011 19:45:25 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QdVO9-0003u3-Hw; Sun, 03 Jul 2011 22:43:41 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057Ab1GCWn1 (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Sun, 3 Jul 2011 18:43:27 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:47033 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751416Ab1GCWn0 (ORCPT <rfc822; linux-media@vger.kernel.org>); Sun, 3 Jul 2011 18:43:26 -0400 Received: (qmail invoked by alias); 03 Jul 2011 22:43:24 -0000 Received: from p5DE56A4E.dip.t-dialin.net (HELO charon.escape-edv.de) [93.229.106.78] by mail.gmx.net (mp015) with SMTP; 04 Jul 2011 00:43:24 +0200 X-Authenticated: #476490 X-Provags-ID: V01U2FsdGVkX18Baphs2woBvqc5LeYUV2H2VT1pQzseoMiTQrxwei y3BJP2L4+BpSnM Received: from orion.escape-edv.de (192.168.1.10) by charon.escape-edv.de (192.168.1.9) with esmtp ; Mon, 04 Jul 2011 00:45:43 +0200 From: Oliver Endriss <o.endriss@gmx.de> Organization: ESCAPE GmbH EDV-Loesungen To: "Linux Media Mailing List" <linux-media@vger.kernel.org> Subject: Re: [DVB] TT S-1500b tuning issue Date: Mon, 4 Jul 2011 00:42:59 +0200 User-Agent: KMail/1.9.6 Cc: =?iso-8859-1?q?S=E9bastien_RAILLARD?= (COEXSI) <sr@coexsi.fr>, Malcolm Priestley <tvboxspy@gmail.com> References: <00a301cc365e$b6d415c0$247c4140$@coexsi.fr> In-Reply-To: <00a301cc365e$b6d415c0$247c4140$@coexsi.fr> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_0BPEONZYsCeMZ15" Message-Id: <201107040043.00393@orion.escape-edv.de> X-Y-GMX-Trusted: 0 Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Oliver Endriss
July 3, 2011, 10:42 p.m. UTC
On Wednesday 29 June 2011 15:16:10 Sébastien RAILLARD wrote: > Dear all, > > We have found what seems to be a tuning issue in the driver for the ALPS > BSBE1-D01A used in the new TT-S-1500b card from Technotrend. > On some transponders, like ASTRA 19.2E 11817-V-27500, the card can work very > well (no lock issues) for hours. > > On some other transponders, like ASTRA 19.2E 11567-V-22000, the card nearly > never manage to get the lock: it's looking like the signal isn't good > enough. Afaics the problem is caused by the tuning loop for (tm = -6; tm < 7;) in stv0288_set_frontend(). I doubt that this code works reliably. Apparently it never obtains a lock within the given delay (30us). Could you please try the attached patch? It disables the loop and tries to tune to the center frequency. CU Oliver
Comments
> -----Original Message----- > From: Oliver Endriss [mailto:o.endriss@gmx.de] > Sent: lundi 4 juillet 2011 00:43 > To: Linux Media Mailing List > Cc: Sébastien RAILLARD (COEXSI); Malcolm Priestley > Subject: Re: [DVB] TT S-1500b tuning issue > > On Wednesday 29 June 2011 15:16:10 Sébastien RAILLARD wrote: > > Dear all, > > > > We have found what seems to be a tuning issue in the driver for the > > ALPS BSBE1-D01A used in the new TT-S-1500b card from Technotrend. > > On some transponders, like ASTRA 19.2E 11817-V-27500, the card can > > work very well (no lock issues) for hours. > > > > On some other transponders, like ASTRA 19.2E 11567-V-22000, the card > > nearly never manage to get the lock: it's looking like the signal > > isn't good enough. > > Afaics the problem is caused by the tuning loop > for (tm = -6; tm < 7;) > in stv0288_set_frontend(). > > I doubt that this code works reliably. > Apparently it never obtains a lock within the given delay (30us). > > Could you please try the attached patch? > It disables the loop and tries to tune to the center frequency. > Ok, I've tested this patch with ASTRA 19.2 #24 transponder that wasn't always working: it seems to work. I think it would be great to test it for few days more to be sure. > CU > Oliver > > -- > ---------------------------------------------------------------- > VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ > 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ > Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ > ---------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2011-07-06 at 13:34 +0200, Sébastien RAILLARD (COEXSI) wrote: > > > -----Original Message----- > > From: Oliver Endriss [mailto:o.endriss@gmx.de] > > Sent: lundi 4 juillet 2011 00:43 > > To: Linux Media Mailing List > > Cc: Sébastien RAILLARD (COEXSI); Malcolm Priestley > > Subject: Re: [DVB] TT S-1500b tuning issue > > > > On Wednesday 29 June 2011 15:16:10 Sébastien RAILLARD wrote: > > > Dear all, > > > > > > We have found what seems to be a tuning issue in the driver for the > > > ALPS BSBE1-D01A used in the new TT-S-1500b card from Technotrend. > > > On some transponders, like ASTRA 19.2E 11817-V-27500, the card can > > > work very well (no lock issues) for hours. > > > > > > On some other transponders, like ASTRA 19.2E 11567-V-22000, the card > > > nearly never manage to get the lock: it's looking like the signal > > > isn't good enough. > > > > Afaics the problem is caused by the tuning loop > > for (tm = -6; tm < 7;) > > in stv0288_set_frontend(). > > > > I doubt that this code works reliably. > > Apparently it never obtains a lock within the given delay (30us). It's actually quite slow caused by any delay in the I2C bus. I doubt given the age many controllers run at the 400kHz spec, if barely 100kHz. > > > > Could you please try the attached patch? > > It disables the loop and tries to tune to the center frequency. > > > > Ok, I've tested this patch with ASTRA 19.2 #24 transponder that wasn't > always working: it seems to work. > I think it would be great to test it for few days more to be sure. Unfortunately, this patch does not work well at all. All that is happening is that the carrier offset is getting forced to 0, after it has been updated by the lock control register losing a 'good' lock. The value is typically around ~f800+. Perhaps the loop should be knocked down slightly to -9. The loop was probably intended for 22000 symbol rate. tvboxspy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb/frontends/stv0288.c b/drivers/media/dvb/frontends/stv0288.c index 8e0cfad..4ffe7da 100644 --- a/drivers/media/dvb/frontends/stv0288.c +++ b/drivers/media/dvb/frontends/stv0288.c @@ -488,6 +488,10 @@ static int stv0288_set_frontend(struct dvb_frontend *fe, /* Carrier lock control register */ stv0288_writeregI(state, 0x15, 0xc5); +#if 1 /* TEST */ + stv0288_writeregI(state, 0x2b, 0); + stv0288_writeregI(state, 0x2c, 0); +#else tda[0] = 0x2b; /* CFRM */ tda[2] = 0x0; /* CFRL */ for (tm = -6; tm < 7;) { @@ -503,6 +507,7 @@ static int stv0288_set_frontend(struct dvb_frontend *fe, stv0288_writeregI(state, 0x2c, tda[2]); udelay(30); } +#endif state->tuner_frequency = c->frequency; state->fec_inner = FEC_AUTO;