[v3,2/5] dt-bindings: media: Add bindings for ARM mali-c55
Commit Message
Add the yaml binding for ARM's Mali-C55 Image Signal Processor.
Acked-by: Nayden Kanchev <nayden.kanchev@arm.com>
Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
---
Changes in v3:
- Dropped the video clock as suggested by Laurent. I didn't retain it
for the purposes of the refcount since this driver will call .s_stream()
for the sensor driver which will refcount the clock anyway.
- Clarified that the port is a parallel input port rather (Sakari)
Changes in v2:
- Added clocks information
- Fixed the warnings raised by Rob
.../bindings/media/arm,mali-c55.yaml | 76 +++++++++++++++++++
1 file changed, 76 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml
Comments
On 05/03/2024 17:48, Daniel Scally wrote:
> Add the yaml binding for ARM's Mali-C55 Image Signal Processor.
>
> Acked-by: Nayden Kanchev <nayden.kanchev@arm.com>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
...
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Input parallel video bus
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/properties/endpoint
How many ports do you have here? If only one, why this isn't just a
'port' instead of 'ports'?
Best regards,
Krzysztof
Morning Krzysztof
On 06/03/2024 07:36, Krzysztof Kozlowski wrote:
> On 05/03/2024 17:48, Daniel Scally wrote:
>> Add the yaml binding for ARM's Mali-C55 Image Signal Processor.
>>
>> Acked-by: Nayden Kanchev <nayden.kanchev@arm.com>
>> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
>> ---
> ...
>
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Input parallel video bus
>> +
>> + properties:
>> + endpoint:
>> + $ref: /schemas/graph.yaml#/properties/endpoint
> How many ports do you have here? If only one, why this isn't just a
> 'port' instead of 'ports'?
Just one port; I had forgotten ports as a container was optional - I'll switch to just port, thanks.
>
> Best regards,
> Krzysztof
>
new file mode 100644
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM Mali-C55 Image Signal Processor
+
+maintainers:
+ - Daniel Scally <dan.scally@ideasonboard.com>
+ - Jacopo Mondi <jacopo.mondi@ideasonboard.com>
+
+properties:
+ compatible:
+ const: arm,mali-c55
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: ISP AXI clock
+ - description: ISP AHB-lite clock
+
+ clock-names:
+ items:
+ - const: aclk
+ - const: hclk
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Input parallel video bus
+
+ properties:
+ endpoint:
+ $ref: /schemas/graph.yaml#/properties/endpoint
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+ mali_c55: isp@400000 {
+ compatible = "arm,mali-c55";
+ reg = <0x400000 0x200000>;
+ clocks = <&clk 0>, <&clk 1>;
+ clock-names = "aclk", "hclk";
+ interrupts = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ isp_in: endpoint {
+ remote-endpoint = <&csi2_rx_out>;
+ };
+ };
+ };
+ };
+...