Message ID | 20240304180331.1200827-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Sean Young |
Headers |
Received: from ny.mirrors.kernel.org ([147.75.199.223]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-6372-patchwork=linuxtv.org@vger.kernel.org>) id 1rhCfI-0000DC-04 for patchwork@linuxtv.org; Mon, 04 Mar 2024 18:03:53 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A98041C23295 for <patchwork@linuxtv.org>; Mon, 4 Mar 2024 18:03:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F3DD62148; Mon, 4 Mar 2024 18:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NJfQquTb" X-Original-To: linux-media@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A09491756D; Mon, 4 Mar 2024 18:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709575419; cv=none; b=EjBnaYIuLrajsU5mGse6JpmYQXtKp71OWLX8AYS9wF9kXr/VAhJROexuM8j7AsW8l9BUAUpHzLR1L0PeCq+fwPBhygu2sDyPwGd7QeSC7W6qzSL++ZnPRniHcInp2D4nA/rICmx0D31eXq47kPmr/IFNCiAxkjpVlagrGbcx5DM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709575419; c=relaxed/simple; bh=Edx58ysToP3FaFY7mxr4Ae/EJX6jGWhbuK1l41l1MGY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qa2SAtbxLDmJZDrVSqBs5gKtEGPaZTSMNrldeQElRbr5qAcSFd++mccvjbpm8X1SM2whDA+yWcJvP4byLz73qym+BZF9gveDk2IbgxnrVSqYjgkIdeR6xH13AeZFwXm5g+w56esGgKOSso3jkCo29v+RWHdMZFH6Kq3gVdZmL3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NJfQquTb; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709575418; x=1741111418; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Edx58ysToP3FaFY7mxr4Ae/EJX6jGWhbuK1l41l1MGY=; b=NJfQquTbR5tZVx2NfXbUIQpm4m4iG+mZ8RRE/t9KG85FaiOFf2KiMr9d sWiTjPpDRCnvQNOg/u3kYhwff0clWvlSBG/ZW+Ol3FblrZst1blca0d5d PYBcdS4fPoGG5+yT/XHf24S50YFzUmbJnyJfP8oYNhmO6bG01/obO6/Oj rK2B4I2dJMmUWnxmQnH7y3Po+B4M+5Q+0RQNsbHAyJgSauCSyofz2cEdu cZmbOwxlicKUuKQ8RU7tuMq0wvLGRE/ABw2WAokU+af5ruZJMWWNKlfJc O8nl/GndzhyDTR0wUItjpDDegFugsQSKGuiG8oT+IDGAFruy7yIV37B+6 g==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="7854931" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="7854931" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 10:03:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="937040915" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="937040915" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 04 Mar 2024 10:03:33 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0607415C; Mon, 4 Mar 2024 20:03:32 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sean Young <sean@mess.org>, Mauro Carvalho Chehab <mchehab@kernel.org> Subject: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h Date: Mon, 4 Mar 2024 20:03:31 +0200 Message-ID: <20240304180331.1200827-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-LSpam-Score: -2.3 (--) X-LSpam-Report: No, score=-2.3 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,DKIMWL_WL_HIGH=-1,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_LOW=-0.7,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no |
Series |
[v1,1/1] media: ir-spi: Remove unused of_gpio.h
|
|
Commit Message
Andy Shevchenko
March 4, 2024, 6:03 p.m. UTC
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/rc/ir-spi.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote: > of_gpio.h is deprecated and subject to remove. > The driver doesn't use it, simply remove the unused header. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/media/rc/ir-spi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c > index bbc81bed4f90..8afc3cd70b87 100644 > --- a/drivers/media/rc/ir-spi.c > +++ b/drivers/media/rc/ir-spi.c > @@ -8,7 +8,6 @@ > #include <linux/fs.h> > #include <linux/module.h> > #include <linux/mutex.h> > -#include <linux/of_gpio.h> This does not build, I get errors saying of_property_read_bool() is undefined. I think we need linux/of.h instead of linux/of_gpio.h. Sean > #include <linux/regulator/consumer.h> > #include <linux/spi/spi.h> > #include <media/rc-core.h> > -- > 2.43.0.rc1.1.gbec44491f096
On Tue, Mar 05, 2024 at 09:15:28AM +0000, Sean Young wrote: > On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote: ... > > -#include <linux/of_gpio.h> > > This does not build, I get errors saying of_property_read_bool() is undefined. > I think we need linux/of.h instead of linux/of_gpio.h. Oh, good catch! The header block there is a mess. I will replace this patch by something better, I'll Cc you.
diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c index bbc81bed4f90..8afc3cd70b87 100644 --- a/drivers/media/rc/ir-spi.c +++ b/drivers/media/rc/ir-spi.c @@ -8,7 +8,6 @@ #include <linux/fs.h> #include <linux/module.h> #include <linux/mutex.h> -#include <linux/of_gpio.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> #include <media/rc-core.h>