media: dt-bindings: st-vgxy61: relax data-lanes restriction

Message ID 20231213071737.1070162-1-julien.massot@collabora.com (mailing list archive)
State Changes Requested
Delegated to: Sakari Ailus
Headers
Series media: dt-bindings: st-vgxy61: relax data-lanes restriction |

Commit Message

Julien Massot Dec. 13, 2023, 7:17 a.m. UTC
  The ST VGXY61 sensors support multiple lane number, as
well as lane mapping.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml        | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
  

Comments

Conor Dooley Dec. 13, 2023, 4:30 p.m. UTC | #1
On Wed, Dec 13, 2023 at 08:17:37AM +0100, Julien Massot wrote:
> The ST VGXY61 sensors support multiple lane number, as
> well as lane mapping.
> 
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
>  .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml        | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> index 8c28848b226a..733fac85a20f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> @@ -67,11 +67,8 @@ properties:
>            data-lanes:
>              description:
>                CSI lanes to use
> -            items:
> -              - const: 1
> -              - const: 2
> -              - const: 3
> -              - const: 4
> +            minItems: 1
> +            maxItems: 4

So, it is now valid to have "data-lanes = <6 7 8>;" now?
  
Julien Massot Jan. 5, 2024, 9:36 a.m. UTC | #2
Hi,

On 12/13/23 17:30, Conor Dooley wrote:
> On Wed, Dec 13, 2023 at 08:17:37AM +0100, Julien Massot wrote:
>> The ST VGXY61 sensors support multiple lane number, as
>> well as lane mapping.
>>
>> Signed-off-by: Julien Massot <julien.massot@collabora.com>
>> ---
>>   .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml        | 7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> index 8c28848b226a..733fac85a20f 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> @@ -67,11 +67,8 @@ properties:
>>             data-lanes:
>>               description:
>>                 CSI lanes to use
>> -            items:
>> -              - const: 1
>> -              - const: 2
>> -              - const: 3
>> -              - const: 4
>> +            minItems: 1
>> +            maxItems: 4
> 
> So, it is now valid to have "data-lanes = <6 7 8>;" now?

Indeed it's not valid, I will send a v2 with a 'minimum: 1', 'maximum: 
4' items properties.

Thanks,
  
Benjamin Mugnier Feb. 9, 2024, 9:24 a.m. UTC | #3
Hi Julien,

On 1/5/24 10:36, Julien Massot wrote:
> Hi,
> 
> On 12/13/23 17:30, Conor Dooley wrote:
>> On Wed, Dec 13, 2023 at 08:17:37AM +0100, Julien Massot wrote:
>>> The ST VGXY61 sensors support multiple lane number, as
>>> well as lane mapping.
>>>
>>> Signed-off-by: Julien Massot <julien.massot@collabora.com>
>>> ---
>>>   .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml        | 7 ++-----
>>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>> b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>> index 8c28848b226a..733fac85a20f 100644
>>> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>> @@ -67,11 +67,8 @@ properties:
>>>             data-lanes:
>>>               description:
>>>                 CSI lanes to use
>>> -            items:
>>> -              - const: 1
>>> -              - const: 2
>>> -              - const: 3
>>> -              - const: 4
>>> +            minItems: 1
>>> +            maxItems: 4
>>
>> So, it is now valid to have "data-lanes = <6 7 8>;" now?
> 
> Indeed it's not valid, I will send a v2 with a 'minimum: 1', 'maximum:
> 4' items properties.

I'm interested in this patch. Did you send a v2 yet that I might have
missed ?
Thank you.

> 
> Thanks,
  
Julien Massot March 15, 2024, 9:06 a.m. UTC | #4
Hi Benjamin,

On 2/9/24 10:24, Benjamin Mugnier wrote:
> Hi Julien,
> 
> On 1/5/24 10:36, Julien Massot wrote:
>> Hi,
>>
>> On 12/13/23 17:30, Conor Dooley wrote:
>>> On Wed, Dec 13, 2023 at 08:17:37AM +0100, Julien Massot wrote:
>>>> The ST VGXY61 sensors support multiple lane number, as
>>>> well as lane mapping.
>>>>
>>>> Signed-off-by: Julien Massot <julien.massot@collabora.com>
>>>> ---
>>>>    .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml        | 7 ++-----
>>>>    1 file changed, 2 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>>> b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>>> index 8c28848b226a..733fac85a20f 100644
>>>> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>>> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>>>> @@ -67,11 +67,8 @@ properties:
>>>>              data-lanes:
>>>>                description:
>>>>                  CSI lanes to use
>>>> -            items:
>>>> -              - const: 1
>>>> -              - const: 2
>>>> -              - const: 3
>>>> -              - const: 4
>>>> +            minItems: 1
>>>> +            maxItems: 4
>>>
>>> So, it is now valid to have "data-lanes = <6 7 8>;" now?
>>
>> Indeed it's not valid, I will send a v2 with a 'minimum: 1', 'maximum:
>> 4' items properties.
> 
> I'm interested in this patch. Did you send a v2 yet that I might have
> missed ?
> Thank you.

I just sent a v2, which add minimum/maximum so that we can only use 
index 1..4.

Regards,
Julien
  

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
index 8c28848b226a..733fac85a20f 100644
--- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
@@ -67,11 +67,8 @@  properties:
           data-lanes:
             description:
               CSI lanes to use
-            items:
-              - const: 1
-              - const: 2
-              - const: 3
-              - const: 4
+            minItems: 1
+            maxItems: 4
 
           remote-endpoint: true