Message ID | 20231220103713.113386-22-sakari.ailus@linux.intel.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Sakari Ailus |
Headers |
Received: from sv.mirrors.kernel.org ([139.178.88.99]) by www.linuxtv.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <linux-media+bounces-2782-patchwork=linuxtv.org@vger.kernel.org>) id 1rFtyS-00H4FH-JS for patchwork@linuxtv.org; Wed, 20 Dec 2023 10:38:49 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 09928288AE6 for <patchwork@linuxtv.org>; Wed, 20 Dec 2023 10:38:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A8E420B0F; Wed, 20 Dec 2023 10:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WG/VJPVz" X-Original-To: linux-media@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F07C219EA for <linux-media@vger.kernel.org>; Wed, 20 Dec 2023 10:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703068651; x=1734604651; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Mwzvb1h3V5fruDOZoYDmhDZh8/drmi6Hc+Wqgrki4lk=; b=WG/VJPVzG5+ZGKCFhOC7CukFtQI+ROqZ0Fk0xmKRQhj+Q29+nHJndBKq JlEhFWvm+8o6iznKeyDw/99mmEQH1xsjQlSAZv5NtU3RlE1lNU/lLua2t LXpREzGs+Y/bI4lU6vY+zHo7sYEZRXzPOMI1jdJ6bC9n0z2M0o6wlpSdk sMQqhtTlYj0iFU5JbZsZSowXQNqhW9ekKC5YOd8gkFbGrsnnkPILWP6/E Lp/P0myckh05CgGim13MwA96/1MNzKuBnitiE1hgOOGGgmcaVYVQVFEJj /F4EJZKtxrP+pQvrLTb8nWseqHzvPjSHBDIGslS3FHg2HpVSvjoZgfy52 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="9174383" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="9174383" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 02:37:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="769544272" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="769544272" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 02:37:30 -0800 Received: from svinhufvud.ger.corp.intel.com (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 509F311FB5E; Wed, 20 Dec 2023 12:37:27 +0200 (EET) From: Sakari Ailus <sakari.ailus@linux.intel.com> To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, Hans Verkuil <hverkuil-cisco@xs4all.nl> Subject: [PATCH v2 21/29] media: ipu3-cio2: Request IRQ earlier Date: Wed, 20 Dec 2023 12:37:05 +0200 Message-Id: <20231220103713.113386-22-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231220103713.113386-1-sakari.ailus@linux.intel.com> References: <20231220103713.113386-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-LSpam-Score: -4.7 (----) X-LSpam-Report: No, score=-4.7 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=unavailable autolearn_force=no |
Series |
Media device lifetime management
|
|
Commit Message
Sakari Ailus
Dec. 20, 2023, 10:37 a.m. UTC
Call devm_request_irq() before registering the async notifier, as otherwise
it would be possible to use the device before the interrupts could be
deliveted to the driver.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Comments
On 20/12/2023 11:37, Sakari Ailus wrote: > Call devm_request_irq() before registering the async notifier, as otherwise > it would be possible to use the device before the interrupts could be > deliveted to the driver. deliveted -> delivered Isn't this a regular fix? Ditto for the previous patch (20/29). I'd just queue this up in the next PR. Regards, Hans > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index da82d09b46ab..3222ec5b8345 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1789,11 +1789,6 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, > > v4l2_async_nf_init(&cio2->notifier, &cio2->v4l2_dev); > > - /* Register notifier for subdevices we care */ > - r = cio2_parse_firmware(cio2); > - if (r) > - goto fail_clean_notifier; > - > r = devm_request_irq(dev, pci_dev->irq, cio2_irq, IRQF_SHARED, > CIO2_NAME, cio2); > if (r) { > @@ -1801,6 +1796,11 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, > goto fail_clean_notifier; > } > > + /* Register notifier for subdevices we care */ > + r = cio2_parse_firmware(cio2); > + if (r) > + goto fail_clean_notifier; > + > pm_runtime_put_noidle(dev); > pm_runtime_allow(dev); >
On Mon, Feb 05, 2024 at 03:58:45PM +0100, Hans Verkuil wrote: > On 20/12/2023 11:37, Sakari Ailus wrote: > > Call devm_request_irq() before registering the async notifier, as otherwise > > it would be possible to use the device before the interrupts could be > > deliveted to the driver. > > deliveted -> delivered > > Isn't this a regular fix? Ditto for the previous patch (20/29). > > I'd just queue this up in the next PR. Fixes: tags would then be nice. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > --- > > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > index da82d09b46ab..3222ec5b8345 100644 > > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > @@ -1789,11 +1789,6 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, > > > > v4l2_async_nf_init(&cio2->notifier, &cio2->v4l2_dev); > > > > - /* Register notifier for subdevices we care */ > > - r = cio2_parse_firmware(cio2); > > - if (r) > > - goto fail_clean_notifier; > > - > > r = devm_request_irq(dev, pci_dev->irq, cio2_irq, IRQF_SHARED, > > CIO2_NAME, cio2); > > if (r) { > > @@ -1801,6 +1796,11 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, > > goto fail_clean_notifier; > > } > > > > + /* Register notifier for subdevices we care */ > > + r = cio2_parse_firmware(cio2); > > + if (r) > > + goto fail_clean_notifier; > > + > > pm_runtime_put_noidle(dev); > > pm_runtime_allow(dev); > >
Hi Laurent, Hans, On Wed, Feb 07, 2024 at 04:34:18PM +0200, Laurent Pinchart wrote: > On Mon, Feb 05, 2024 at 03:58:45PM +0100, Hans Verkuil wrote: > > On 20/12/2023 11:37, Sakari Ailus wrote: > > > Call devm_request_irq() before registering the async notifier, as otherwise > > > it would be possible to use the device before the interrupts could be > > > deliveted to the driver. > > > > deliveted -> delivered > > > > Isn't this a regular fix? Ditto for the previous patch (20/29). > > > > I'd just queue this up in the next PR. Yeah, I wrote it as part of the set but missed there are no further dependencies. I'll post a new version of this separately. > > Fixes: tags would then be nice. It was in the patch adding the driver. I'll add Fixes: line.
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index da82d09b46ab..3222ec5b8345 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -1789,11 +1789,6 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, v4l2_async_nf_init(&cio2->notifier, &cio2->v4l2_dev); - /* Register notifier for subdevices we care */ - r = cio2_parse_firmware(cio2); - if (r) - goto fail_clean_notifier; - r = devm_request_irq(dev, pci_dev->irq, cio2_irq, IRQF_SHARED, CIO2_NAME, cio2); if (r) { @@ -1801,6 +1796,11 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, goto fail_clean_notifier; } + /* Register notifier for subdevices we care */ + r = cio2_parse_firmware(cio2); + if (r) + goto fail_clean_notifier; + pm_runtime_put_noidle(dev); pm_runtime_allow(dev);