Message ID | 20240126-gix-mtk-warnings-v1-11-eed7865fce18@chromium.org (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Hans Verkuil |
Headers |
Received: from ny.mirrors.kernel.org ([147.75.199.223]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-4246-patchwork=linuxtv.org@vger.kernel.org>) id 1rTVVG-0002eu-1T for patchwork@linuxtv.org; Fri, 26 Jan 2024 23:20:55 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 24FDA1C21D8C for <patchwork@linuxtv.org>; Fri, 26 Jan 2024 23:20:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 656DA61667; Fri, 26 Jan 2024 23:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Vpm0Alqe" X-Original-To: linux-media@vger.kernel.org Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E74760BBE for <linux-media@vger.kernel.org>; Fri, 26 Jan 2024 23:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706310980; cv=none; b=HVoip3y9aCqHs1UkwXYTlZZMYGbTO/tmNDXes9m23qYXAnKXt+FCljInT2+qnK/N7RQmNhnfoNXdrGM6QEG45CML7vOV6+V8UYB4qyItDphnwR6xcS6XjfG23Mk3WUzxyTTZjND7/5mxr9/WaLb5wF4Z8kHPe/Bp1/IxMAt6cOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706310980; c=relaxed/simple; bh=v/x46NG9ZtIytS9oM1clKOYXlZ53ICZmAoZoIkhTFns=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O88WkoahQsXKOgRAsnHn4Q2eDBL5IF+7zs8YGjYvkoQO8ljTMCHZQxczPUW5UHQvz654UScUYeeHBV1KL4R8Dg/M0GKccrMNrBCquCtadnaNzzgCw6qlrOVQ7k0UxYRZ+aUy9nc2rt8SKfFuNBUICSsQBy+eLtSjj3NTzSacRWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Vpm0Alqe; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-783045e88a6so102316585a.0 for <linux-media@vger.kernel.org>; Fri, 26 Jan 2024 15:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706310977; x=1706915777; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IQ2hVP5YSWUaFh2DmjHhBwG+r6f86O5FO2Ifv95SzW4=; b=Vpm0Alqepbm36hTtHDgkkwNTDh6NWwz6+6fiuYEgdQt95tbDbx7oHZrR1rJ4tJNBVe 0uzH9p2RxdxJBdOI3YzouriamdWl9xmjdp9jX0JKkRAhqdQM+R0y6+guUwtFYR6vbSNr E/7SviodFMDrj/IVT6/3lY7fiGbDwRPxN4L3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706310977; x=1706915777; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IQ2hVP5YSWUaFh2DmjHhBwG+r6f86O5FO2Ifv95SzW4=; b=m1EigSlyZHStFA4AczW+dbKVxF1vGvcMbeMr0mX6rxYl4GOlfLgJIhlODggp4/kHl6 Dso4xdJ3EJiXEKEkFCxnWe+uHV1rqJBy3CA3meCYakVxZIYrXzkhY1tcj/sFD73bcbOg rYmkwhNkskUUtcLWWIpePr0ZVzXGCEV3bIEnlCQSxYlR3eDMkVMNPaMx/aYDA+S7BEN2 SJcQVy/M1wmRPMjpqIoSpJY0froodM69sT2SxeoT5mz5zwMSif2HnLJh8KqERgvpxYf5 HkQKh/mZuy45cjVOwkEzR1e+eEEACAHyCaYzlUd8oUwIZKvZ/mtYlGzm3KgD6XZQjXtH l5FQ== X-Gm-Message-State: AOJu0Ywa802tSn5ErDUT0jMfUoz4qOP7T0RuDZCHHwCpSO9iEi3VFBxP k5jGa9Ns28bjo/GQqj3lajNx+ZDgJHHujWZGq+bcw5JzjT55OQNNoaCTn9Kx6g== X-Google-Smtp-Source: AGHT+IHtaIwGnlHCGr2gV5vTdHthY/KJARNYO6pIlwA2CpmdH7LMlVQFPCHc4W3qOep8rQ/bvmYRGg== X-Received: by 2002:a05:620a:12d9:b0:783:25ba:6c70 with SMTP id e25-20020a05620a12d900b0078325ba6c70mr576836qkl.129.1706310977198; Fri, 26 Jan 2024 15:16:17 -0800 (PST) Received: from denia.c.googlers.com (240.157.150.34.bc.googleusercontent.com. [34.150.157.240]) by smtp.gmail.com with ESMTPSA id m4-20020a05620a290400b00783de3ddf5esm507358qkp.70.2024.01.26.15.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 15:16:16 -0800 (PST) From: Ricardo Ribalda <ribalda@chromium.org> Date: Fri, 26 Jan 2024 23:16:10 +0000 Subject: [PATCH 11/17] media: qcom: venus: Fix kerneldoc Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240126-gix-mtk-warnings-v1-11-eed7865fce18@chromium.org> References: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> In-Reply-To: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> To: Tiffany Lin <tiffany.lin@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Yunfei Dong <yunfei.dong@mediatek.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Hans Verkuil <hverkuil@xs4all.nl>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Bin Liu <bin.liu@mediatek.com>, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Philipp Zabel <p.zabel@pengutronix.de>, Stanimir Varbanov <stanimir.k.varbanov@gmail.com>, Vikash Garodia <quic_vgarodia@quicinc.com>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Bingbu Cao <bingbu.cao@intel.com>, Tianshu Qiu <tian.shu.qiu@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-amlogic@lists.infradead.org, Ricardo Ribalda <ribalda@chromium.org> X-Mailer: b4 0.12.3 X-LSpam-Score: -4.0 (----) X-LSpam-Report: No, score=-4.0 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,DKIMWL_WL_HIGH=-1,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no |
Series |
media: kerneldoc warnings
|
|
Commit Message
Ricardo Ribalda
Jan. 26, 2024, 11:16 p.m. UTC
Remove doc for missing field.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/qcom/venus/core.h | 1 -
1 file changed, 1 deletion(-)
Comments
Hi, On 1/26/24 15:16, Ricardo Ribalda wrote: > Remove doc for missing field. > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/platform/qcom/venus/core.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h > index 4a633261ece4..a39986ce79f1 100644 > --- a/drivers/media/platform/qcom/venus/core.h > +++ b/drivers/media/platform/qcom/venus/core.h > @@ -428,7 +428,6 @@ enum venus_inst_modes { > * @error: an error returned during last HFI sync operation > * @session_error: a flag rised by HFI interface in case of session error > * @ops: HFI operations > - * @priv: a private for HFI operations callbacks > * @session_type: the type of the session (decoder or encoder) > * @hprop: a union used as a holder by get property > * @core_acquired: the Core has been acquired > I don't understand this one. I do understand the patch above, but the in the struct, I see: unsigned long enc_codecs; unsigned long dec_codecs; unsigned int max_sessions_supported; void *priv; const struct hfi_ops *ops; struct delayed_work work; I'm just guessing, but maybe scripts/kernel-doc is confused....
On 1/27/24 14:13, Randy Dunlap wrote: > Hi, > > On 1/26/24 15:16, Ricardo Ribalda wrote: >> Remove doc for missing field. >> >> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> >> --- >> drivers/media/platform/qcom/venus/core.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h >> index 4a633261ece4..a39986ce79f1 100644 >> --- a/drivers/media/platform/qcom/venus/core.h >> +++ b/drivers/media/platform/qcom/venus/core.h >> @@ -428,7 +428,6 @@ enum venus_inst_modes { >> * @error: an error returned during last HFI sync operation >> * @session_error: a flag rised by HFI interface in case of session error >> * @ops: HFI operations >> - * @priv: a private for HFI operations callbacks >> * @session_type: the type of the session (decoder or encoder) >> * @hprop: a union used as a holder by get property >> * @core_acquired: the Core has been acquired >> > > I don't understand this one. I do understand the patch above, but the in the struct, > I see: > > unsigned long enc_codecs; > unsigned long dec_codecs; > unsigned int max_sessions_supported; > void *priv; > const struct hfi_ops *ops; > struct delayed_work work; > > I'm just guessing, but maybe scripts/kernel-doc is confused.... > Nope, I'm confused. The patch is correct. Thanks. Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h index 4a633261ece4..a39986ce79f1 100644 --- a/drivers/media/platform/qcom/venus/core.h +++ b/drivers/media/platform/qcom/venus/core.h @@ -428,7 +428,6 @@ enum venus_inst_modes { * @error: an error returned during last HFI sync operation * @session_error: a flag rised by HFI interface in case of session error * @ops: HFI operations - * @priv: a private for HFI operations callbacks * @session_type: the type of the session (decoder or encoder) * @hprop: a union used as a holder by get property * @core_acquired: the Core has been acquired