diff mbox series

[1/4] media: i2c: imx335: Drop setting of 0x3a00 register

Message ID 20240125154908.465191-2-umang.jain@ideasonboard.com (mailing list archive)
State Superseded
Headers
Series imx335: Support additional link-freq and TPG |

Commit Message

Umang Jain Jan. 25, 2024, 3:49 p.m. UTC 
  Register 0x3a00 is a reserved field as per the IMX335 datasheet,
hence shouldn't be set by the driver.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 drivers/media/i2c/imx335.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Sakari Ailus Jan. 25, 2024, 4:05 p.m. UTC | #1 
Hi Umang,

On Thu, Jan 25, 2024 at 09:19:05PM +0530, Umang Jain wrote:
> Register 0x3a00 is a reserved field as per the IMX335 datasheet,
> hence shouldn't be set by the driver.

How have you checked this has no effect on the device's operation?

It's not uncommon for sensor vendors to document some hush-hush registers
as "reserved".
diff mbox series

Patch

diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index 5cca8d637952..0df9ea189fff 100644
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -249,7 +249,6 @@  static const struct imx335_reg mode_2592x1940_regs[] = {
 	{0x3794, 0x7a},
 	{0x3796, 0xa1},
 	{0x37b0, 0x36},
-	{0x3a00, 0x01},
 };
 
 static const struct imx335_reg raw10_framefmt_regs[] = {