[1/1] dt-bindings: media: imx-jpeg: Document slot property
Commit Message
There are 4 slots available in the IP, which the driver may use.
This property lists which slots can be used. In reference to commit
53ebeea50599 ("media: imx-jpeg: Support to assign slot for encoder/decoder")
only slot 0 can be used on imx8qxp.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
.../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
Comments
On 10/01/2024 10:46, Alexander Stein wrote:
> There are 4 slots available in the IP, which the driver may use.
> This property lists which slots can be used. In reference to commit
> 53ebeea50599 ("media: imx-jpeg: Support to assign slot for encoder/decoder")
> only slot 0 can be used on imx8qxp.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 07fef1e723f20..5122c7cff8e73 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -54,6 +54,14 @@ properties:
> minItems: 2 # Wrapper and 1 slot
> maxItems: 5 # Wrapper and 4 slots
>
> + slot:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
NAK for documenting something post factum.
https://lore.kernel.org/all/9b853b5f-b3e6-4aea-b99a-51a490a29f9d@linaro.org/
https://lore.kernel.org/all/cover.1697597713.git.ming.qian@nxp.com/
Best regards,
Krzysztof
Am Mittwoch, 10. Januar 2024, 11:17:42 CET schrieb Krzysztof Kozlowski:
> ********************
> Achtung externe E-Mail: Öffnen Sie Anhänge und Links nur, wenn Sie wissen,
> dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten Sie
> die E-Mail im Zweifelsfall zur Prüfung an den IT-Helpdesk weiter.
> Attention external email: Open attachments and links only if you know that
> they are from a secure source and are safe. In doubt forward the email to
> the IT-Helpdesk to check it. ********************
>
> On 10/01/2024 10:46, Alexander Stein wrote:
> > There are 4 slots available in the IP, which the driver may use.
> > This property lists which slots can be used. In reference to commit
> > 53ebeea50599 ("media: imx-jpeg: Support to assign slot for
> > encoder/decoder") only slot 0 can be used on imx8qxp.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> > b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml index
> > 07fef1e723f20..5122c7cff8e73 100644
> > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> >
> > @@ -54,6 +54,14 @@ properties:
> > minItems: 2 # Wrapper and 1 slot
> > maxItems: 5 # Wrapper and 4 slots
> >
> > + slot:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
>
> NAK for documenting something post factum.
>
> https://lore.kernel.org/all/9b853b5f-b3e6-4aea-b99a-51a490a29f9d@linaro.org/
>
> https://lore.kernel.org/all/cover.1697597713.git.ming.qian@nxp.com/
Ah, thanks. I was not aware of that discussion. I'll wait for v6 then.
Thanks and best regards,
Alexander
@@ -54,6 +54,14 @@ properties:
minItems: 2 # Wrapper and 1 slot
maxItems: 5 # Wrapper and 4 slots
+ slot:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 4
+ items:
+ enum: [ 0, 1, 2, 3 ]
+ description: Available slot index
+
required:
- compatible
- reg
@@ -85,6 +93,7 @@ examples:
<&pd IMX_SC_R_MJPEG_DEC_S1>,
<&pd IMX_SC_R_MJPEG_DEC_S2>,
<&pd IMX_SC_R_MJPEG_DEC_S3>;
+ slot = <0>;
};
jpegenc: jpegenc@58450000 {
@@ -102,5 +111,6 @@ examples:
<&pd IMX_SC_R_MJPEG_ENC_S1>,
<&pd IMX_SC_R_MJPEG_ENC_S2>,
<&pd IMX_SC_R_MJPEG_ENC_S3>;
+ slot = <0>;
};
...