Message ID | 20231206094401.491100-1-alexander.stein@ew.tq-group.com (mailing list archive) |
---|---|
State | New |
Headers |
Received: from am.mirrors.kernel.org ([147.75.80.249]) by www.linuxtv.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <linux-media+bounces-1724-patchwork=linuxtv.org@vger.kernel.org>) id 1rAoS3-00CRrY-59 for patchwork@linuxtv.org; Wed, 06 Dec 2023 09:44:19 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 22AFB1F211E1 for <patchwork@linuxtv.org>; Wed, 6 Dec 2023 09:44:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2BB41BDD3; Wed, 6 Dec 2023 09:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="qYh9pD04" X-Original-To: linux-media@vger.kernel.org Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29589AB for <linux-media@vger.kernel.org>; Wed, 6 Dec 2023 01:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1701855846; x=1733391846; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tETj21Fu9I358pJ0uzujFXz5/dtU7Q6TGXtf4wvjMb4=; b=qYh9pD04ISPyLQS7S5x6NomcSJxlw1f+SsAa41BnsFBvKEfz2vhkZuIB bw8BZpUXsVzkaS8RMGnusAjiWbtgzTG3kieo35EqMkwfy78MVnWmSaSXS ApJ4hnE43cYqpUSwCP5BcS+Kk5PO1Woh0dCghV3GMNZOdgvot3BEhyOUs mI2rmQzvSPz68Xs8Q0Ei4RP+pa1ScR7mJLFX09IkTVaD5eFRpZUCcUkqk ean4bPhtDNCy5qP1uCo46s/ynWQAotd6s5ddTEaDgzkzNM3oIdtL/J7KT yLZqkAZpdJ39WG3QV0s+98pysCWhZfjkKlwYtQ+NKOBGeUMG2Rs0Z90lW g==; X-IronPort-AV: E=Sophos;i="6.04,254,1695679200"; d="scan'208";a="34354274" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Dec 2023 10:44:03 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id A4A36280075; Wed, 6 Dec 2023 10:44:03 +0100 (CET) From: Alexander Stein <alexander.stein@ew.tq-group.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/1] media: nxp: imx8-isi-debug: Add missing registers to debugfs output Date: Wed, 6 Dec 2023 10:44:01 +0100 Message-Id: <20231206094401.491100-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-LSpam-Score: -4.7 (----) X-LSpam-Report: No, score=-4.7 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
[1/1] media: nxp: imx8-isi-debug: Add missing registers to debugfs output
|
|
Commit Message
Alexander Stein
Dec. 6, 2023, 9:44 a.m. UTC
The extended address registers are missing in the debug output register
list. Add them.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++
1 file changed, 7 insertions(+)
Comments
Hi Alexander, On Wed, Dec 06, 2023 at 10:44:01AM +0100, Alexander Stein wrote: > The extended address registers are missing in the debug output register > list. Add them. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > index 6709ab7ea1f3..3ac5685d6cc1 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct seq_file *m, void *p) > MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), > MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), > MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), > + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), > + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), > + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), > + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), > + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), Those registers only exist in the i.MX8MP. The i.MX8MN referenece manual lists them as reserved and indicates they read as 0's, so it should be safe. The i.MX93 reference manual, however, doesn't list those registers at all, so accessing them may lead to issues. How what platform(s) have you tested this patch ? > }; > > struct mxc_isi_pipe *pipe = m->private;
Hi Laurent, Am Mittwoch, 6. Dezember 2023, 23:36:36 CET schrieb Laurent Pinchart: > Hi Alexander, > > On Wed, Dec 06, 2023 at 10:44:01AM +0100, Alexander Stein wrote: > > The extended address registers are missing in the debug output register > > list. Add them. > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c index > > 6709ab7ea1f3..3ac5685d6cc1 100644 > > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct seq_file > > *m, void *p)> > > MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), > > MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), > > MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), > > + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), > > Those registers only exist in the i.MX8MP. The i.MX8MN referenece manual > lists them as reserved and indicates they read as 0's, so it should be > safe. The i.MX93 reference manual, however, doesn't list those > registers at all, so accessing them may lead to issues. > > How what platform(s) have you tested this patch ? Ah, you are right. That's something I didn't take into account. Up until now I only tested this on i.MX8MP. I hope I can test this on i.MX8MN and i.MX93 soon. Otherwise dumping these registers can depend on pdata->has_36bit_dma just to be safe. Best regards, Alexander > > }; > > > > struct mxc_isi_pipe *pipe = m->private;
Hi Alexander, On Thu, Dec 07, 2023 at 08:52:46AM +0100, Alexander Stein wrote: > Am Mittwoch, 6. Dezember 2023, 23:36:36 CET schrieb Laurent Pinchart: > > On Wed, Dec 06, 2023 at 10:44:01AM +0100, Alexander Stein wrote: > > > The extended address registers are missing in the debug output register > > > list. Add them. > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > --- > > > > > > drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c index > > > 6709ab7ea1f3..3ac5685d6cc1 100644 > > > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct seq_file *m, void *p) > > > MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), > > > MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), > > > MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), > > > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), > > > > Those registers only exist in the i.MX8MP. The i.MX8MN referenece manual > > lists them as reserved and indicates they read as 0's, so it should be > > safe. The i.MX93 reference manual, however, doesn't list those > > registers at all, so accessing them may lead to issues. > > > > How what platform(s) have you tested this patch ? > > Ah, you are right. That's something I didn't take into account. Up until now I > only tested this on i.MX8MP. I hope I can test this on i.MX8MN and i.MX93 > soon. > Otherwise dumping these registers can depend on pdata->has_36bit_dma just to > be safe. That sounds like a good solution to me. Will you do so in a v2 ? > > > }; > > > > > > struct mxc_isi_pipe *pipe = m->private;
Hi Laurent, Am Donnerstag, 7. Dezember 2023, 11:14:00 CET schrieb Laurent Pinchart: > Hi Alexander, > > On Thu, Dec 07, 2023 at 08:52:46AM +0100, Alexander Stein wrote: > > Am Mittwoch, 6. Dezember 2023, 23:36:36 CET schrieb Laurent Pinchart: > > > On Wed, Dec 06, 2023 at 10:44:01AM +0100, Alexander Stein wrote: > > > > The extended address registers are missing in the debug output > > > > register > > > > list. Add them. > > > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > > > > > drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c index > > > > 6709ab7ea1f3..3ac5685d6cc1 100644 > > > > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > > @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct > > > > seq_file *m, void *p)> > > > > > > MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), > > > > MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), > > > > MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), > > > > > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), > > > > > > Those registers only exist in the i.MX8MP. The i.MX8MN referenece manual > > > lists them as reserved and indicates they read as 0's, so it should be > > > safe. The i.MX93 reference manual, however, doesn't list those > > > registers at all, so accessing them may lead to issues. > > > > > > How what platform(s) have you tested this patch ? > > > > Ah, you are right. That's something I didn't take into account. Up until > > now I only tested this on i.MX8MP. I hope I can test this on i.MX8MN and > > i.MX93 soon. > > Otherwise dumping these registers can depend on pdata->has_36bit_dma just > > to be safe. > > That sounds like a good solution to me. Will you do so in a v2 ? Yep, yep just sent it. Best regards Alexander > > > > > }; > > > > > > > > struct mxc_isi_pipe *pipe = m->private;
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c index 6709ab7ea1f3..3ac5685d6cc1 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct seq_file *m, void *p) MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), }; struct mxc_isi_pipe *pipe = m->private;