| Message ID | 20231129093113.255161-3-paul.elder@ideasonboard.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers |
Received: from ny.mirrors.kernel.org ([147.75.199.223]) by www.linuxtv.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <linux-media+bounces-1340-patchwork=linuxtv.org@vger.kernel.org>) id 1r8GvP-004Pu2-UZ for patchwork@linuxtv.org; Wed, 29 Nov 2023 09:32:09 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4D18B1C20895 for <patchwork@linuxtv.org>; Wed, 29 Nov 2023 09:32:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78D8315E86; Wed, 29 Nov 2023 09:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="duQqJegx" X-Original-To: linux-media@vger.kernel.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D85E1FEE; Wed, 29 Nov 2023 01:31:58 -0800 (PST) Received: from pyrite.hamster-moth.ts.net (h175-177-049-135.catv02.itscom.jp [175.177.49.135]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B58862B6; Wed, 29 Nov 2023 10:31:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701250281; bh=mJ4UNX0sJTsJlj1KPGeUn8FdbosXEmT20xBZ0fX5pX4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=duQqJegxA5ltyL5+sJyfwSIfVzIqTNLz+OKkqLm9ide36PPT8xVHacN4dMCVOf2In pTYGKFYC+aIxpbS4kuZurW4SKH4AWpxl9giTw8JquWA5GQKJEdmSApWwFvRKccfiRr qmivmYMYL33yKhAbxbQaHM+q8Spy/5CFpJkklQF0= From: Paul Elder <paul.elder@ideasonboard.com> To: linux-media@vger.kernel.org, devicetree@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Paul Elder <paul.elder@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Tim Harvey <tharvey@gateworks.com>, Philippe Schenker <philippe.schenker@toradex.com>, Alexander Stein <alexander.stein@ew.tq-group.com>, Marek Vasut <marex@denx.de>, Gregor Herburger <gregor.herburger@ew.tq-group.com>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE) Subject: [PATCH 2/2] arm64: dts: imx8mp: Add overlays for ISP instances Date: Wed, 29 Nov 2023 18:31:13 +0900 Message-Id: <20231129093113.255161-3-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231129093113.255161-1-paul.elder@ideasonboard.com> References: <20231129093113.255161-1-paul.elder@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=unavailable autolearn_force=no |
| Series |
arm64: dts: imx8mp: Add support for the ISPs
|
|
Commit Message
Paul Elder
Nov. 29, 2023, 9:31 a.m. UTC
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Add two overlay to enable each ISP instance. The ISP is wired directly to the CSIS for now, bypassing the ISI completely. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- arch/arm64/boot/dts/freescale/Makefile | 2 ++ .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ 3 files changed, 74 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso
Comments
Hi Paul, thanks for the patch. Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Add two overlay to enable each ISP instance. The ISP is wired directly > to the CSIS for now, bypassing the ISI completely. I'm not sure if this is worth adding in a separate overlay. > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > 3 files changed, 74 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > b/arch/arm64/boot/dts/freescale/Makefile index 300049037eb0..f97dfac11189 > 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > index 000000000000..cf394ed224ab > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2022 Ideas on Board Oy > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include <dt-bindings/media/video-interfaces.h> > + > +&isi_0 { > + status = "disabled"; ISI is disabled by default. What is your intention here? > + > + ports { > + port@0 { > + /delete-node/ endpoint; This doesn't work in overlays. See [1]. Otherwise the OF graph connections look fine to me. I'm using the same in my local overlay. Best regards, Alexander [1] https://lore.kernel.org/all/ CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZBkhsPZA@mail.gmail.com/ > + }; > + }; > +}; > + > +&isp_0 { > + status = "okay"; > + > + ports { > + port@1 { > + isp0_in: endpoint { > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > + remote-endpoint = <&mipi_csi_0_out>; > + }; > + }; > + }; > +}; > + > +&mipi_csi_0_out { > + remote-endpoint = <&isp0_in>; > +}; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > index 000000000000..14e2e7b2617f > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2022 Ideas on Board Oy > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include <dt-bindings/media/video-interfaces.h> > + > +&isi_0 { > + status = "disabled"; > + > + ports { > + port@1 { > + /delete-node/ endpoint; > + }; > + }; > +}; > + > +&isp_1 { > + status = "okay"; > + > + ports { > + port@1 { > + isp1_in: endpoint { > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > + remote-endpoint = <&mipi_csi_1_out>; > + }; > + }; > + }; > +}; > + > +&mipi_csi_1_out { > + remote-endpoint = <&isp1_in>; > +};
Hi Alexander, On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > to the CSIS for now, bypassing the ISI completely. > > I'm not sure if this is worth adding in a separate overlay. The trouble is that, at this point, selection between the ISP and the ISI can only be performed through DT :-S That's why this is implemented as an overlay. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > 3 files changed, 74 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile index 300049037eb0..f97dfac11189 > > 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > index 000000000000..cf394ed224ab > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > @@ -0,0 +1,36 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2022 Ideas on Board Oy > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +#include <dt-bindings/media/video-interfaces.h> > > + > > +&isi_0 { > > + status = "disabled"; > > ISI is disabled by default. What is your intention here? It could be enabled by an overlay for a camera module. Ideally we want to be able to enable both the ISI and ISP at runtime, but that's not possible yet and will require a very large amount of work. > > + > > + ports { > > + port@0 { > > + /delete-node/ endpoint; > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > look fine to me. I'm using the same in my local overlay. Interesting, I wasn't aware of that. Maybe we should fix it :-) > [1] https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZBkhsPZA@mail.gmail.com/ > > > + }; > > + }; > > +}; > > + > > +&isp_0 { > > + status = "okay"; > > + > > + ports { > > + port@1 { > > + isp0_in: endpoint { > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > + remote-endpoint = <&mipi_csi_0_out>; > > + }; > > + }; > > + }; > > +}; > > + > > +&mipi_csi_0_out { > > + remote-endpoint = <&isp0_in>; > > +}; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > index 000000000000..14e2e7b2617f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > @@ -0,0 +1,36 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2022 Ideas on Board Oy > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +#include <dt-bindings/media/video-interfaces.h> > > + > > +&isi_0 { > > + status = "disabled"; > > + > > + ports { > > + port@1 { > > + /delete-node/ endpoint; > > + }; > > + }; > > +}; > > + > > +&isp_1 { > > + status = "okay"; > > + > > + ports { > > + port@1 { > > + isp1_in: endpoint { > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > + remote-endpoint = <&mipi_csi_1_out>; > > + }; > > + }; > > + }; > > +}; > > + > > +&mipi_csi_1_out { > > + remote-endpoint = <&isp1_in>; > > +};
Hi Laurent, Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > Hi Alexander, > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > to the CSIS for now, bypassing the ISI completely. > > > > I'm not sure if this is worth adding in a separate overlay. > > The trouble is that, at this point, selection between the ISP and the > ISI can only be performed through DT :-S That's why this is implemented > as an overlay. I feel a better place would be the overlay which actually adds the sensor. This knows best whether ISI or ISP should be used. > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > --- > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > 3 files changed, 74 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > 300049037eb0..f97dfac11189 > > > 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > index 000000000000..cf394ed224ab > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > @@ -0,0 +1,36 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright 2022 Ideas on Board Oy > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +#include <dt-bindings/media/video-interfaces.h> > > > + > > > +&isi_0 { > > > + status = "disabled"; > > > > ISI is disabled by default. What is your intention here? > > It could be enabled by an overlay for a camera module. Ideally we want > to be able to enable both the ISI and ISP at runtime, but that's not > possible yet and will require a very large amount of work. Again IMHO this is part of sensor setup, in a very specific overlay. To put it into different words: I barely see the gain of this small overlay. Runtime switching would require a combined media controller including both ISI and ISP, no? Best regards, Alexander > > > + > > > + ports { > > > + port@0 { > > > + /delete-node/ endpoint; > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > > look fine to me. I'm using the same in my local overlay. > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > [1] > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZB > > khsPZA@mail.gmail.com/> > > > + }; > > > + }; > > > +}; > > > + > > > +&isp_0 { > > > + status = "okay"; > > > + > > > + ports { > > > + port@1 { > > > + isp0_in: endpoint { > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > + remote-endpoint = <&mipi_csi_0_out>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&mipi_csi_0_out { > > > + remote-endpoint = <&isp0_in>; > > > +}; > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > index 000000000000..14e2e7b2617f > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > @@ -0,0 +1,36 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright 2022 Ideas on Board Oy > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +#include <dt-bindings/media/video-interfaces.h> > > > + > > > +&isi_0 { > > > + status = "disabled"; > > > + > > > + ports { > > > + port@1 { > > > + /delete-node/ endpoint; > > > + }; > > > + }; > > > +}; > > > + > > > +&isp_1 { > > > + status = "okay"; > > > + > > > + ports { > > > + port@1 { > > > + isp1_in: endpoint { > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > + remote-endpoint = <&mipi_csi_1_out>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&mipi_csi_1_out { > > > + remote-endpoint = <&isp1_in>; > > > +};
On Thu, Nov 30, 2023 at 3:51 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Hi Laurent, > > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > Hi Alexander, > > > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > The trouble is that, at this point, selection between the ISP and the > > ISI can only be performed through DT :-S That's why this is implemented > > as an overlay. > > I feel a better place would be the overlay which actually adds the sensor. > This knows best whether ISI or ISP should be used. > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > --- > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > > 3 files changed, 74 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > 300049037eb0..f97dfac11189 > > > > 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > > index 000000000000..cf394ed224ab > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > @@ -0,0 +1,36 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2022 Ideas on Board Oy > > > > + */ > > > > + > > > > +/dts-v1/; > > > > +/plugin/; > > > > + > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > + > > > > +&isi_0 { > > > > + status = "disabled"; > > > > > > ISI is disabled by default. What is your intention here? > > > > It could be enabled by an overlay for a camera module. Ideally we want > > to be able to enable both the ISI and ISP at runtime, but that's not > > possible yet and will require a very large amount of work. > > Again IMHO this is part of sensor setup, in a very specific overlay. To put it > into different words: I barely see the gain of this small overlay. > > Runtime switching would require a combined media controller including both ISI > and ISP, no? > > Best regards, > Alexander > > > > > + > > > > + ports { > > > > + port@0 { > > > > + /delete-node/ endpoint; > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > > > look fine to me. I'm using the same in my local overlay. > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) When I did my camera implementation, I thought it was simpler to: /delete-node/ &isi_in_0; it's a one-line change. I would suggest we just drop the overlay and make users who have the cameras integrate the cameras and the isp routing into their respective overlays. adam > > > > > [1] > > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZB > > > khsPZA@mail.gmail.com/> > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&isp_0 { > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + isp0_in: endpoint { > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&mipi_csi_0_out { > > > > + remote-endpoint = <&isp0_in>; > > > > +}; > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > > index 000000000000..14e2e7b2617f > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > @@ -0,0 +1,36 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2022 Ideas on Board Oy > > > > + */ > > > > + > > > > +/dts-v1/; > > > > +/plugin/; > > > > + > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > + > > > > +&isi_0 { > > > > + status = "disabled"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + /delete-node/ endpoint; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&isp_1 { > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + isp1_in: endpoint { > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&mipi_csi_1_out { > > > > + remote-endpoint = <&isp1_in>; > > > > +}; > > > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > > >
+ Pantellis Quoting Adam Ford (2023-11-30 13:48:58) > On Thu, Nov 30, 2023 at 3:51 AM Alexander Stein > <alexander.stein@ew.tq-group.com> wrote: > > > > Hi Laurent, > > > > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > > Hi Alexander, > > > > > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > > > The trouble is that, at this point, selection between the ISP and the > > > ISI can only be performed through DT :-S That's why this is implemented > > > as an overlay. > > > > I feel a better place would be the overlay which actually adds the sensor. > > This knows best whether ISI or ISP should be used. > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > --- > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > > > 3 files changed, 74 insertions(+) > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > > 300049037eb0..f97dfac11189 > > > > > 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > > > index 000000000000..cf394ed224ab > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > @@ -0,0 +1,36 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > + */ > > > > > + > > > > > +/dts-v1/; > > > > > +/plugin/; > > > > > + > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > + > > > > > +&isi_0 { > > > > > + status = "disabled"; > > > > > > > > ISI is disabled by default. What is your intention here? > > > > > > It could be enabled by an overlay for a camera module. Ideally we want > > > to be able to enable both the ISI and ISP at runtime, but that's not > > > possible yet and will require a very large amount of work. > > > > Again IMHO this is part of sensor setup, in a very specific overlay. To put it > > into different words: I barely see the gain of this small overlay. > > > > Runtime switching would require a combined media controller including both ISI > > and ISP, no? > > > > Best regards, > > Alexander > > > > > > > + > > > > > + ports { > > > > > + port@0 { > > > > > + /delete-node/ endpoint; > > > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > > > > look fine to me. I'm using the same in my local overlay. > > > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > When I did my camera implementation, I thought it was simpler to: > > /delete-node/ &isi_in_0; > > it's a one-line change. > > I would suggest we just drop the overlay and make users who have the > cameras integrate the cameras and the isp routing into their > respective overlays. > I use these to factor out common parts between multiple cameras that can be connected to multiple ports. I can connect any of (Physically available to me right now) IMX219, IMX477, IMX708, GC2145, OV5640(7?) IMX335, IMX283, IMX519, Arducam64MP to either of: Debix-SOM-A Port CSI-1 Debix-SOM-A Port CSI-2 And I can connect those same cameras to two ports of a Pi5. So now that's 27 overlays to manage the 9 cameras I have /on my desk/ to connect to this board. Uh Oh - sorry I can also connect them to a Debix Model A ... oh no ... I need to stop thinking about what I can connect them to. I have rockchip boards they'll work on too! This explosion of overlays could be ... hard to manage. With /a lot/ of repetition of the same data. I'm not opposed to dropping these intermediate helper overlays, but I'd be interested to know if anyone has ideas on how we could define 'connectors' and then abstract the cameras / overlays that can be moved between different compatible ports. The [RFC 0/3] Portable Device Tree Connector [0] might be interesting to resurrect. Did that go anywhere? [0] https://lore.kernel.org/all/1464986273-12039-1-git-send-email-pantelis.antoniou@konsulko.com/ -- Kieran > adam > > > > > > > [1] > > > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZB > > > > khsPZA@mail.gmail.com/> > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&isp_0 { > > > > > + status = "okay"; > > > > > + > > > > > + ports { > > > > > + port@1 { > > > > > + isp0_in: endpoint { > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&mipi_csi_0_out { > > > > > + remote-endpoint = <&isp0_in>; > > > > > +}; > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > > > index 000000000000..14e2e7b2617f > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > @@ -0,0 +1,36 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > + */ > > > > > + > > > > > +/dts-v1/; > > > > > +/plugin/; > > > > > + > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > + > > > > > +&isi_0 { > > > > > + status = "disabled"; > > > > > + > > > > > + ports { > > > > > + port@1 { > > > > > + /delete-node/ endpoint; > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&isp_1 { > > > > > + status = "okay"; > > > > > + > > > > > + ports { > > > > > + port@1 { > > > > > + isp1_in: endpoint { > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&mipi_csi_1_out { > > > > > + remote-endpoint = <&isp1_in>; > > > > > +}; > > > > > > -- > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > > Amtsgericht München, HRB 105018 > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > > http://www.tq-group.com/ > > > > > >
On Thu, Nov 30, 2023 at 8:02 AM Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > + Pantellis > > Quoting Adam Ford (2023-11-30 13:48:58) > > On Thu, Nov 30, 2023 at 3:51 AM Alexander Stein > > <alexander.stein@ew.tq-group.com> wrote: > > > > > > Hi Laurent, > > > > > > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > > > Hi Alexander, > > > > > > > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > > > > > The trouble is that, at this point, selection between the ISP and the > > > > ISI can only be performed through DT :-S That's why this is implemented > > > > as an overlay. > > > > > > I feel a better place would be the overlay which actually adds the sensor. > > > This knows best whether ISI or ISP should be used. > > > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > > --- > > > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > > > > 3 files changed, 74 insertions(+) > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > > > 300049037eb0..f97dfac11189 > > > > > > 100644 > > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > > > > index 000000000000..cf394ed224ab > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > @@ -0,0 +1,36 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > > + */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > +/plugin/; > > > > > > + > > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > > + > > > > > > +&isi_0 { > > > > > > + status = "disabled"; > > > > > > > > > > ISI is disabled by default. What is your intention here? > > > > > > > > It could be enabled by an overlay for a camera module. Ideally we want > > > > to be able to enable both the ISI and ISP at runtime, but that's not > > > > possible yet and will require a very large amount of work. > > > > > > Again IMHO this is part of sensor setup, in a very specific overlay. To put it > > > into different words: I barely see the gain of this small overlay. > > > > > > Runtime switching would require a combined media controller including both ISI > > > and ISP, no? > > > > > > Best regards, > > > Alexander > > > > > > > > > + > > > > > > + ports { > > > > > > + port@0 { > > > > > > + /delete-node/ endpoint; > > > > > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > > > > > look fine to me. I'm using the same in my local overlay. > > > > > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > > When I did my camera implementation, I thought it was simpler to: > > > > /delete-node/ &isi_in_0; > > > > it's a one-line change. > > > > I would suggest we just drop the overlay and make users who have the > > cameras integrate the cameras and the isp routing into their > > respective overlays. > > > > I use these to factor out common parts between multiple cameras that can > be connected to multiple ports. > > I can connect any of (Physically available to me right now) > IMX219, IMX477, IMX708, GC2145, OV5640(7?) IMX335, IMX283, IMX519, Arducam64MP > > to either of: > > Debix-SOM-A Port CSI-1 > Debix-SOM-A Port CSI-2 > > And I can connect those same cameras to two ports of a Pi5. So now > that's 27 overlays to manage the 9 cameras I have /on my desk/ to > connect to this board. > > Uh Oh - sorry I can also connect them to a Debix Model A ... oh no ... I > need to stop thinking about what I can connect them to. I have rockchip > boards they'll work on too! > > This explosion of overlays could be ... hard to manage. With /a lot/ of > repetition of the same data. > That makes sense, I didn't think of it that way. > > I'm not opposed to dropping these intermediate helper overlays, but I'd > be interested to know if anyone has ideas on how we could define > 'connectors' and then abstract the cameras / overlays that can be moved > between different compatible ports. > > The [RFC 0/3] Portable Device Tree Connector [0] might be interesting to > resurrect. Did that go anywhere? > > [0] https://lore.kernel.org/all/1464986273-12039-1-git-send-email-pantelis.antoniou@konsulko.com/ > > -- > Kieran > > > adam > > > > > > > > > [1] > > > > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZB > > > > > khsPZA@mail.gmail.com/> > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&isp_0 { > > > > > > + status = "okay"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + isp0_in: endpoint { > > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > > > + }; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&mipi_csi_0_out { > > > > > > + remote-endpoint = <&isp0_in>; > > > > > > +}; > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > > > > index 000000000000..14e2e7b2617f > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > @@ -0,0 +1,36 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > > + */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > +/plugin/; > > > > > > + > > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > > + > > > > > > +&isi_0 { > > > > > > + status = "disabled"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + /delete-node/ endpoint; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&isp_1 { > > > > > > + status = "okay"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + isp1_in: endpoint { > > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > > > + }; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&mipi_csi_1_out { > > > > > > + remote-endpoint = <&isp1_in>; > > > > > > +}; > > > > > > > > > -- > > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > > > Amtsgericht München, HRB 105018 > > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > > > http://www.tq-group.com/ > > > > > > > > >
Hi Alexander, On Thu, Nov 30, 2023 at 10:51:22AM +0100, Alexander Stein wrote: > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > The trouble is that, at this point, selection between the ISP and the > > ISI can only be performed through DT :-S That's why this is implemented > > as an overlay. > > I feel a better place would be the overlay which actually adds the sensor. > This knows best whether ISI or ISP should be used. Any sensor could be used with either the ISI or the ISP, so I don't think the camera module overlay would be the best place for this. Unless you want to duplicate all camera module overlays, with an ISI version and an ISP version :-) > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > --- > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > > 3 files changed, 74 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > 300049037eb0..f97dfac11189 > > > > 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > > index 000000000000..cf394ed224ab > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > @@ -0,0 +1,36 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2022 Ideas on Board Oy > > > > + */ > > > > + > > > > +/dts-v1/; > > > > +/plugin/; > > > > + > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > + > > > > +&isi_0 { > > > > + status = "disabled"; > > > > > > ISI is disabled by default. What is your intention here? > > > > It could be enabled by an overlay for a camera module. Ideally we want > > to be able to enable both the ISI and ISP at runtime, but that's not > > possible yet and will require a very large amount of work. > > Again IMHO this is part of sensor setup, in a very specific overlay. To put it > into different words: I barely see the gain of this small overlay. > > Runtime switching would require a combined media controller including both ISI > and ISP, no? Correct, that's the hard part. > > > > + > > > > + ports { > > > > + port@0 { > > > > + /delete-node/ endpoint; > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > > > look fine to me. I'm using the same in my local overlay. > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > > > [1] https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZBkhsPZA@mail.gmail.com/ > > > > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&isp_0 { > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + isp0_in: endpoint { > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&mipi_csi_0_out { > > > > + remote-endpoint = <&isp0_in>; > > > > +}; > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > > index 000000000000..14e2e7b2617f > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > @@ -0,0 +1,36 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2022 Ideas on Board Oy > > > > + */ > > > > + > > > > +/dts-v1/; > > > > +/plugin/; > > > > + > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > + > > > > +&isi_0 { > > > > + status = "disabled"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + /delete-node/ endpoint; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&isp_1 { > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + isp1_in: endpoint { > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&mipi_csi_1_out { > > > > + remote-endpoint = <&isp1_in>; > > > > +};
Hi Kieran, Am Donnerstag, 30. November 2023, 15:02:36 CET schrieb Kieran Bingham: > + Pantellis > > Quoting Adam Ford (2023-11-30 13:48:58) > > > On Thu, Nov 30, 2023 at 3:51 AM Alexander Stein > > > > <alexander.stein@ew.tq-group.com> wrote: > > > Hi Laurent, > > > > > > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > > > Hi Alexander, > > > > > > > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired > > > > > > directly > > > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > > > > > The trouble is that, at this point, selection between the ISP and the > > > > ISI can only be performed through DT :-S That's why this is > > > > implemented > > > > as an overlay. > > > > > > I feel a better place would be the overlay which actually adds the > > > sensor. > > > This knows best whether ISI or ISP should be used. > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > <laurent.pinchart@ideasonboard.com> > > > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > > --- > > > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 > > > > > > +++++++++++++++++++ > > > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 > > > > > > +++++++++++++++++++ > > > > > > 3 files changed, 74 insertions(+) > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > > > 300049037eb0..f97dfac11189 > > > > > > 100644 > > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += > > > > > > imx8mp-dhcom-pdk2.dtb > > > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode > > > > > > 100644 > > > > > > index 000000000000..cf394ed224ab > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > @@ -0,0 +1,36 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > > + */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > +/plugin/; > > > > > > + > > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > > + > > > > > > +&isi_0 { > > > > > > + status = "disabled"; > > > > > > > > > > ISI is disabled by default. What is your intention here? > > > > > > > > It could be enabled by an overlay for a camera module. Ideally we want > > > > to be able to enable both the ISI and ISP at runtime, but that's not > > > > possible yet and will require a very large amount of work. > > > > > > Again IMHO this is part of sensor setup, in a very specific overlay. To > > > put it into different words: I barely see the gain of this small > > > overlay. > > > > > > Runtime switching would require a combined media controller including > > > both ISI and ISP, no? > > > > > > Best regards, > > > Alexander > > > > > > > > > + > > > > > > + ports { > > > > > > + port@0 { > > > > > > + /delete-node/ endpoint; > > > > > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph > > > > > connections > > > > > look fine to me. I'm using the same in my local overlay. > > > > > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > > When I did my camera implementation, I thought it was simpler to: > > > > /delete-node/ &isi_in_0; > > > > it's a one-line change. > > > > I would suggest we just drop the overlay and make users who have the > > cameras integrate the cameras and the isp routing into their > > respective overlays. > > I use these to factor out common parts between multiple cameras that can > be connected to multiple ports. > > I can connect any of (Physically available to me right now) > IMX219, IMX477, IMX708, GC2145, OV5640(7?) IMX335, IMX283, IMX519, > Arducam64MP > > to either of: > > Debix-SOM-A Port CSI-1 > Debix-SOM-A Port CSI-2 > > And I can connect those same cameras to two ports of a Pi5. So now > that's 27 overlays to manage the 9 cameras I have /on my desk/ to > connect to this board. > > Uh Oh - sorry I can also connect them to a Debix Model A ... oh no ... I > need to stop thinking about what I can connect them to. I have rockchip > boards they'll work on too! > > This explosion of overlays could be ... hard to manage. With /a lot/ of > repetition of the same data. Maybe I am missing something, but how can the intermediate overlay reduce this amount of overlays? At least the remote-endpoint of the sensor needs the CSI endpoint, which is different for CSI1/CSI2, and vice versa. I do not have rockchip hardware, but I would not assume the CSI endpoint to not have the same label, so the phandle reference is different there as well. > > I'm not opposed to dropping these intermediate helper overlays, but I'd > be interested to know if anyone has ideas on how we could define > 'connectors' and then abstract the cameras / overlays that can be moved > between different compatible ports. You still would have the naming problem. How do you identify a connector? It's similar to label naming on device tree nodes. Best regards, Alexander > The [RFC 0/3] Portable Device Tree Connector [0] might be interesting to > resurrect. Did that go anywhere? > > [0] > https://lore.kernel.org/all/1464986273-12039-1-git-send-email-pantelis.anto > niou@konsulko.com/ > > -- > Kieran > > > adam > > > > > > > [1] > > > > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1c > > > > > NrcZB > > > > > khsPZA@mail.gmail.com/> > > > > > > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&isp_0 { > > > > > > + status = "okay"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + isp0_in: endpoint { > > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > > > + }; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&mipi_csi_0_out { > > > > > > + remote-endpoint = <&isp0_in>; > > > > > > +}; > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode > > > > > > 100644 > > > > > > index 000000000000..14e2e7b2617f > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > @@ -0,0 +1,36 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > > + */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > +/plugin/; > > > > > > + > > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > > + > > > > > > +&isi_0 { > > > > > > + status = "disabled"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + /delete-node/ endpoint; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&isp_1 { > > > > > > + status = "okay"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + isp1_in: endpoint { > > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > > > + }; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&mipi_csi_1_out { > > > > > > + remote-endpoint = <&isp1_in>; > > > > > > +}; > > > > > > -- > > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > > > Amtsgericht München, HRB 105018 > > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > > > http://www.tq-group.com/
Hi Laurent, Am Donnerstag, 30. November 2023, 15:20:48 CET schrieb Laurent Pinchart: > Hi Alexander, > > On Thu, Nov 30, 2023 at 10:51:22AM +0100, Alexander Stein wrote: > > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired > > > > > directly > > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > > > The trouble is that, at this point, selection between the ISP and the > > > ISI can only be performed through DT :-S That's why this is implemented > > > as an overlay. > > > > I feel a better place would be the overlay which actually adds the sensor. > > This knows best whether ISI or ISP should be used. > > Any sensor could be used with either the ISI or the ISP, so I don't > think the camera module overlay would be the best place for this. Unless > you want to duplicate all camera module overlays, with an ISI version > and an ISP version :-) True, that's a really good argument for having these small overlays. But how to deal with dtc warnings? > imx8mp-isp1.dtbo: Warning (graph_port): /fragment@2: graph port node name should be 'port' > imx8mp-isp1.dtso:34.17-36.3: Warning (graph_endpoint): /fragment@2/ __overlay__: graph endpoint node name should be 'endpoint' > imx8mp-isp1.dtso:34.17-36.3: Warning (graph_endpoint): /fragment@2/ __overlay__: graph connection to node '/fragment@1/__overlay__/ports/port@1/ endpoint' is not bidirectional But for the small overlay itself: Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > --- > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 > > > > > +++++++++++++++++++ > > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 > > > > > +++++++++++++++++++ > > > > > 3 files changed, 74 insertions(+) > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > > 300049037eb0..f97dfac11189 > > > > > 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode > > > > > 100644 > > > > > index 000000000000..cf394ed224ab > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > @@ -0,0 +1,36 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > + */ > > > > > + > > > > > +/dts-v1/; > > > > > +/plugin/; > > > > > + > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > + > > > > > +&isi_0 { > > > > > + status = "disabled"; > > > > > > > > ISI is disabled by default. What is your intention here? > > > > > > It could be enabled by an overlay for a camera module. Ideally we want > > > to be able to enable both the ISI and ISP at runtime, but that's not > > > possible yet and will require a very large amount of work. > > > > Again IMHO this is part of sensor setup, in a very specific overlay. To > > put it into different words: I barely see the gain of this small overlay. > > > > Runtime switching would require a combined media controller including both > > ISI and ISP, no? > > Correct, that's the hard part. > > > > > > + > > > > > + ports { > > > > > + port@0 { > > > > > + /delete-node/ endpoint; > > > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph > > > > connections > > > > look fine to me. I'm using the same in my local overlay. > > > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > > > > > [1] > > > > https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cN > > > > rcZBkhsPZA@mail.gmail.com/> > > > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&isp_0 { > > > > > + status = "okay"; > > > > > + > > > > > + ports { > > > > > + port@1 { > > > > > + isp0_in: endpoint { > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&mipi_csi_0_out { > > > > > + remote-endpoint = <&isp0_in>; > > > > > +}; > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode > > > > > 100644 > > > > > index 000000000000..14e2e7b2617f > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > @@ -0,0 +1,36 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > + */ > > > > > + > > > > > +/dts-v1/; > > > > > +/plugin/; > > > > > + > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > + > > > > > +&isi_0 { > > > > > + status = "disabled"; > > > > > + > > > > > + ports { > > > > > + port@1 { > > > > > + /delete-node/ endpoint; > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&isp_1 { > > > > > + status = "okay"; > > > > > + > > > > > + ports { > > > > > + port@1 { > > > > > + isp1_in: endpoint { > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > +}; > > > > > + > > > > > +&mipi_csi_1_out { > > > > > + remote-endpoint = <&isp1_in>; > > > > > +};
On Thu, Nov 30, 2023 at 04:34:11PM +0100, Alexander Stein wrote: > Am Donnerstag, 30. November 2023, 15:20:48 CET schrieb Laurent Pinchart: > > On Thu, Nov 30, 2023 at 10:51:22AM +0100, Alexander Stein wrote: > > > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired > > > > > > directly > > > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > > > > > The trouble is that, at this point, selection between the ISP and the > > > > ISI can only be performed through DT :-S That's why this is implemented > > > > as an overlay. > > > > > > I feel a better place would be the overlay which actually adds the sensor. > > > This knows best whether ISI or ISP should be used. > > > > Any sensor could be used with either the ISI or the ISP, so I don't > > think the camera module overlay would be the best place for this. Unless > > you want to duplicate all camera module overlays, with an ISI version > > and an ISP version :-) > > True, that's a really good argument for having these small overlays. > But how to deal with dtc warnings? > > imx8mp-isp1.dtbo: Warning (graph_port): /fragment@2: graph port node name > should be 'port' > > imx8mp-isp1.dtso:34.17-36.3: Warning (graph_endpoint): /fragment@2/ > __overlay__: graph endpoint node name should be 'endpoint' > > imx8mp-isp1.dtso:34.17-36.3: Warning (graph_endpoint): /fragment@2/ > __overlay__: graph connection to node '/fragment@1/__overlay__/ports/port@1/ > endpoint' is not bidirectional See below :-) > But for the small overlay itself: > Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > > --- > > > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > > > > 3 files changed, 74 insertions(+) > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > > > 300049037eb0..f97dfac11189 > > > > > > 100644 > > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo Overlays need to be validated in the context of a base DT on which they apply. For instance, in the same Makefile, we have -------- dtb-$(CONFIG_ARCH_MXC) += imx8mm-tqma8mqml-mba8mx.dtb ... imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33-dtbs += imx8mm-tqma8mqml-mba8mx.dtb imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33.dtbo dtb-$(CONFIG_ARCH_MXC) += imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33.dtb -------- imx8mm-tqma8mqml-mba8mx.dts is the base board DT, and imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33.dtso the overlay. As far as I understand, when compiling dtbs, the build system will compile imx8mm-tqma8mqml-mba8mx.dtb and imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33-dtb. To create the latter, it will compile imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33.dtbo and apply it to imx8mm-tqma8mqml-mba8mx.dtb. Then, it will validate the DTBs specified as part of dtb-$(CONFIG_ARCH_MXC), which are imx8mm-tqma8mqml-mba8mx.dtb standlone, and through imx8mm-tqma8mqml-mba8mx-lvds-tm070jvhg33-dtbs imx8mm-tqma8mqml-mba8mx.dtb with the overlay applied. TL;DR: a v2 of this patch should fix the Makefile, and be compile-tested with make dtbs. Rob, Conor or Krzysztof can correct me if I'm wrong. > > > > > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode > > > > > > 100644 > > > > > > index 000000000000..cf394ed224ab > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > > > @@ -0,0 +1,36 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > > + */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > +/plugin/; > > > > > > + > > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > > + > > > > > > +&isi_0 { > > > > > > + status = "disabled"; > > > > > > > > > > ISI is disabled by default. What is your intention here? > > > > > > > > It could be enabled by an overlay for a camera module. Ideally we want > > > > to be able to enable both the ISI and ISP at runtime, but that's not > > > > possible yet and will require a very large amount of work. > > > > > > Again IMHO this is part of sensor setup, in a very specific overlay. To > > > put it into different words: I barely see the gain of this small overlay. > > > > > > Runtime switching would require a combined media controller including both > > > ISI and ISP, no? > > > > Correct, that's the hard part. > > > > > > > > + > > > > > > + ports { > > > > > > + port@0 { > > > > > > + /delete-node/ endpoint; > > > > > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph > > > > > connections > > > > > look fine to me. I'm using the same in my local overlay. > > > > > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > > > > > > > [1] https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZBkhsPZA@mail.gmail.com/ > > > > > > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&isp_0 { > > > > > > + status = "okay"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + isp0_in: endpoint { > > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > > > + }; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&mipi_csi_0_out { > > > > > > + remote-endpoint = <&isp0_in>; > > > > > > +}; > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode > > > > > > 100644 > > > > > > index 000000000000..14e2e7b2617f > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > @@ -0,0 +1,36 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright 2022 Ideas on Board Oy > > > > > > + */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > +/plugin/; > > > > > > + > > > > > > +#include <dt-bindings/media/video-interfaces.h> > > > > > > + > > > > > > +&isi_0 { > > > > > > + status = "disabled"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + /delete-node/ endpoint; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&isp_1 { > > > > > > + status = "okay"; > > > > > > + > > > > > > + ports { > > > > > > + port@1 { > > > > > > + isp1_in: endpoint { > > > > > > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; > > > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > > > + }; > > > > > > + }; > > > > > > + }; > > > > > > +}; > > > > > > + > > > > > > +&mipi_csi_1_out { > > > > > > + remote-endpoint = <&isp1_in>; > > > > > > +};
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 300049037eb0..f97dfac11189 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 index 000000000000..cf394ed224ab --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso @@ -0,0 +1,36 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2022 Ideas on Board Oy + */ + +/dts-v1/; +/plugin/; + +#include <dt-bindings/media/video-interfaces.h> + +&isi_0 { + status = "disabled"; + + ports { + port@0 { + /delete-node/ endpoint; + }; + }; +}; + +&isp_0 { + status = "okay"; + + ports { + port@1 { + isp0_in: endpoint { + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; + remote-endpoint = <&mipi_csi_0_out>; + }; + }; + }; +}; + +&mipi_csi_0_out { + remote-endpoint = <&isp0_in>; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 index 000000000000..14e2e7b2617f --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso @@ -0,0 +1,36 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2022 Ideas on Board Oy + */ + +/dts-v1/; +/plugin/; + +#include <dt-bindings/media/video-interfaces.h> + +&isi_0 { + status = "disabled"; + + ports { + port@1 { + /delete-node/ endpoint; + }; + }; +}; + +&isp_1 { + status = "okay"; + + ports { + port@1 { + isp1_in: endpoint { + bus-type = <MEDIA_BUS_TYPE_PARALLEL>; + remote-endpoint = <&mipi_csi_1_out>; + }; + }; + }; +}; + +&mipi_csi_1_out { + remote-endpoint = <&isp1_in>; +};