mbox series

[GIT,PULL,FOR,6.7] Mediatek Vcodec: Codec profile and level setting

Message ID 20231027085058.k65rwgxepmx5ivu5@basti-XPS-13-9310 (mailing list archive)
State Accepted
Delegated to: Hans Verkuil
Headers
Series [GIT,PULL,FOR,6.7] Mediatek Vcodec: Codec profile and level setting |

Pull-request

https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed

Message

Sebastian Fricke Oct. 27, 2023, 8:50 a.m. UTC 
  Hey Mauro and Hans,

first attempt at doing a PR, could you please check and pull this?

The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:

   media: venus: Fix firmware path for resources (2023-10-23 12:24:53 +0200)

are available in the Git repository at:

   https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed

for you to fetch changes up to ccd08a80f5e1844819874b01c5ff61e18aa9e133:

   media: mediatek: vcodec: Set the supported vp9 profile for each platform (2023-10-26 09:09:21 +0200)

----------------------------------------------------------------
Mediatek Codec patches for 6.7

----------------------------------------------------------------
Yunfei Dong (7):
       media: mediatek: vcodec: Get the chip name for each platform
       media: mediatek: vcodec: Set the supported h264 level for each platform
       media: mediatek: vcodec: Set the supported h265 level for each platform
       media: mediatek: vcodec: Set the supported h264 profile for each platform
       media: mediatek: vcodec: Set the supported h265 profile for each platform
       media: mediatek: vcodec: Set the supported vp9 level for each platform
       media: mediatek: vcodec: Set the supported vp9 profile for each platform

  drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec.c           |  24 +-----------------
  drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c       |  26 ++++++++++++++++++++
  drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h       |  14 +++++++++++
  drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
  4 files changed, 208 insertions(+), 24 deletions(-)

Greetings,
Sebastian

Comments

Jenkins Oct. 27, 2023, 9:23 a.m. UTC | #1 
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/20231027085058.k65rwgxepmx5ivu5@basti-XPS-13-9310/
Build log: https://builder.linuxtv.org/job/patchwork/351833/
Build time: 00:24:29
Link: https://lore.kernel.org/linux-media/20231027085058.k65rwgxepmx5ivu5@basti-XPS-13-9310

gpg: Signature made Thu 26 Oct 2023 07:15:57 AM UTC
gpg:                using RSA key C114F6B109AD086C02B4920F7D4612BF5E76A4F0
gpg: Can't check signature: No public key

Summary: got 1/7 patches with issues, being 1 at build time

Error/warnings:

patches/0001-media-mediatek-vcodec-Get-the-chip-name-for-each-pla.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

    allyesconfig: return code #0:
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/pci/cx25821/cx25821-medusa-video.c: ../drivers/media/pci/cx25821/cx25821-medusa-video.c:399 medusa_set_videostandard() parse error: OOM: 3003988Kb sm_state_count = 2158
	../drivers/media/pci/cx25821/cx25821-medusa-video.c: ../drivers/media/pci/cx25821/cx25821-medusa-video.c:399 medusa_set_videostandard() parse error: __split_smt: function too hairy.  Giving up after 5 seconds
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2517 dvb_register() parse error: OOM: 3014568Kb sm_state_count = 1757213
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2517 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 54 seconds
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2858 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1974 vivid_create_instance() parse error: turning off implications after 60 seconds
Mauro Carvalho Chehab Nov. 23, 2023, 10:02 a.m. UTC | #2 
Em Fri, 27 Oct 2023 10:50:58 +0200
Sebastian Fricke <sebastian.fricke@collabora.com> escreveu:

> Hey Mauro and Hans,
> 
> first attempt at doing a PR, could you please check and pull this?
> 
> The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> 
>    media: venus: Fix firmware path for resources (2023-10-23 12:24:53 +0200)
> 
> are available in the Git repository at:
> 
>    https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed
> 
> for you to fetch changes up to ccd08a80f5e1844819874b01c5ff61e18aa9e133:
> 
>    media: mediatek: vcodec: Set the supported vp9 profile for each platform (2023-10-26 09:09:21 +0200)


Checkpatch is producing some warnings here:

WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#32: 
The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 19e67e01eb1e ("media: venus: Fix firmware path for resources")'
#32: 
The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:

ERROR:NOT_UNIFIED_DIFF: Does not appear to be a unified-diff format patch

Could you please double-check those?

Regards,
Mauro

> 
> ----------------------------------------------------------------
> Mediatek Codec patches for 6.7
> 
> ----------------------------------------------------------------
> Yunfei Dong (7):
>        media: mediatek: vcodec: Get the chip name for each platform
>        media: mediatek: vcodec: Set the supported h264 level for each platform
>        media: mediatek: vcodec: Set the supported h265 level for each platform
>        media: mediatek: vcodec: Set the supported h264 profile for each platform
>        media: mediatek: vcodec: Set the supported h265 profile for each platform
>        media: mediatek: vcodec: Set the supported vp9 level for each platform
>        media: mediatek: vcodec: Set the supported vp9 profile for each platform
> 
>   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec.c           |  24 +-----------------
>   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c       |  26 ++++++++++++++++++++
>   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h       |  14 +++++++++++
>   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   4 files changed, 208 insertions(+), 24 deletions(-)
> 
> Greetings,
> Sebastian



Thanks,
Mauro
Chen-Yu Tsai Nov. 23, 2023, 10:38 a.m. UTC | #3 
On Thu, Nov 23, 2023 at 6:02 PM Mauro Carvalho Chehab
<mchehab@kernel.org> wrote:
>
> Em Fri, 27 Oct 2023 10:50:58 +0200
> Sebastian Fricke <sebastian.fricke@collabora.com> escreveu:
>
> > Hey Mauro and Hans,
> >
> > first attempt at doing a PR, could you please check and pull this?
> >
> > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> >
> >    media: venus: Fix firmware path for resources (2023-10-23 12:24:53 +0200)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed
> >
> > for you to fetch changes up to ccd08a80f5e1844819874b01c5ff61e18aa9e133:
> >
> >    media: mediatek: vcodec: Set the supported vp9 profile for each platform (2023-10-26 09:09:21 +0200)
>
>
> Checkpatch is producing some warnings here:
>
> WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #32:
> The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
>
> ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 19e67e01eb1e ("media: venus: Fix firmware path for resources")'
> #32:
> The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
>
> ERROR:NOT_UNIFIED_DIFF: Does not appear to be a unified-diff format patch
>
> Could you please double-check those?

It seems like you ran checkpatch against this pull request email, not
the patches to be pulled in?

ChenYu

> Regards,
> Mauro
>
> >
> > ----------------------------------------------------------------
> > Mediatek Codec patches for 6.7
> >
> > ----------------------------------------------------------------
> > Yunfei Dong (7):
> >        media: mediatek: vcodec: Get the chip name for each platform
> >        media: mediatek: vcodec: Set the supported h264 level for each platform
> >        media: mediatek: vcodec: Set the supported h265 level for each platform
> >        media: mediatek: vcodec: Set the supported h264 profile for each platform
> >        media: mediatek: vcodec: Set the supported h265 profile for each platform
> >        media: mediatek: vcodec: Set the supported vp9 level for each platform
> >        media: mediatek: vcodec: Set the supported vp9 profile for each platform
> >
> >   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec.c           |  24 +-----------------
> >   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c       |  26 ++++++++++++++++++++
> >   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h       |  14 +++++++++++
> >   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >   4 files changed, 208 insertions(+), 24 deletions(-)
> >
> > Greetings,
> > Sebastian
>
>
>
> Thanks,
> Mauro
>
Mauro Carvalho Chehab Nov. 23, 2023, 6:31 p.m. UTC | #4 
Em Thu, 23 Nov 2023 18:38:38 +0800
Chen-Yu Tsai <wens@kernel.org> escreveu:

> On Thu, Nov 23, 2023 at 6:02 PM Mauro Carvalho Chehab
> <mchehab@kernel.org> wrote:
> >
> > Em Fri, 27 Oct 2023 10:50:58 +0200
> > Sebastian Fricke <sebastian.fricke@collabora.com> escreveu:
> >  
> > > Hey Mauro and Hans,
> > >
> > > first attempt at doing a PR, could you please check and pull this?
> > >
> > > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> > >
> > >    media: venus: Fix firmware path for resources (2023-10-23 12:24:53 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > >    https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed
> > >
> > > for you to fetch changes up to ccd08a80f5e1844819874b01c5ff61e18aa9e133:
> > >
> > >    media: mediatek: vcodec: Set the supported vp9 profile for each platform (2023-10-26 09:09:21 +0200)  
> >
> >
> > Checkpatch is producing some warnings here:
> >
> > WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> > #32:
> > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> >
> > ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 19e67e01eb1e ("media: venus: Fix firmware path for resources")'
> > #32:
> > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> >
> > ERROR:NOT_UNIFIED_DIFF: Does not appear to be a unified-diff format patch
> >
> > Could you please double-check those?  
> 
> It seems like you ran checkpatch against this pull request email, not
> the patches to be pulled in?

True. The problem seems to be due to whatever tool Sebastian made this PR.

My scripts rely on the format produced by "git pull", being picky with
the URL there. In particular, on Sebastian's PR, the URL is:

   https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed

(3 spaces before URL)

While git request-pull produces:

  https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed

(2 spaces before URL)

Anyway, PR applied by Hans.

Regards,
Mauro