Message ID | 20231030100022.9262-4-moudy.ho@mediatek.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Hans Verkuil |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1qxP5z-00BW6Z-L9; Mon, 30 Oct 2023 10:02:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233197AbjJ3KCH (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 30 Oct 2023 06:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbjJ3KBD (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 30 Oct 2023 06:01:03 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E131700; Mon, 30 Oct 2023 03:00:33 -0700 (PDT) X-UUID: 25411c7e770b11ee8051498923ad61e6-20231030 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=ToxDj4Jh9UEI1Nb/YtvDgd8K3/Q8XFBBACqcPBFHRYc=; b=utcSVT0wKvhKehYCl/VuBY3FO/YIJFAK03+xdvnTbLCqRSltWbKMvq/erSZiLpuOGa6fS2yvFIsLV/m36PTsWqXOcmmzS2CJFihvLvR+3XGF7IFJXyhANNJroyC86tRIX3NbLl3HSE8vsl5pmMOgUYhLwTNtbZySELS7U3Z9bO4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:f7b3f16b-dcb5-4aeb-9a65-d333931879dd,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5f78ec9,CLOUDID:78c3cb94-10ce-4e4b-85c2-c9b5229ff92b,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 25411c7e770b11ee8051498923ad61e6-20231030 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from <moudy.ho@mediatek.com>) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1356428682; Mon, 30 Oct 2023 18:00:24 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 30 Oct 2023 18:00:23 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 30 Oct 2023 18:00:23 +0800 From: Moudy Ho <moudy.ho@mediatek.com> To: Chun-Kuang Hu <chunkuang.hu@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl> CC: <dri-devel@lists.freedesktop.org>, <linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Moudy Ho <moudy.ho@mediatek.com> Subject: [PATCH v8 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA Date: Mon, 30 Oct 2023 18:00:09 +0800 Message-ID: <20231030100022.9262-4-moudy.ho@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20231030100022.9262-1-moudy.ho@mediatek.com> References: <20231030100022.9262-1-moudy.ho@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no |
Series |
introduce more MDP3 components in MT8195
|
|
Commit Message
Moudy Ho (何宗原)
Oct. 30, 2023, 10 a.m. UTC
Added the configuration for MT8195 RDMA. In comparison to MT8183, it no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox. Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-)
Comments
On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote: > Added the configuration for MT8195 RDMA. In comparison to MT8183, it > no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index c043204cf210..504334a76fb3 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -22,6 +22,7 @@ properties: > compatible: > enum: > - mediatek,mt8183-mdp3-rdma > + - mediatek,mt8195-mdp3-rdma > - mediatek,mt8195-vdo1-rdma > > reg: > @@ -58,7 +59,7 @@ properties: > > mboxes: > minItems: 1 > - maxItems: 2 > + maxItems: 5 > > interrupts: > maxItems: 1 > @@ -98,6 +99,29 @@ allOf: > - mboxes > - mediatek,gce-events > > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8195-mdp3-rdma > + > + then: > + properties: > + clocks: > + items: > + - description: RDMA clock > + > + mboxes: > + items: > + - description: used for 1st data pipe from RDMA > + - description: used for 2nd data pipe from RDMA > + - description: used for 3rd data pipe from RDMA > + - description: used for 4th data pipe from RDMA > + - description: used for the data pipe from SPLIT Following the prior comments, add these entries to the top-level 'mboxes' and then here just put 'minItems: 5'. Rob
On Mon, 2023-10-30 at 14:26 -0500, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote: > > Added the configuration for MT8195 RDMA. In comparison to MT8183, > it > > no longer shares SRAM with RSZ, and there are now preconfigured 5 > mbox. > > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/media/mediatek,mdp3-rdma.yaml | 26 > ++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > index c043204cf210..504334a76fb3 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > @@ -22,6 +22,7 @@ properties: > > compatible: > > enum: > > - mediatek,mt8183-mdp3-rdma > > + - mediatek,mt8195-mdp3-rdma > > - mediatek,mt8195-vdo1-rdma > > > > reg: > > @@ -58,7 +59,7 @@ properties: > > > > mboxes: > > minItems: 1 > > - maxItems: 2 > > + maxItems: 5 > > > > interrupts: > > maxItems: 1 > > @@ -98,6 +99,29 @@ allOf: > > - mboxes > > - mediatek,gce-events > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: mediatek,mt8195-mdp3-rdma > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: RDMA clock > > + > > + mboxes: > > + items: > > + - description: used for 1st data pipe from RDMA > > + - description: used for 2nd data pipe from RDMA > > + - description: used for 3rd data pipe from RDMA > > + - description: used for 4th data pipe from RDMA > > + - description: used for the data pipe from SPLIT > > Following the prior comments, add these entries to the top-level > 'mboxes' and then here just put 'minItems: 5'. > > Rob Hi Rob, Thanks for assisting with the review and suggesting an improved method in patch [2/16] and here for bounding related item quantites. I have a question regarding the current item description. It seems to imply a specific order. If the order of the description is different for any reason, should it be fully re-listed under 'allOf'? Sincerely, Moudy
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml index c043204cf210..504334a76fb3 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml @@ -22,6 +22,7 @@ properties: compatible: enum: - mediatek,mt8183-mdp3-rdma + - mediatek,mt8195-mdp3-rdma - mediatek,mt8195-vdo1-rdma reg: @@ -58,7 +59,7 @@ properties: mboxes: minItems: 1 - maxItems: 2 + maxItems: 5 interrupts: maxItems: 1 @@ -98,6 +99,29 @@ allOf: - mboxes - mediatek,gce-events + - if: + properties: + compatible: + contains: + const: mediatek,mt8195-mdp3-rdma + + then: + properties: + clocks: + items: + - description: RDMA clock + + mboxes: + items: + - description: used for 1st data pipe from RDMA + - description: used for 2nd data pipe from RDMA + - description: used for 3rd data pipe from RDMA + - description: used for 4th data pipe from RDMA + - description: used for the data pipe from SPLIT + + required: + - mediatek,gce-events + - if: properties: compatible: