Message ID | 20231010091643.3666290-2-hugues.fruchet@foss.st.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Hans Verkuil |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1qq8rk-00BQSe-WC; Tue, 10 Oct 2023 09:17:25 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbjJJJRW (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 10 Oct 2023 05:17:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjJJJRT (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 10 Oct 2023 05:17:19 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE6A9A4; Tue, 10 Oct 2023 02:17:17 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39A8CLSL030787; Tue, 10 Oct 2023 11:16:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= selector1; bh=LFAa4Jn4tiEfEImWcrbUI//FcIw/xnpf/WL80D9ScuQ=; b=fu UOP3wTOpnnoj3auZA7Q7ZJO6nLqBnLclg3GtjTb0cpQsaAct+tpjpR5bJaKu2hH8 w54YxZBXYv2g8Ab62qHvVDhYfp0lGFAPUsoWYtGxiVQTxI6cXojYk4zfchRyxxYW 2p0YaAFHzts2gknBB0iwtd1sjZWTWDa00wyZDveO5asYtxxgUQXKDALjeoS0JnXB PcObO3mnmLbdz3T17QhOiB0ajWL7Nh032oNqT3TSk1zvbI+QtLUgJzDdcahQ0BJ/ PFIIrqivWtEIRda+LLl5fQ2ngJ9cajZyG027sMqB9HIjZqlMcK6rTXdRHXpDLFk5 hnfQhERgBa9Fe4GlsKiA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3tkhfe16c5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Oct 2023 11:16:48 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A451210005E; Tue, 10 Oct 2023 11:16:47 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9B94121BF6A; Tue, 10 Oct 2023 11:16:47 +0200 (CEST) Received: from localhost (10.201.20.120) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 10 Oct 2023 11:16:47 +0200 From: Hugues Fruchet <hugues.fruchet@foss.st.com> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Philipp Zabel <p.zabel@pengutronix.de>, Andrzej Pietrasiewicz <andrzej.p@collabora.com>, Nicolas Dufresne <nicolas.dufresne@collabora.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Benjamin Gaignard <benjamin.gaignard@collabora.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Daniel Almeida <daniel.almeida@collabora.com>, Benjamin Mugnier <benjamin.mugnier@foss.st.com>, Heiko Stuebner <heiko@sntech.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, <linux-media@vger.kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, <linux-stm32@st-md-mailman.stormreply.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-rockchip@lists.infradead.org> CC: Hugues Fruchet <hugues.fruchet@foss.st.com>, Marco Felsch <m.felsch@pengutronix.de>, Adam Ford <aford173@gmail.com> Subject: [PATCH v2 1/5] dt-bindings: media: Document STM32MP25 VDEC & VENC video codecs Date: Tue, 10 Oct 2023 11:16:39 +0200 Message-ID: <20231010091643.3666290-2-hugues.fruchet@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231010091643.3666290-1-hugues.fruchet@foss.st.com> References: <20231010091643.3666290-1-hugues.fruchet@foss.st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.201.20.120] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-10_04,2023-10-09_01,2023-05-22_02 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
Add support for video hardware codec of STMicroelectronics STM32 SoC series
|
|
Commit Message
Hugues FRUCHET
Oct. 10, 2023, 9:16 a.m. UTC
Add STM32MP25 VDEC video decoder & VENC video encoder bindings.
Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
---
.../media/st,stm32mp25-video-codec.yaml | 58 +++++++++++++++++++
1 file changed, 58 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml
Comments
Hey, On Tue, Oct 10, 2023 at 11:16:39AM +0200, Hugues Fruchet wrote: > Add STM32MP25 VDEC video decoder & VENC video encoder bindings. > > Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com> > --- > .../media/st,stm32mp25-video-codec.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > > diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > new file mode 100644 > index 000000000000..479566171568 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/st,stm32mp25-video-codec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32MP25 VDEC video decoder & VENC video encoder > + > +maintainers: > + - Hugues Fruchet <hugues.fruchet@foss.st.com> > + > +description: > + The STMicroelectronics STM32MP25 SOCs embeds a VDEC video hardware > + decoder peripheral based on Verisilicon VC8000NanoD IP (former Hantro G1) > + and a VENC video hardware encoder peripheral based on Verisilicon > + VC8000NanoE IP (former Hantro H1). > + > +properties: > + compatible: > + items: This "items:" is not needed, the enum on its own is enough. > + - enum: > + - st,stm32mp25-vdec > + - st,stm32mp25-venc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + vdec: video-codec@580d0000 { The node labels for both nodes here are not used & should be dropped. Otherwise, this seems fine to me. Cheers, Conor. > + compatible = "st,stm32mp25-vdec"; > + reg = <0x580d0000 0x3c8>; > + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ck_icn_p_vdec>; > + }; > + - | > + venc: video-codec@580e0000 { > + compatible = "st,stm32mp25-venc"; > + reg = <0x580e0000 0x800>; > + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ck_icn_p_venc>; > + }; > -- > 2.25.1 >
Hi Conor, Will do all in v3, thanks ! On 10/11/23 17:55, Conor Dooley wrote: > Hey, > > On Tue, Oct 10, 2023 at 11:16:39AM +0200, Hugues Fruchet wrote: >> Add STM32MP25 VDEC video decoder & VENC video encoder bindings. >> >> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com> >> --- >> .../media/st,stm32mp25-video-codec.yaml | 58 +++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml >> new file mode 100644 >> index 000000000000..479566171568 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml >> @@ -0,0 +1,58 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> + >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/st,stm32mp25-video-codec.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: STMicroelectronics STM32MP25 VDEC video decoder & VENC video encoder >> + >> +maintainers: >> + - Hugues Fruchet <hugues.fruchet@foss.st.com> >> + >> +description: >> + The STMicroelectronics STM32MP25 SOCs embeds a VDEC video hardware >> + decoder peripheral based on Verisilicon VC8000NanoD IP (former Hantro G1) >> + and a VENC video hardware encoder peripheral based on Verisilicon >> + VC8000NanoE IP (former Hantro H1). >> + >> +properties: >> + compatible: >> + items: > > This "items:" is not needed, the enum on its own is enough. > >> + - enum: >> + - st,stm32mp25-vdec >> + - st,stm32mp25-venc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + vdec: video-codec@580d0000 { > > The node labels for both nodes here are not used & should be dropped. > > Otherwise, this seems fine to me. > > Cheers, > Conor. > >> + compatible = "st,stm32mp25-vdec"; >> + reg = <0x580d0000 0x3c8>; >> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ck_icn_p_vdec>; >> + }; >> + - | >> + venc: video-codec@580e0000 { >> + compatible = "st,stm32mp25-venc"; >> + reg = <0x580e0000 0x800>; >> + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ck_icn_p_venc>; >> + }; >> -- >> 2.25.1 >> BR, Hugues.
On 10/10/2023 11:16, Hugues Fruchet wrote: > Add STM32MP25 VDEC video decoder & VENC video encoder bindings. > > Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com> > --- > .../media/st,stm32mp25-video-codec.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > > diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > new file mode 100644 > index 000000000000..479566171568 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/st,stm32mp25-video-codec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32MP25 VDEC video decoder & VENC video encoder > + > +maintainers: > + - Hugues Fruchet <hugues.fruchet@foss.st.com> > + > +description: > + The STMicroelectronics STM32MP25 SOCs embeds a VDEC video hardware > + decoder peripheral based on Verisilicon VC8000NanoD IP (former Hantro G1) > + and a VENC video hardware encoder peripheral based on Verisilicon > + VC8000NanoE IP (former Hantro H1). > + > +properties: > + compatible: > + items: Drop "items", we keep simple enum in such case. > + - enum: > + - st,stm32mp25-vdec > + - st,stm32mp25-venc > + > + reg: > + maxItems: 1 > + ... > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + vdec: video-codec@580d0000 { > + compatible = "st,stm32mp25-vdec"; > + reg = <0x580d0000 0x3c8>; > + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ck_icn_p_vdec>; > + }; > + - | > + venc: video-codec@580e0000 { > + compatible = "st,stm32mp25-venc"; > + reg = <0x580e0000 0x800>; > + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ck_icn_p_venc>; > + }; You can drop second example - it is the same as the first. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml new file mode 100644 index 000000000000..479566171568 --- /dev/null +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/st,stm32mp25-video-codec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STM32MP25 VDEC video decoder & VENC video encoder + +maintainers: + - Hugues Fruchet <hugues.fruchet@foss.st.com> + +description: + The STMicroelectronics STM32MP25 SOCs embeds a VDEC video hardware + decoder peripheral based on Verisilicon VC8000NanoD IP (former Hantro G1) + and a VENC video hardware encoder peripheral based on Verisilicon + VC8000NanoE IP (former Hantro H1). + +properties: + compatible: + items: + - enum: + - st,stm32mp25-vdec + - st,stm32mp25-venc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + vdec: video-codec@580d0000 { + compatible = "st,stm32mp25-vdec"; + reg = <0x580d0000 0x3c8>; + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ck_icn_p_vdec>; + }; + - | + venc: video-codec@580e0000 { + compatible = "st,stm32mp25-venc"; + reg = <0x580e0000 0x800>; + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ck_icn_p_venc>; + };