staging: vc04_services: vchiq_bus: Do not kfree device
Commit Message
As per device_register() documentation, this kfree() on error path will
crash. The call to put_device() is all that is needed here to free the
memory.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Mon, Oct 09, 2023 at 11:39:06AM +0530, Umang Jain wrote:
> As per device_register() documentation, this kfree() on error path will
> crash. The call to put_device() is all that is needed here to free the
> memory.
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c | 1 -
> 1 file changed, 1 deletion(-)
This needs a "Fixes:" tag, right?
thanks,
greg k-h
@@ -73,7 +73,6 @@ vchiq_device_register(struct device *parent, const char *name)
if (ret) {
dev_err(parent, "Cannot register %s: %d\n", name, ret);
put_device(&device->dev);
- kfree(device);
return NULL;
}