| Message ID | 20110526084912.1ac3ac37@tele (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Thu, 26 May 2011 05:28:17 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1QPVvU-0006Y5-OO for mchehab@pedra; Thu, 26 May 2011 05:28:17 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 26 May 2011 05:28:16 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QPUTJ-0007fg-0B; Thu, 26 May 2011 06:55:05 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521Ab1EZGsi (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 26 May 2011 02:48:38 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:34041 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767Ab1EZGsh convert rfc822-to-8bit (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 26 May 2011 02:48:37 -0400 Received: from tele (unknown [82.245.201.222]) by smtp5-g21.free.fr (Postfix) with ESMTP id 39FDCD4804B for <linux-media@vger.kernel.org>; Thu, 26 May 2011 08:48:30 +0200 (CEST) Date: Thu, 26 May 2011 08:49:12 +0200 From: Jean-Francois Moine <moinejf@free.fr> To: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org> Subject: Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG Message-ID: <20110526084912.1ac3ac37@tele> In-Reply-To: <1306359272-30792-1-git-send-email-jarod@redhat.com> References: <1306305788.2390.4.camel@porites> <1306359272-30792-1-git-send-email-jarod@redhat.com> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Jean-Francois Moine
May 26, 2011, 6:49 a.m. UTC
On Wed, 25 May 2011 17:34:32 -0400 Jarod Wilson <jarod@redhat.com> wrote: > diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c > index 66671a4..26fc206 100644 > --- a/drivers/media/video/gspca/kinect.c > +++ b/drivers/media/video/gspca/kinect.c > @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>"); > MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver"); > MODULE_LICENSE("GPL"); > > -#ifdef DEBUG > +#ifdef GSPCA_DEBUG > int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK | > D_USBI | D_USBO | D_V4L2; > #endif Hi Jarod, Sorry, it is not the right fix. In fact, the variable gspca_debug must not be defined in gspca subdrivers:
Comments
On Thu, 26 May 2011 08:49:12 +0200 Jean-Francois Moine <moinejf@free.fr> wrote: > On Wed, 25 May 2011 17:34:32 -0400 > Jarod Wilson <jarod@redhat.com> wrote: > > > diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c > > index 66671a4..26fc206 100644 > > --- a/drivers/media/video/gspca/kinect.c > > +++ b/drivers/media/video/gspca/kinect.c > > @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>"); > > MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver"); > > MODULE_LICENSE("GPL"); > > > > -#ifdef DEBUG > > +#ifdef GSPCA_DEBUG > > int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK | > > D_USBI | D_USBO | D_V4L2; > > #endif > > Hi Jarod, > > Sorry, it is not the right fix. In fact, the variable gspca_debug must > not be defined in gspca subdrivers: > > --- a/drivers/media/video/gspca/kinect.c > +++ b/drivers/media/video/gspca/kinect.c > @@ -34,11 +34,6 @@ > MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver"); > MODULE_LICENSE("GPL"); > > -#ifdef DEBUG > -int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK | > - D_USBI | D_USBO | D_V4L2; > -#endif > - > struct pkt_hdr { > uint8_t magic[2]; > uint8_t pad; > OK. Thanks, Antonio
On May 26, 2011, at 2:49 AM, jean-francois Moine wrote: > On Wed, 25 May 2011 17:34:32 -0400 > Jarod Wilson <jarod@redhat.com> wrote: > >> diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c >> index 66671a4..26fc206 100644 >> --- a/drivers/media/video/gspca/kinect.c >> +++ b/drivers/media/video/gspca/kinect.c >> @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>"); >> MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver"); >> MODULE_LICENSE("GPL"); >> >> -#ifdef DEBUG >> +#ifdef GSPCA_DEBUG >> int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK | >> D_USBI | D_USBO | D_V4L2; >> #endif > > Hi Jarod, > > Sorry, it is not the right fix. In fact, the variable gspca_debug must > not be defined in gspca subdrivers: > > --- a/drivers/media/video/gspca/kinect.c > +++ b/drivers/media/video/gspca/kinect.c > @@ -34,11 +34,6 @@ > MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver"); > MODULE_LICENSE("GPL"); > > -#ifdef DEBUG > -int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK | > - D_USBI | D_USBO | D_V4L2; > -#endif > - > struct pkt_hdr { > uint8_t magic[2]; > uint8_t pad; Ah, ok, that works just as well for me, since I don't have the hardware, was just looking to make sure things still complied. ;)
--- a/drivers/media/video/gspca/kinect.c +++ b/drivers/media/video/gspca/kinect.c @@ -34,11 +34,6 @@ MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver"); MODULE_LICENSE("GPL"); -#ifdef DEBUG -int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK | - D_USBI | D_USBO | D_V4L2; -#endif - struct pkt_hdr { uint8_t magic[2]; uint8_t pad;