[-next] media: davinci: vpif_capture: fix error return code in vpif_probe()
Commit Message
Set error return code, when get platform data failed.
Fixes: b4a4547371b9 ("media: davinci: Init async notifier after registering V4L2 device")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/ti/davinci/vpif_capture.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, Aug 3, 2023 at 3:21 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Set error return code, when get platform data failed.
>
> Fixes: b4a4547371b9 ("media: davinci: Init async notifier after registering V4L2 device")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/ti/davinci/vpif_capture.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
Prabhakar
> diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/media/platform/ti/davinci/vpif_capture.c
> index bf5330b6fcd5..99fae8830c41 100644
> --- a/drivers/media/platform/ti/davinci/vpif_capture.c
> +++ b/drivers/media/platform/ti/davinci/vpif_capture.c
> @@ -1644,6 +1644,7 @@ static __init int vpif_probe(struct platform_device *pdev)
> pdev->dev.platform_data =
> vpif_capture_get_pdata(pdev, &vpif_obj.v4l2_dev);
> if (!pdev->dev.platform_data) {
> + err = -EINVAL;
> dev_warn(&pdev->dev, "Missing platform data. Giving up.\n");
> goto vpif_unregister;
> }
> --
> 2.25.1
>
@@ -1644,6 +1644,7 @@ static __init int vpif_probe(struct platform_device *pdev)
pdev->dev.platform_data =
vpif_capture_get_pdata(pdev, &vpif_obj.v4l2_dev);
if (!pdev->dev.platform_data) {
+ err = -EINVAL;
dev_warn(&pdev->dev, "Missing platform data. Giving up.\n");
goto vpif_unregister;
}