Message ID | 20110328082305.c6fa41d9.randy.dunlap@oracle.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Mon, 28 Mar 2011 12:24:23 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1Q4EIp-0001PR-5R for mchehab@pedra; Mon, 28 Mar 2011 12:24:23 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Mon, 28 Mar 2011 12:24:23 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Q4EI9-0003Tt-NP; Mon, 28 Mar 2011 15:23:42 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754251Ab1C1PXZ (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 28 Mar 2011 11:23:25 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:36655 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753269Ab1C1PXY (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 28 Mar 2011 11:23:24 -0400 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p2SFNBfB021982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Mar 2011 15:23:12 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p2SFNAB3019414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Mar 2011 15:23:10 GMT Received: from abhmt012.oracle.com (abhmt012.oracle.com [141.146.116.21]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p2SFN9rV028382; Mon, 28 Mar 2011 10:23:09 -0500 Received: from chimera.site (/173.50.240.230) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 28 Mar 2011 08:23:07 -0700 Date: Mon, 28 Mar 2011 08:23:05 -0700 From: Randy Dunlap <randy.dunlap@oracle.com> To: linux-media@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>, gregkh@suse.de Cc: Mauro Carvalho Chehab <mchehab@infradead.org>, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, "Igor M. Liplianin" <liplianin@netup.ru> Subject: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h Message-Id: <20110328082305.c6fa41d9.randy.dunlap@oracle.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt358.oracle.com [141.146.40.158] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4D90A7DF.00DA,ss=1,fgs=0 Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Randy Dunlap
March 28, 2011, 3:23 p.m. UTC
From: Randy Dunlap <randy.dunlap@oracle.com> altera-jtag.c needs to include <linux/delay.h> to fix a build error: drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Igor M. Liplianin <liplianin@netup.ru> --- drivers/staging/altera-stapl/altera-jtag.c | 1 + 1 file changed, 1 insertion(+) Somehow I was supposed to know to send this to Mauro instead of to Greg, but I don't see anything in drivers/staging/altera-stapl/ that says that. -- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Em 28-03-2011 12:23, Randy Dunlap escreveu: > From: Randy Dunlap <randy.dunlap@oracle.com> > > altera-jtag.c needs to include <linux/delay.h> to fix a build error: > > drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > Cc: Igor M. Liplianin <liplianin@netup.ru> > --- > drivers/staging/altera-stapl/altera-jtag.c | 1 + > 1 file changed, 1 insertion(+) > > Somehow I was supposed to know to send this to Mauro instead of to Greg, > but I don't see anything in drivers/staging/altera-stapl/ that says that. Ah, yes, we need to add a readme file there stating about that. Greg, you may add it on your tree, or if you prefer, I can just add here for my next upstream pull. Thanks, Mauro. > > > --- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c > +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c > @@ -23,6 +23,7 @@ > * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > */ > > +#include <linux/delay.h> > #include <linux/firmware.h> > #include <linux/slab.h> > #include <staging/altera.h> > -- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote: > Em 28-03-2011 12:23, Randy Dunlap escreveu: > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > altera-jtag.c needs to include <linux/delay.h> to fix a build error: > > > > drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > > > Cc: Igor M. Liplianin <liplianin@netup.ru> > > --- > > drivers/staging/altera-stapl/altera-jtag.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Somehow I was supposed to know to send this to Mauro instead of to Greg, > > but I don't see anything in drivers/staging/altera-stapl/ that says that. > > Ah, yes, we need to add a readme file there stating about that. > > Greg, you may add it on your tree, or if you prefer, I can just add here for > my next upstream pull. I see this in my tree already, git commit 92ce52695ccf2b6c4ef7eb02e1bee1bcbf5fde89, what happened to need this again? confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/19/11 13:39, Greg KH wrote: > On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote: >> Em 28-03-2011 12:23, Randy Dunlap escreveu: >>> From: Randy Dunlap <randy.dunlap@oracle.com> >>> >>> altera-jtag.c needs to include <linux/delay.h> to fix a build error: >>> >>> drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> >> >>> Cc: Igor M. Liplianin <liplianin@netup.ru> >>> --- >>> drivers/staging/altera-stapl/altera-jtag.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> Somehow I was supposed to know to send this to Mauro instead of to Greg, >>> but I don't see anything in drivers/staging/altera-stapl/ that says that. >> >> Ah, yes, we need to add a readme file there stating about that. >> >> Greg, you may add it on your tree, or if you prefer, I can just add here for >> my next upstream pull. > > I see this in my tree already, git commit > 92ce52695ccf2b6c4ef7eb02e1bee1bcbf5fde89, what happened to need this > again? I think that Mauro is just replying to old emails (guess he's just trying to catch up...).
--- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c @@ -23,6 +23,7 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ +#include <linux/delay.h> #include <linux/firmware.h> #include <linux/slab.h> #include <staging/altera.h>