mbox

[GIT,PATCHES,FOR,2.6.40] gspca for_v2.6.40

Message ID 20110517105417.1b96f66c@tele (mailing list archive)
State Superseded, archived
Headers

Pull-request

git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Message

Jean-Francois Moine May 17, 2011, 8:54 a.m. UTC 
  The following changes since commit
f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

  [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Jean-François Moine (10):
      gspca - cpia1: Fix some warnings.
      gspca - kinect: Remove __devinitdata
      gspca - stk014 / t613: Accept the index 0 in querymenu
      gspca - main: Version change to 2.13
      gspca - main: Remove USB traces
      gspca - cpia1: Remove a bad conditional compilation instruction
      gspca: Unset debug by default
      gspca: Fix some warnings tied to 'no debug'
      gspca - sunplus: Simplify code and fix some warnings
      gspca - sunplus: Simplify code and fix some errors when 'debug'

 drivers/media/video/gspca/cpia1.c       |    6 +--
 drivers/media/video/gspca/gl860/gl860.c |   15 +----
 drivers/media/video/gspca/gspca.c       |    4 +-
 drivers/media/video/gspca/gspca.h       |    6 +-
 drivers/media/video/gspca/kinect.c      |    2 +-
 drivers/media/video/gspca/spca508.c     |    5 +-
 drivers/media/video/gspca/stk014.c      |   15 ++---
 drivers/media/video/gspca/sunplus.c     |   99 ++++++++++--------------------
 drivers/media/video/gspca/t613.c        |   17 ++----
 drivers/media/video/gspca/zc3xx.c       |    5 +-
 10 files changed, 61 insertions(+), 113 deletions(-)

Comments

Antonio Ospite May 17, 2011, 9:36 a.m. UTC | #1 
On Tue, 17 May 2011 10:54:17 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> The following changes since commit
> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
> 
>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
> 
[...]

Hi Jean-Francois, sometimes it is useful to add also a "why" section to
commit messages so others can follow your thoughts, and even learn from
them.

I have this very simple scheme: a summary of the "what" goes into the
short commit message and the "why" and "how" go into the long commit
message when they are not immediately trivial from the code; for
instance the "why" of the USB trace changes in this series wasn't
trivial to me.

Thanks,
   Antonio
Mauro Carvalho Chehab May 20, 2011, 2:43 p.m. UTC | #2 
Em 17-05-2011 06:36, Antonio Ospite escreveu:
> On Tue, 17 May 2011 10:54:17 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
>> The following changes since commit
>> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
>>
>>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)
>>
>> are available in the git repository at:
>>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
>>
> [...]
> 
> Hi Jean-Francois, sometimes it is useful to add also a "why" section to
> commit messages so others can follow your thoughts, and even learn from
> them.
> 
> I have this very simple scheme: a summary of the "what" goes into the
> short commit message and the "why" and "how" go into the long commit
> message when they are not immediately trivial from the code; for
> instance the "why" of the USB trace changes in this series wasn't
> trivial to me.

Yeah, providing a good documentation is important to allow the others to know what's
happening at the driver.

Jean-Francois,

Could you please add more comments to your patch series? I'll discard this pull
request from my queue. So, feel free to re-base your tree if you need.

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html