Message ID | 20230616135922.442979-17-tomi.valkeinen@ideasonboard.com (mailing list archive) |
---|---|
State | Superseded |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1qAA1L-003Ja9-Rg; Fri, 16 Jun 2023 14:01:48 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345674AbjFPOBj (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 16 Jun 2023 10:01:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345503AbjFPOBS (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 16 Jun 2023 10:01:18 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10E443A9D; Fri, 16 Jun 2023 07:00:45 -0700 (PDT) Received: from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A81BD51; Fri, 16 Jun 2023 16:00:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686924004; bh=eF3z6F3qkfaZWengl1rJ9UScYHxSbFdIgkIxfPM3nIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YhKCcGXHnP4mKRmxlveZIsEzFYPGB7LDo6vEXMNpKAK3O8a9XuhyOxJfngpOqNP3o tFgx3C8JMQUSICiyggRQoAqv6361pVkMon0XD6ZhgUm8vxEZYXbnYWyPLyY2X0moqI qz3d+Ox6vy3ZQFG/RitHhH3xYCE2e6WGHc+OqWMo= From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Luca Ceresoli <luca.ceresoli@bootlin.com>, Andy Shevchenko <andriy.shevchenko@intel.com>, Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Peter Rosin <peda@axentia.se>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Michael Tretter <m.tretter@pengutronix.de>, Hans Verkuil <hverkuil@xs4all.nl>, Mike Pagano <mpagano@gentoo.org>, =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>, Marek Vasut <marex@denx.de>, Satish Nagireddy <satish.nagireddy@getcruise.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: [PATCH v14 16/18] media: i2c: ds90ub960: Allow FPD-Link async mode Date: Fri, 16 Jun 2023 16:59:20 +0300 Message-Id: <20230616135922.442979-17-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com> References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
i2c-atr and FPDLink
|
|
Commit Message
Tomi Valkeinen
June 16, 2023, 1:59 p.m. UTC
Allow using FPD-Link in async mode. The driver handles it correctly, but
the mode was blocked at probe time as there wasn't HW to test this with.
Now the mode has been tested, and it works.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/media/i2c/ds90ub960.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Fri, Jun 16, 2023 at 04:59:20PM +0300, Tomi Valkeinen wrote: > Allow using FPD-Link in async mode. The driver handles it correctly, but > the mode was blocked at probe time as there wasn't HW to test this with. > Now the mode has been tested, and it works. Looks good, but I assume you will incorporate this into the original code. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On 16/06/2023 17:34, Andy Shevchenko wrote: > On Fri, Jun 16, 2023 at 04:59:20PM +0300, Tomi Valkeinen wrote: >> Allow using FPD-Link in async mode. The driver handles it correctly, but >> the mode was blocked at probe time as there wasn't HW to test this with. >> Now the mode has been tested, and it works. > > Looks good, but I assume you will incorporate this into the original code. Perhaps, but to be honest, I just want to get the basic set merged, as it's been circulating for so many years. So, as I mentioned in the earlier email, it was perhaps a mistake to include these additional changes... If the reviews for the new commits are quick and easy, I can squash them and send a v15. But if there's anything that needs more discussions, I'd like to leave the rest for later. Tomi
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 6b70fa5bb22f..b0ffca51ee62 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -3240,7 +3240,6 @@ ub960_parse_dt_rxport_link_properties(struct ub960_data *priv, switch (rx_mode) { case RXPORT_MODE_RAW12_HF: case RXPORT_MODE_RAW12_LF: - case RXPORT_MODE_CSI2_ASYNC: dev_err(dev, "rx%u: unsupported 'ti,rx-mode' %u\n", nport, rx_mode); return -EINVAL;